From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga11.intel.com (mga11.intel.com [192.55.52.93]) by dpdk.org (Postfix) with ESMTP id ACCF01B429 for ; Mon, 9 Jul 2018 16:25:48 +0200 (CEST) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga005.jf.intel.com ([10.7.209.41]) by fmsmga102.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 09 Jul 2018 07:25:46 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.51,330,1526367600"; d="scan'208";a="238923682" Received: from irsmsx105.ger.corp.intel.com ([163.33.3.28]) by orsmga005.jf.intel.com with ESMTP; 09 Jul 2018 07:25:24 -0700 Received: from irsmsx108.ger.corp.intel.com ([169.254.11.139]) by irsmsx105.ger.corp.intel.com ([169.254.7.26]) with mapi id 14.03.0319.002; Mon, 9 Jul 2018 15:25:23 +0100 From: "De Lara Guarch, Pablo" To: "Wang, Yipeng1" CC: "dev@dpdk.org" , "Richardson, Bruce" , "honnappa.nagarahalli@arm.com" , "vguvva@caviumnetworks.com" , "brijesh.s.singh@gmail.com" Thread-Topic: [PATCH v3 4/8] hash: make duplicated code into functions Thread-Index: AQHUFZ3IztHahXaJNUKGJepirhNYUqSG9Rcw Date: Mon, 9 Jul 2018 14:25:23 +0000 Message-ID: References: <1528455078-328182-1-git-send-email-yipeng1.wang@intel.com> <1530906406-289697-1-git-send-email-yipeng1.wang@intel.com> <1530906406-289697-5-git-send-email-yipeng1.wang@intel.com> In-Reply-To: <1530906406-289697-5-git-send-email-yipeng1.wang@intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiMjc5NzQwOWEtOTAzZS00ZDQ3LThiYjMtNzQ0ZmZlMjdlYzliIiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX05UIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE3LjEwLjE4MDQuNDkiLCJUcnVzdGVkTGFiZWxIYXNoIjoiUnVOXC9cL21pVURjMDRwZkt3ck5QQXdEQUVTR1pYQm9GaUhwQUJwM09kQnRGOFlvdTZ2XC9GWGNDeEFaRWFXb1lUdyJ9 x-ctpclassification: CTP_NT dlp-product: dlpe-windows dlp-version: 11.0.200.100 dlp-reaction: no-action x-originating-ip: [163.33.239.182] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH v3 4/8] hash: make duplicated code into functions X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 09 Jul 2018 14:25:49 -0000 > -----Original Message----- > From: Wang, Yipeng1 > Sent: Friday, July 6, 2018 8:47 PM > To: De Lara Guarch, Pablo > Cc: dev@dpdk.org; Wang, Yipeng1 ; Richardson, > Bruce ; honnappa.nagarahalli@arm.com; > vguvva@caviumnetworks.com; brijesh.s.singh@gmail.com > Subject: [PATCH v3 4/8] hash: make duplicated code into functions >=20 > This commit refactors the hash table lookup/add/del code to remove some c= ode > duplication. Processing on primary bucket can also apply to secondary buc= ket > with same code. >=20 > Signed-off-by: Yipeng Wang > --- > lib/librte_hash/rte_cuckoo_hash.c | 186 +++++++++++++++++++-------------= ------ ... > @@ -838,41 +830,45 @@ __rte_hash_del_key_with_hash(const struct rte_hash > *h, const void *key, > if (rte_hash_cmp_eq(key, k->key, h) =3D=3D 0) { > remove_entry(h, bkt, i); >=20 > + ret =3D bkt->key_idx[i] - 1; > + bkt->key_idx[i] =3D EMPTY_SLOT; > /* > * Return index where key is stored, > * subtracting the first dummy index > */ > - ret =3D bkt->key_idx[i] - 1; > - bkt->key_idx[i] =3D EMPTY_SLOT; Actually, this change doesn't look needed, right? It looks like you are just moving the two lines before the comment. Apart from this, Acked-by: Pablo de Lara