From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga14.intel.com (mga14.intel.com [192.55.52.115]) by dpdk.org (Postfix) with ESMTP id 894395F1F for ; Tue, 10 Jul 2018 00:23:42 +0200 (CEST) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga008.jf.intel.com ([10.7.209.65]) by fmsmga103.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 09 Jul 2018 15:23:41 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.51,330,1526367600"; d="scan'208";a="55597413" Received: from irsmsx153.ger.corp.intel.com ([163.33.192.75]) by orsmga008.jf.intel.com with ESMTP; 09 Jul 2018 15:23:39 -0700 Received: from irsmsx107.ger.corp.intel.com ([169.254.10.193]) by IRSMSX153.ger.corp.intel.com ([169.254.9.210]) with mapi id 14.03.0319.002; Mon, 9 Jul 2018 23:23:38 +0100 From: "De Lara Guarch, Pablo" To: Shally Verma CC: "dev@dpdk.org" , "pathreya@caviumnetworks.com" , "nmurthy@caviumnetworks.com" , Sunila Sahu , Ashish Gupta , Umesh Kartha Thread-Topic: [PATCH v4 1/4] lib/cryptodev: add asymmetric algos in cryptodev Thread-Index: AQHUEuISiu1z0K2b7Uelx9Q5DSRQWKSHfynA Date: Mon, 9 Jul 2018 22:23:38 +0000 Message-ID: References: <1530631466-26427-1-git-send-email-shally.verma@caviumnetworks.com> <1530631466-26427-2-git-send-email-shally.verma@caviumnetworks.com> In-Reply-To: <1530631466-26427-2-git-send-email-shally.verma@caviumnetworks.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiMjFmZWQxYmUtMThiZS00MTU4LWJkNTUtYmZjNTVlMzY0ZjkzIiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX05UIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE3LjEwLjE4MDQuNDkiLCJUcnVzdGVkTGFiZWxIYXNoIjoibUpZcVZEcjViNkk1bkFYMW1sRG1LbmdyVVpQa1Q3MWtPaWQ2cllodVR1bklUMXM2elFXZFV5cjBIRWsrRDhmMCJ9 x-ctpclassification: CTP_NT dlp-product: dlpe-windows dlp-version: 11.0.200.100 dlp-reaction: no-action x-originating-ip: [163.33.239.181] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH v4 1/4] lib/cryptodev: add asymmetric algos in cryptodev X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 09 Jul 2018 22:23:43 -0000 Hi Shally, A few minor comments: > -----Original Message----- > From: Shally Verma [mailto:shally.verma@caviumnetworks.com] > Sent: Tuesday, July 3, 2018 4:24 PM > To: De Lara Guarch, Pablo > Cc: dev@dpdk.org; pathreya@caviumnetworks.com; > nmurthy@caviumnetworks.com; Sunila Sahu > ; Ashish Gupta > ; Umesh Kartha > > Subject: [PATCH v4 1/4] lib/cryptodev: add asymmetric algos in cryptodev >=20 Change title to: "cryptodev: add basic asymmetric structures"? At least, don't use lib, and cryptodev twice. > Add rte_crypto_asym.h with supported xfrms and associated op structures a= nd > APIs >=20 > API currently supports: > - RSA Encrypt, Decrypt, Sign and Verify > - Modular Exponentiation and Inversion > - DSA Sign and Verify > - Deffie-hellman private key exchange Diffie-Hellman > - Deffie-hellman public key exchange > - Deffie-hellman shared secret compute > - Deffie-hellman public/private key pair generation using xform chain >=20 > Signed-off-by: Shally Verma > Signed-off-by: Sunila Sahu > Signed-off-by: Ashish Gupta > Signed-off-by: Umesh Kartha