From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga11.intel.com (mga11.intel.com [192.55.52.93]) by dpdk.org (Postfix) with ESMTP id BD0BC2BDF for ; Tue, 10 Jul 2018 00:34:57 +0200 (CEST) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga001.fm.intel.com ([10.253.24.23]) by fmsmga102.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 09 Jul 2018 15:34:56 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.51,330,1526367600"; d="scan'208";a="70936084" Received: from irsmsx151.ger.corp.intel.com ([163.33.192.59]) by fmsmga001.fm.intel.com with ESMTP; 09 Jul 2018 15:34:51 -0700 Received: from irsmsx112.ger.corp.intel.com (10.108.20.5) by IRSMSX151.ger.corp.intel.com (163.33.192.59) with Microsoft SMTP Server (TLS) id 14.3.319.2; Mon, 9 Jul 2018 23:34:50 +0100 Received: from irsmsx107.ger.corp.intel.com ([169.254.10.193]) by irsmsx112.ger.corp.intel.com ([169.254.1.22]) with mapi id 14.03.0319.002; Mon, 9 Jul 2018 23:34:50 +0100 From: "De Lara Guarch, Pablo" To: Shally Verma CC: "dev@dpdk.org" , "pathreya@caviumnetworks.com" , "nmurthy@caviumnetworks.com" , Ashish Gupta , Sunila Sahu , Umesh Kartha Thread-Topic: [PATCH v4 3/4] lib/cryptodev: add asymmetric crypto capability in cryptodev Thread-Index: AQHUEuIUcKvyFv1JfE644SmbNePwDKSHgi0g Date: Mon, 9 Jul 2018 22:34:49 +0000 Message-ID: References: <1530631466-26427-1-git-send-email-shally.verma@caviumnetworks.com> <1530631466-26427-4-git-send-email-shally.verma@caviumnetworks.com> In-Reply-To: <1530631466-26427-4-git-send-email-shally.verma@caviumnetworks.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiZjNmMTYxOTAtOTY5OC00ZDhlLWIyY2UtMjliZjJkYTRiNTkzIiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX05UIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE3LjEwLjE4MDQuNDkiLCJUcnVzdGVkTGFiZWxIYXNoIjoiMVFJY2NLXC90YkNRYTBRdVlnSldjQkd6ZldCSlJZNFAyakVlXC9HVkpJOE9tenNIVlwvbldUMUdrd1pKK25Ka2FcL1QifQ== x-ctpclassification: CTP_NT dlp-product: dlpe-windows dlp-version: 11.0.200.100 dlp-reaction: no-action x-originating-ip: [163.33.239.181] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH v4 3/4] lib/cryptodev: add asymmetric crypto capability in cryptodev X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 09 Jul 2018 22:34:58 -0000 > -----Original Message----- > From: Shally Verma [mailto:shally.verma@caviumnetworks.com] > Sent: Tuesday, July 3, 2018 4:24 PM > To: De Lara Guarch, Pablo > Cc: dev@dpdk.org; pathreya@caviumnetworks.com; > nmurthy@caviumnetworks.com; Ashish Gupta > ; Sunila Sahu > ; Umesh Kartha > > Subject: [PATCH v4 3/4] lib/cryptodev: add asymmetric crypto capability i= n > cryptodev >=20 Remove "in cryptodev" from title, as it is redundant (and lib/). > From: Ashish Gupta >=20 > Extend cryptodev with asymmetric capability APIs and definitions. >=20 > Signed-off-by: Shally Verma > Signed-off-by: Sunila Sahu > Signed-off-by: Ashish Gupta > Signed-off-by: Umesh Kartha > ... +++ b/lib/librte_cryptodev/rte_cryptodev.c ... > + for (i =3D 1; i < RTE_DIM(rte_crypto_asym_xform_strings); i++) { > + if (strcmp(xform_string, > + rte_crypto_asym_xform_strings[i]) =3D=3D 0) { Add indentation here. > + *xform_enum =3D (enum rte_crypto_asym_xform_type) i; > + return 0; > + } > + } > + > + /* Invalid string */ > + return -1; > +} ... > +++ b/lib/librte_cryptodev/rte_cryptodev.h ... > /** > + * Provide capabilities available for defined device and algorithm > + * > + * @param dev_id The identifier of the device. > + * @param algo Description of crypto algorithms. > + * Build error on API docs: lib/librte_cryptodev/rte_cryptodev.h:224: warning: argument 'algo' of comma= nd @param is not found in the argument list of rte_cryptodev_asym_capability_g= et(uint8_t dev_id, const struct rte_cryptodev_asym_capability_idx *idx) lib/librte_cryptodev/rte_cryptodev.h:234: warning: The following parameters= of rte_cryptodev_asym_capability_get(uint8_t dev_id, const struct rte_cryptode= v_asym_capability_idx *idx) are not documented: parameter 'idx'