From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga01.intel.com (mga01.intel.com [192.55.52.88]) by dpdk.org (Postfix) with ESMTP id 0F3501B398 for ; Tue, 10 Jul 2018 10:08:54 +0200 (CEST) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga002.fm.intel.com ([10.253.24.26]) by fmsmga101.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 10 Jul 2018 01:08:53 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.51,333,1526367600"; d="scan'208";a="65644568" Received: from irsmsx110.ger.corp.intel.com ([163.33.3.25]) by fmsmga002.fm.intel.com with ESMTP; 10 Jul 2018 01:08:46 -0700 Received: from irsmsx107.ger.corp.intel.com ([169.254.10.193]) by irsmsx110.ger.corp.intel.com ([169.254.15.197]) with mapi id 14.03.0319.002; Tue, 10 Jul 2018 09:08:45 +0100 From: "De Lara Guarch, Pablo" To: "Verma, Shally" CC: "dev@dpdk.org" , "Athreya, Narayana Prasad" , "Murthy, Nidadavolu" , "Sahu, Sunila" , "Gupta, Ashish" , "Kartha, Umesh" Thread-Topic: [PATCH v4 1/4] lib/cryptodev: add asymmetric algos in cryptodev Thread-Index: AQHUEuISiu1z0K2b7Uelx9Q5DSRQWKSHfynAgABmSwCAAD4TkA== Date: Tue, 10 Jul 2018 08:08:45 +0000 Message-ID: References: <1530631466-26427-1-git-send-email-shally.verma@caviumnetworks.com> <1530631466-26427-2-git-send-email-shally.verma@caviumnetworks.com> In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiN2U1NGEwMDgtNzhiMi00MjQ0LTg5ZTctNTIxZDIxMjMzMGNmIiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX05UIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE3LjEwLjE4MDQuNDkiLCJUcnVzdGVkTGFiZWxIYXNoIjoiY2xBK1lkU1wveU5PWVNKdWdHZFpBTTlHVEl2bStFdHlcL2xXaTdJS1NsOXk2NnhjMnpDSlFacUFZWlBCRUEzcEh1In0= x-ctpclassification: CTP_NT dlp-product: dlpe-windows dlp-version: 11.0.200.100 dlp-reaction: no-action x-originating-ip: [163.33.239.182] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH v4 1/4] lib/cryptodev: add asymmetric algos in cryptodev X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 10 Jul 2018 08:08:55 -0000 > -----Original Message----- > From: Verma, Shally [mailto:Shally.Verma@cavium.com] > Sent: Tuesday, July 10, 2018 6:22 AM > To: De Lara Guarch, Pablo > Cc: dev@dpdk.org; Athreya, Narayana Prasad > ; Murthy, Nidadavolu > ; Sahu, Sunila ; > Gupta, Ashish ; Kartha, Umesh > > Subject: RE: [PATCH v4 1/4] lib/cryptodev: add asymmetric algos in crypto= dev >=20 > Hi Pablo >=20 > >-----Original Message----- > >From: De Lara Guarch, Pablo [mailto:pablo.de.lara.guarch@intel.com] > >Sent: 10 July 2018 03:54 > >To: Verma, Shally > >Cc: dev@dpdk.org; Athreya, Narayana Prasad > >; Murthy, Nidadavolu > >; Sahu, Sunila ; > >Gupta, Ashish ; Kartha, Umesh > > > >Subject: RE: [PATCH v4 1/4] lib/cryptodev: add asymmetric algos in > >cryptodev > > > >External Email > > > >Hi Shally, > > > >A few minor comments: > > > >> -----Original Message----- > >> From: Shally Verma [mailto:shally.verma@caviumnetworks.com] > >> Sent: Tuesday, July 3, 2018 4:24 PM > >> To: De Lara Guarch, Pablo > >> Cc: dev@dpdk.org; pathreya@caviumnetworks.com; > >> nmurthy@caviumnetworks.com; Sunila Sahu > >> ; Ashish Gupta > >> ; Umesh Kartha > >> > >> Subject: [PATCH v4 1/4] lib/cryptodev: add asymmetric algos in > >> cryptodev > >> > > > >Change title to: "cryptodev: add basic asymmetric structures"? > >At least, don't use lib, and cryptodev twice. >=20 > So what's convention for all patches? Just cryptodev: ? Correct. For libraries, title prefix should be just the name of the library= . For other components, we usually need two names, the folder where the belon= g and the component name. For example, for drivers, we use the folder where they belong and their nam= e (e.g. crypto/openssl). Pablo >=20 > Thanks > Shally >=20 > > > >> Add rte_crypto_asym.h with supported xfrms and associated op > >> structures and APIs > >> > >> API currently supports: > >> - RSA Encrypt, Decrypt, Sign and Verify > >> - Modular Exponentiation and Inversion > >> - DSA Sign and Verify > >> - Deffie-hellman private key exchange > > > >Diffie-Hellman > > > >> - Deffie-hellman public key exchange > >> - Deffie-hellman shared secret compute > >> - Deffie-hellman public/private key pair generation using xform chain > >> > >> Signed-off-by: Shally Verma > >> Signed-off-by: Sunila Sahu > >> Signed-off-by: Ashish Gupta > >> Signed-off-by: Umesh Kartha > >