From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga02.intel.com (mga02.intel.com [134.134.136.20]) by dpdk.org (Postfix) with ESMTP id ED1591B05B for ; Tue, 10 Jul 2018 12:26:46 +0200 (CEST) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga002.jf.intel.com ([10.7.209.21]) by orsmga101.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 10 Jul 2018 03:26:45 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.51,334,1526367600"; d="scan'208";a="73604698" Received: from irsmsx104.ger.corp.intel.com ([163.33.3.159]) by orsmga002.jf.intel.com with ESMTP; 10 Jul 2018 03:26:13 -0700 Received: from irsmsx107.ger.corp.intel.com ([169.254.10.193]) by IRSMSX104.ger.corp.intel.com ([169.254.5.225]) with mapi id 14.03.0319.002; Tue, 10 Jul 2018 11:26:12 +0100 From: "De Lara Guarch, Pablo" To: Anoob Joseph , "Doherty, Declan" CC: Akhil Goyal , Ankur Dwivedi , Jerin Jacob , Narayana Prasad , "dev@dpdk.org" Thread-Topic: [dpdk-dev] [PATCH v1 1/3] cryptodev: add min headroom and tailroom requirement Thread-Index: AQHUE57g00cfzJYFPkaSiU4dT0fF9qSISDDQ Date: Tue, 10 Jul 2018 10:26:12 +0000 Message-ID: References: <1529389574-6643-1-git-send-email-anoob.joseph@caviumnetworks.com> <1530712550-18099-1-git-send-email-anoob.joseph@caviumnetworks.com> <1530712550-18099-2-git-send-email-anoob.joseph@caviumnetworks.com> In-Reply-To: <1530712550-18099-2-git-send-email-anoob.joseph@caviumnetworks.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiMGYwNzM0Y2QtZjQwYS00ODAwLWJjNjMtZGFhYzUwMjk5MjZhIiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX05UIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE3LjEwLjE4MDQuNDkiLCJUcnVzdGVkTGFiZWxIYXNoIjoiVThrZEViREo5XC84KzQ2aXJEQTlSUk1FaFVzUlFwZzREdHZZeGowalcybXlqZVRWTWw1K09kazByZHdYdVBJYnUifQ== x-ctpclassification: CTP_NT dlp-product: dlpe-windows dlp-version: 11.0.200.100 dlp-reaction: no-action x-originating-ip: [163.33.239.182] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH v1 1/3] cryptodev: add min headroom and tailroom requirement X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 10 Jul 2018 10:26:47 -0000 Hi Anoob, > -----Original Message----- > From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Anoob Joseph > Sent: Wednesday, July 4, 2018 2:56 PM > To: Doherty, Declan ; De Lara Guarch, Pablo > > Cc: Anoob Joseph ; Akhil Goyal > ; Ankur Dwivedi > ; Jerin Jacob > ; Narayana Prasad > ; dev@dpdk.org > Subject: [dpdk-dev] [PATCH v1 1/3] cryptodev: add min headroom and tailro= om > requirement >=20 > Enabling crypto devs to specify the minimum headroom and tailroom it expe= cts > in the mbuf. For net PMDs, standard headroom has to be honoured by > applications, which is not strictly followed for crypto devs. This preven= ts crypto > devs from using free space in mbuf (available as > head/tailroom) for internal requirements in crypto operations. Addition o= f > head/tailroom requirement will help PMDs to communicate such requirements > to the application. >=20 > The availability and use of head/tailroom is an optimization if the hardw= are > supports use of head/tailroom for crypto-op info. For devices that do not > support using the head/tailroom, they can continue to operate without any > performance-drop. >=20 > Signed-off-by: Anoob Joseph > --- > v1: > * Removed deprecation notice > * Updated release note > * Renamed new fields to have 'mbuf' in the name > * Changed the type of new fields to uint16_t (instead of uint32_t) >=20 > doc/guides/rel_notes/release_18_08.rst | 6 ++++++ > lib/librte_cryptodev/rte_cryptodev.h | 6 ++++++ > 2 files changed, 12 insertions(+) >=20 > diff --git a/doc/guides/rel_notes/release_18_08.rst > b/doc/guides/rel_notes/release_18_08.rst > index 5bc23c5..fae0d26 100644 > --- a/doc/guides/rel_notes/release_18_08.rst > +++ b/doc/guides/rel_notes/release_18_08.rst > @@ -70,6 +70,12 @@ ABI Changes > Also, make sure to start the actual text at the margin. > =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D >=20 > +* cryptodev: Additional fields in rte_cryptodev_info. > + > + Two new fields of type ``uint16_t`` added in ``rte_cryptodev_info`` > + structure: ``min_mbuf_headroom_req`` and ``min_mbuf_tailroom_req``. > + These parameters specify the recommended headroom and tailroom for > + mbufs to be processed by the PMD. I think the "cryptodev scheduler PMD" needs changes to take these new param= eters into consideration. Scheduler_pmd_info_get should return the maximum number of these two fields= on all the slaves (like what's done with max number of sessions). We need to close the subtree today, with all API changes done. Will you hav= e time to make this change today? Thanks! Pablo