From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga01.intel.com (mga01.intel.com [192.55.52.88]) by dpdk.org (Postfix) with ESMTP id 06E551B54E for ; Wed, 11 Jul 2018 14:14:28 +0200 (CEST) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga007.fm.intel.com ([10.253.24.52]) by fmsmga101.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 11 Jul 2018 05:14:28 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.51,338,1526367600"; d="scan'208";a="53572258" Received: from irsmsx106.ger.corp.intel.com ([163.33.3.31]) by fmsmga007.fm.intel.com with ESMTP; 11 Jul 2018 05:14:26 -0700 Received: from irsmsx107.ger.corp.intel.com ([169.254.10.193]) by IRSMSX106.ger.corp.intel.com ([169.254.8.211]) with mapi id 14.03.0319.002; Wed, 11 Jul 2018 13:14:26 +0100 From: "De Lara Guarch, Pablo" To: Shally Verma CC: "dev@dpdk.org" , "pathreya@caviumnetworks.com" , "mchalla@caviumnetworks.com" , Ashish Gupta , Sunila Sahu Thread-Topic: [PATCH v2 1/5] compress/zlib: add ZLIB PMD support Thread-Index: AQHUEiXUVtnBn1wV9E6TldyzTJHtSqSJ+0UA Date: Wed, 11 Jul 2018 12:14:25 +0000 Message-ID: References: <1530550631-22841-1-git-send-email-shally.verma@caviumnetworks.com> <1530550631-22841-2-git-send-email-shally.verma@caviumnetworks.com> In-Reply-To: <1530550631-22841-2-git-send-email-shally.verma@caviumnetworks.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiODJkOTcwYmItMTBkMi00MDE2LTk3ZjYtMjFhOWQwZDFlZGU1IiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX05UIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE3LjEwLjE4MDQuNDkiLCJUcnVzdGVkTGFiZWxIYXNoIjoicXVaR3BcL0hjUVNCK01EdEhOMW9ldENaRndZdGtkYUxcLzgrXC95MEJcLzJ4MEdpV0cwMk9neDVQRW54VnhNRXpyMU8ifQ== x-ctpclassification: CTP_NT dlp-product: dlpe-windows dlp-version: 11.0.200.100 dlp-reaction: no-action x-originating-ip: [163.33.239.182] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH v2 1/5] compress/zlib: add ZLIB PMD support X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 11 Jul 2018 12:14:29 -0000 And the last comments, sorry for the multiple replies. > -----Original Message----- > From: Shally Verma [mailto:shally.verma@caviumnetworks.com] > Sent: Monday, July 2, 2018 5:57 PM > To: De Lara Guarch, Pablo > Cc: dev@dpdk.org; pathreya@caviumnetworks.com; > mchalla@caviumnetworks.com; Ashish Gupta > ; Sunila Sahu > > Subject: [PATCH v2 1/5] compress/zlib: add ZLIB PMD support >=20 > From: Ashish Gupta >=20 > Add sw zlib pmd support in compressdev driver. > Add device probe and remove support. > Add ZLIB build file support. >=20 > Signed-off-by: Sunila Sahu > Signed-off-by: Shally Verma > Signed-off-by: Ashish Gupta ... > +++ b/drivers/compress/zlib/zlib_pmd.c ... > +static void > +zlib_init_log(void) > +{ > + zlib_logtype_driver =3D rte_log_register("compress_zlib"); The standard for the name of the logtype for PMDs is "pmd.driverType.driver= Name", so in this case it would be "pmd.compress.zlib". > + if (zlib_logtype_driver >=3D 0) > + rte_log_set_level(zlib_logtype_driver, RTE_LOG_INFO); } > diff --git a/drivers/compress/zlib/zlib_pmd_private.h > b/drivers/compress/zlib/zlib_pmd_private.h > new file mode 100644 > index 0000000..d4c80b1 > --- /dev/null > +++ b/drivers/compress/zlib/zlib_pmd_private.h ... > +#define ZLIB_PMD_INFO(fmt, args...) \ > + ZLIB_PMD_LOG(INFO, fmt, ## args) > +#define ZLIB_PMD_ERR(fmt, args...) \ > + ZLIB_PMD_LOG(ERR, fmt, ## args) > +#define ZLIB_PMD_WARN(fmt, args...) \ > + ZLIB_PMD_LOG(WARNING, fmt, ## args) What do you think of having a single macro ZLIB_LOG(level, fmt, args...)?