From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga03.intel.com (mga03.intel.com [134.134.136.65]) by dpdk.org (Postfix) with ESMTP id C4C1514E8 for ; Fri, 13 Jul 2018 17:57:57 +0200 (CEST) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga007.fm.intel.com ([10.253.24.52]) by orsmga103.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 13 Jul 2018 08:57:55 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.51,348,1526367600"; d="scan'208";a="54154210" Received: from irsmsx109.ger.corp.intel.com ([163.33.3.23]) by fmsmga007.fm.intel.com with ESMTP; 13 Jul 2018 08:57:33 -0700 Received: from irsmsx107.ger.corp.intel.com ([169.254.10.193]) by IRSMSX109.ger.corp.intel.com ([169.254.13.124]) with mapi id 14.03.0319.002; Fri, 13 Jul 2018 16:57:32 +0100 From: "De Lara Guarch, Pablo" To: "Verma, Shally" CC: "dev@dpdk.org" , "Athreya, Narayana Prasad" , "Challa, Mahipal" , "Gupta, Ashish" , "Sahu, Sunila" Thread-Topic: [PATCH v2 1/5] compress/zlib: add ZLIB PMD support Thread-Index: AQHUEiXUVtnBn1wV9E6TldyzTJHtSqSJ+0UA///4gQCAA2xL4A== Date: Fri, 13 Jul 2018 15:57:31 +0000 Message-ID: References: <1530550631-22841-1-git-send-email-shally.verma@caviumnetworks.com> <1530550631-22841-2-git-send-email-shally.verma@caviumnetworks.com> In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiMDg2MmViNWQtYmE5ZS00NzcwLTg2MmUtMmI5MDlmODhkNDIzIiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX05UIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE3LjEwLjE4MDQuNDkiLCJUcnVzdGVkTGFiZWxIYXNoIjoieHEyMjVoMTFPSW1RSGp4WlVDUFlrSDlyMStwRjRlbitkR1R5bm1oVzg5dVlaOW5QNXFuSm4raE9yM2lNY1BGSCJ9 x-ctpclassification: CTP_NT dlp-product: dlpe-windows dlp-version: 11.0.200.100 dlp-reaction: no-action x-originating-ip: [163.33.239.181] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH v2 1/5] compress/zlib: add ZLIB PMD support X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 13 Jul 2018 15:57:58 -0000 > -----Original Message----- > From: Verma, Shally [mailto:Shally.Verma@cavium.com] > Sent: Wednesday, July 11, 2018 1:41 PM > To: De Lara Guarch, Pablo > Cc: dev@dpdk.org; Athreya, Narayana Prasad > ; Challa, Mahipal > ; Gupta, Ashish ; > Sahu, Sunila > Subject: RE: [PATCH v2 1/5] compress/zlib: add ZLIB PMD support >=20 > Hi Pablo >=20 > >-----Original Message----- > >From: De Lara Guarch, Pablo [mailto:pablo.de.lara.guarch@intel.com] > >Sent: 11 July 2018 17:44 > >To: Verma, Shally > >Cc: dev@dpdk.org; Athreya, Narayana Prasad > >; Challa, Mahipal > >; Gupta, Ashish ; > >Sahu, Sunila > >Subject: RE: [PATCH v2 1/5] compress/zlib: add ZLIB PMD support > > > >External Email > > > >And the last comments, sorry for the multiple replies. >=20 > No issues. >=20 > > > >> -----Original Message----- > >> From: Shally Verma [mailto:shally.verma@caviumnetworks.com] > >> Sent: Monday, July 2, 2018 5:57 PM > >> To: De Lara Guarch, Pablo > >> Cc: dev@dpdk.org; pathreya@caviumnetworks.com; > >> mchalla@caviumnetworks.com; Ashish Gupta > >> ; Sunila Sahu > >> > >> Subject: [PATCH v2 1/5] compress/zlib: add ZLIB PMD support > >> > >> From: Ashish Gupta > >> > >> Add sw zlib pmd support in compressdev driver. > >> Add device probe and remove support. > >> Add ZLIB build file support. > >> > >> Signed-off-by: Sunila Sahu > >> Signed-off-by: Shally Verma > >> Signed-off-by: Ashish Gupta > > > >... > > > >> +++ b/drivers/compress/zlib/zlib_pmd.c > > > >... > > > >> +static void > >> +zlib_init_log(void) > >> +{ > >> + zlib_logtype_driver =3D rte_log_register("compress_zlib"); > > > >The standard for the name of the logtype for PMDs is > >"pmd.driverType.driverName", so in this case it would be "pmd.compress.z= lib". > > > > > >> + if (zlib_logtype_driver >=3D 0) > >> + rte_log_set_level(zlib_logtype_driver, RTE_LOG_INFO); } > >> diff --git a/drivers/compress/zlib/zlib_pmd_private.h > >> b/drivers/compress/zlib/zlib_pmd_private.h > >> new file mode 100644 > >> index 0000000..d4c80b1 > >> --- /dev/null > >> +++ b/drivers/compress/zlib/zlib_pmd_private.h > > > >... > > > >> +#define ZLIB_PMD_INFO(fmt, args...) \ > >> + ZLIB_PMD_LOG(INFO, fmt, ## args) #define ZLIB_PMD_ERR(fmt, > >> +args...) \ > >> + ZLIB_PMD_LOG(ERR, fmt, ## args) #define ZLIB_PMD_WARN(fmt, > >> +args...) \ > >> + ZLIB_PMD_LOG(WARNING, fmt, ## args) > > > >What do you think of having a single macro ZLIB_LOG(level, fmt, args...)= ? > > > I find it simpler to use ZLIB_PMD_INFO/ERR?DEBUG version . So would prefe= r to > stick to them. Ok for me then. >=20 > Thanks for review. > Shally >=20