From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga18.intel.com (mga18.intel.com [134.134.136.126]) by dpdk.org (Postfix) with ESMTP id 27AB42951 for ; Fri, 13 Jul 2018 18:23:18 +0200 (CEST) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga001.jf.intel.com ([10.7.209.18]) by orsmga106.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 13 Jul 2018 09:23:18 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.51,348,1526367600"; d="scan'208";a="72518261" Received: from irsmsx102.ger.corp.intel.com ([163.33.3.155]) by orsmga001.jf.intel.com with ESMTP; 13 Jul 2018 09:23:16 -0700 Received: from irsmsx107.ger.corp.intel.com ([169.254.10.193]) by IRSMSX102.ger.corp.intel.com ([169.254.2.110]) with mapi id 14.03.0319.002; Fri, 13 Jul 2018 17:23:15 +0100 From: "De Lara Guarch, Pablo" To: Shally Verma CC: "dev@dpdk.org" , "pathreya@caviumnetworks.com" , "mchalla@caviumnetworks.com" , Sunila Sahu , Ashish Gupta Thread-Topic: [PATCH v2 1/6] compress/octeontx: add octeontx zip PMD support Thread-Index: AQHUEiWNVJEfnYCONUSV7285vSOcmaSKMOBA Date: Fri, 13 Jul 2018 16:23:15 +0000 Message-ID: References: <1530550477-22444-1-git-send-email-shally.verma@caviumnetworks.com> <1530550477-22444-2-git-send-email-shally.verma@caviumnetworks.com> In-Reply-To: <1530550477-22444-2-git-send-email-shally.verma@caviumnetworks.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiMzJhMDFjNzAtNjA1Ny00ZGJmLTgzMmMtODBkNGMwMDYwNGRmIiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX05UIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE3LjEwLjE4MDQuNDkiLCJUcnVzdGVkTGFiZWxIYXNoIjoiRmNXRnRDbXlYdHQ1Tnl1UktZV1hlZzJBNVRJY21jMEE3UW10NktHMEFvVEtBOHJkNW9Ob1VtYmlZc1Y5dDY2UCJ9 x-ctpclassification: CTP_NT dlp-product: dlpe-windows dlp-version: 11.0.200.100 dlp-reaction: no-action x-originating-ip: [163.33.239.181] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH v2 1/6] compress/octeontx: add octeontx zip PMD support X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 13 Jul 2018 16:23:19 -0000 > -----Original Message----- > From: Shally Verma [mailto:shally.verma@caviumnetworks.com] > Sent: Monday, July 2, 2018 5:55 PM > To: De Lara Guarch, Pablo > Cc: dev@dpdk.org; pathreya@caviumnetworks.com; > mchalla@caviumnetworks.com; Sunila Sahu > ; Ashish Gupta > > Subject: [PATCH v2 1/6] compress/octeontx: add octeontx zip PMD support Remove support from title. >=20 > From: Sunila Sahu >=20 > Add octeontx zip pmd support in compressdev driver. > Octeontx ZIP appears as PCI device. > Add device probe and remove support. > link zip pmd library in rtp.app.mk > Update meson.build and Makefile to build octeontx zip pmd It is better to have an introduction on the PMD here, instead of listing al= l you are doing in the patch. >=20 > Signed-off-by: Ashish Gupta > Signed-off-by: Shally Verma > Signed-off-by: Sunila Sahu > --- > MAINTAINERS | 5 + > config/common_base | 5 + > drivers/compress/Makefile | 1 + > drivers/compress/meson.build | 2 +- > drivers/compress/octeontx/Makefile | 30 + > drivers/compress/octeontx/include/zip_regs.h | 721 > +++++++++++++++++++++ > drivers/compress/octeontx/meson.build | 11 + > .../compress/octeontx/rte_pmd_octeontx_version.map | 3 + > drivers/compress/octeontx/zip_pmd.c | 120 ++++ > drivers/compress/octeontx/zipvf.c | 63 ++ > drivers/compress/octeontx/zipvf.h | 111 ++++ > mk/rte.app.mk | 1 + > 12 files changed, 1072 insertions(+), 1 deletion(-) >=20 > diff --git a/MAINTAINERS b/MAINTAINERS > index bc1607844..78708d8af 100644 > --- a/MAINTAINERS > +++ b/MAINTAINERS > @@ -850,6 +850,11 @@ F: drivers/compress/isal/ > F: doc/guides/compressdevs/isal.rst > F: doc/guides/compressdevs/features/isal.ini >=20 > +Cavium OCTEONTX zipvf > +M: Ashish Gupta > +F: drivers/compress/octeontx > +F: doc/guides/compressdevs/octeontx.rst > +F: doc/guides/compressdevs/features/octeontx.ini The documentation is not yet in this patch, so add it later. >=20 > Eventdev Drivers > ---------------- > diff --git a/config/common_base b/config/common_base index > 6541ad5b2..396a09682 100644 > --- a/config/common_base > +++ b/config/common_base > @@ -578,6 +578,11 @@ CONFIG_RTE_COMPRESS_MAX_DEVS=3D64 # > CONFIG_RTE_COMPRESSDEV_TEST=3Dn >=20 > +# > +# Compile PMD for Octeontx ZIPVF compression device # > +CONFIG_RTE_LIBRTE_PMD_OCTEONTX_ZIPVF=3Dy > + > # > # Compile PMD for ISA-L compression device # diff --git > a/drivers/compress/Makefile b/drivers/compress/Makefile index > 592497f51..25cced348 100644 > --- a/drivers/compress/Makefile > +++ b/drivers/compress/Makefile > @@ -4,5 +4,6 @@ > include $(RTE_SDK)/mk/rte.vars.mk >=20 > DIRS-$(CONFIG_RTE_LIBRTE_PMD_ISAL) +=3D isal > +DIRS-$(CONFIG_RTE_LIBRTE_PMD_OCTEONTX_ZIPVF) +=3D octeontx >=20 > include $(RTE_SDK)/mk/rte.subdir.mk > diff --git a/drivers/compress/meson.build b/drivers/compress/meson.build = index > fb136e1b2..a7d6f3a40 100644 > --- a/drivers/compress/meson.build > +++ b/drivers/compress/meson.build > @@ -1,7 +1,7 @@ > # SPDX-License-Identifier: BSD-3-Clause # Copyright(c) 2018 Intel Corpo= ration >=20 > -drivers =3D ['isal'] > +drivers =3D ['isal', 'octeontx'] There is a compilation error on meson: drivers/meson.build:108:3: ERROR: File=20 drivers/compress/octeontx/rte_pmd_octeontx_compress_version.map does not ex= ist. ... > + return rte_compressdev_pmd_destroy(compressdev); > +} > + > + > + Too many blank lines here. > +static struct rte_pci_id pci_id_octtx_zipvf_table[] =3D { > + { > + RTE_PCI_DEVICE(PCI_VENDOR_ID_CAVIUM, > + ... > +static void > +octtx_zip_init_log(void) > +{ > + octtx_zip_logtype_driver =3D rte_log_register("comp_octeontx_zip"); Naming convention for the PMD logtypes is "pmd.driverType.driverName". In this case, "pmd.compress.octeonx". > + if (octtx_zip_logtype_driver >=3D 0) > + rte_log_set_level(octtx_zip_logtype_driver, RTE_LOG_INFO); } > > diff --git a/drivers/compress/octeontx/zipvf.h > b/drivers/compress/octeontx/zipvf.h > new file mode 100644 > index 000000000..36c44c8c5 > --- /dev/null > +++ b/drivers/compress/octeontx/zipvf.h ... > + > +#define ZIP_ALIGN_ROUNDUP(x, _align) \ > + ((_align) * (((x) + (_align) - 1) / (_align))) > + > +/**< ZIP PMD device name */ > +#define COMPRESSDEV_NAME_ZIP_PMD compress_octtx_zipvf The naming convention for PMDs is driverType_driverName, so this should be = compress_octeonx > +