From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga02.intel.com (mga02.intel.com [134.134.136.20]) by dpdk.org (Postfix) with ESMTP id AE5F8235 for ; Mon, 23 Jul 2018 14:33:05 +0200 (CEST) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga006.jf.intel.com ([10.7.209.51]) by orsmga101.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 23 Jul 2018 05:33:02 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.51,393,1526367600"; d="scan'208";a="59925584" Received: from irsmsx102.ger.corp.intel.com ([163.33.3.155]) by orsmga006.jf.intel.com with ESMTP; 23 Jul 2018 05:33:01 -0700 Received: from irsmsx107.ger.corp.intel.com ([169.254.10.193]) by IRSMSX102.ger.corp.intel.com ([169.254.2.110]) with mapi id 14.03.0319.002; Mon, 23 Jul 2018 13:33:00 +0100 From: "De Lara Guarch, Pablo" To: Shally Verma CC: "dev@dpdk.org" , "pathreya@caviumnetworks.com" , "nmurthy@caviumnetworks.com" , Sunila Sahu , Ashish Gupta Thread-Topic: [PATCH v4 1/3] crypto/openssl: add rsa and mod asym op Thread-Index: AQHUGenye7BXd2e9Kkq39XeosRwF5KSczb6g Date: Mon, 23 Jul 2018 12:32:59 +0000 Message-ID: References: <1531404526-17984-1-git-send-email-shally.verma@caviumnetworks.com> <1531404526-17984-2-git-send-email-shally.verma@caviumnetworks.com> In-Reply-To: <1531404526-17984-2-git-send-email-shally.verma@caviumnetworks.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiOTBlN2M1MGEtMWZmZS00ODhmLWEwZDMtZDI3ZGM0NzYzOGE4IiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX05UIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE3LjEwLjE4MDQuNDkiLCJUcnVzdGVkTGFiZWxIYXNoIjoibWU5WUtWc1RtRm9cL3d5YU1iKyt4dGdPWWVnVDBUUWVmQVZyczB1SDdQV2xtZHk4YVwvWU5qSU0yd3VWdzM5OHdWIn0= x-ctpclassification: CTP_NT dlp-product: dlpe-windows dlp-version: 11.0.200.100 dlp-reaction: no-action x-originating-ip: [163.33.239.180] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH v4 1/3] crypto/openssl: add rsa and mod asym op X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 23 Jul 2018 12:33:06 -0000 Hi Shally, > -----Original Message----- > From: Shally Verma [mailto:shally.verma@caviumnetworks.com] > Sent: Thursday, July 12, 2018 3:09 PM > To: De Lara Guarch, Pablo > Cc: dev@dpdk.org; pathreya@caviumnetworks.com; > nmurthy@caviumnetworks.com; Sunila Sahu > ; Ashish Gupta > > Subject: [PATCH v4 1/3] crypto/openssl: add rsa and mod asym op >=20 > From: Sunila Sahu >=20 > - Add compat.h to make pmd compatible to openssl-1.1.0 and > backward version > - Add rsa sign/verify/encrypt/decrypt and modular operation > support >=20 > Signed-off-by: Sunila Sahu > Signed-off-by: Shally Verma > Signed-off-by: Ashish Gupta ... > --- a/drivers/crypto/openssl/rte_openssl_pmd.c > +++ b/drivers/crypto/openssl/rte_openssl_pmd.c ... > + case RTE_CRYPTO_ASYM_OP_VERIFY: > + ret =3D RSA_public_decrypt(op->rsa.sign.length, > + op->rsa.sign.data, > + op->rsa.sign.data, > + rsa, > + pad); > + > + OPENSSL_LOG(DEBUG, > + "Length of public_decrypt %d " > + "length of message %zd\n", > + ret, op->rsa.message.length); > + > + if (memcmp(op->rsa.sign.data, op->rsa.message.data, > + op->rsa.message.length)) { > + OPENSSL_LOG(ERR, > + "RSA sign Verification failed"); > + return -1; > + } There is a compilation issue here (missing "break"?): drivers/crypto/openssl/rte_openssl_pmd.c:1905:6: error: this statement may fall through [-Werror=3Dimplicit-fallthrough=3D] if (memcmp(op->rsa.sign.data, op->rsa.message.data, ^ > + default: > + /* allow ops with invalid args to be pushed to > + * completion queue > + */ > + cop->status =3D RTE_CRYPTO_OP_STATUS_INVALID_ARGS; > + break; > + }