From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga07.intel.com (mga07.intel.com [134.134.136.100]) by dpdk.org (Postfix) with ESMTP id 1C0CDF72 for ; Mon, 23 Jul 2018 14:36:39 +0200 (CEST) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga007.fm.intel.com ([10.253.24.52]) by orsmga105.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 23 Jul 2018 05:36:38 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.51,393,1526367600"; d="scan'208";a="56480409" Received: from irsmsx151.ger.corp.intel.com ([163.33.192.59]) by fmsmga007.fm.intel.com with ESMTP; 23 Jul 2018 05:36:37 -0700 Received: from irsmsx107.ger.corp.intel.com ([169.254.10.193]) by IRSMSX151.ger.corp.intel.com ([169.254.4.36]) with mapi id 14.03.0319.002; Mon, 23 Jul 2018 13:36:36 +0100 From: "De Lara Guarch, Pablo" To: Shally Verma CC: "dev@dpdk.org" , "pathreya@caviumnetworks.com" , "mchalla@caviumnetworks.com" , "ashish.gupta@caviumnetworks.com" , "sunila.sahu@caviumnetworks.com" , Sunila Sahu Thread-Topic: [PATCH v3 4/5] compress/zlib: support burst enqueue/dequeue Thread-Index: AQHUIR89STGvFUefL0GSoNPZICA3xaScwOMQ Date: Mon, 23 Jul 2018 12:36:35 +0000 Message-ID: References: <1532197069-24224-1-git-send-email-shally.verma@caviumnetworks.com> <1532197069-24224-5-git-send-email-shally.verma@caviumnetworks.com> In-Reply-To: <1532197069-24224-5-git-send-email-shally.verma@caviumnetworks.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiNTA4YjY3MWYtYTNiYi00YzZjLTk4YTYtZTBmZjE1NDY3YmQwIiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX05UIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE3LjEwLjE4MDQuNDkiLCJUcnVzdGVkTGFiZWxIYXNoIjoiZG43d2pYdDNcL3pWeU1qRDZycXBuSTZ3XC9xODNVemJuVCtIYkZKeVNqS0ZoM1l6WWpKNWloTU1Cd3Yyd2J1Umd5In0= x-ctpclassification: CTP_NT dlp-product: dlpe-windows dlp-version: 11.0.200.100 dlp-reaction: no-action x-originating-ip: [163.33.239.180] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH v3 4/5] compress/zlib: support burst enqueue/dequeue X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 23 Jul 2018 12:36:40 -0000 > -----Original Message----- > From: Shally Verma [mailto:shally.verma@caviumnetworks.com] > Sent: Saturday, July 21, 2018 7:18 PM > To: De Lara Guarch, Pablo > Cc: dev@dpdk.org; pathreya@caviumnetworks.com; > mchalla@caviumnetworks.com; ashish.gupta@caviumnetworks.com; > sunila.sahu@caviumnetworks.com; Sunila Sahu > Subject: [PATCH v3 4/5] compress/zlib: support burst enqueue/dequeue >=20 > From: Sunila Sahu >=20 > Signed-off-by: Sunila Sahu > Signed-off-by: Shally Verma > Signed-off-by: Ashish Gupta > --- > drivers/compress/zlib/zlib_pmd.c | 254 ... > +def_end: > + /* Update op stats */ > + switch (op->status) { > + case RTE_COMP_OP_STATUS_SUCCESS: > + op->consumed +=3D strm->total_in; Compilation issue here: drivers/compress/zlib/zlib_pmd.c:94:16: error: this statement may fall thro= ugh [-Werror=3Dimplicit-fallthrough=3D] op->consumed +=3D strm->total_in; ~~~~~~~~~~~~~^~~~~~~~~~~~~~~~~ I think you are missing a "/* Fall-through */" comment here. Thanks, Pablo > + case RTE_COMP_OP_STATUS_OUT_OF_SPACE_TERMINATED: > + op->produced +=3D strm->total_out; > + break;