From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga02.intel.com (mga02.intel.com [134.134.136.20]) by dpdk.org (Postfix) with ESMTP id B8E9B235 for ; Mon, 23 Jul 2018 23:58:38 +0200 (CEST) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga006.jf.intel.com ([10.7.209.51]) by orsmga101.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 23 Jul 2018 14:58:37 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.51,394,1526367600"; d="scan'208";a="60055369" Received: from irsmsx105.ger.corp.intel.com ([163.33.3.28]) by orsmga006.jf.intel.com with ESMTP; 23 Jul 2018 14:58:36 -0700 Received: from irsmsx107.ger.corp.intel.com ([169.254.10.193]) by irsmsx105.ger.corp.intel.com ([169.254.7.195]) with mapi id 14.03.0319.002; Mon, 23 Jul 2018 22:58:35 +0100 From: "De Lara Guarch, Pablo" To: Shally Verma CC: "dev@dpdk.org" , "pathreya@caviumnetworks.com" , "mchalla@caviumnetworks.com" , Ashish Gupta , Sunila Sahu Thread-Topic: [PATCH v4 1/5] compress/zlib: add ZLIB PMD Thread-Index: AQHUIpS40udXcyYv9EGg/U+hs4AEtKSdWrQA Date: Mon, 23 Jul 2018 21:58:34 +0000 Message-ID: References: <1532357474-9544-1-git-send-email-shally.verma@caviumnetworks.com> <1532357474-9544-2-git-send-email-shally.verma@caviumnetworks.com> In-Reply-To: <1532357474-9544-2-git-send-email-shally.verma@caviumnetworks.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiYWQ2NTRkNzgtMjk2My00ZGJlLWJkODQtYWFhNzY5MjUzMjY5IiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX05UIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE3LjEwLjE4MDQuNDkiLCJUcnVzdGVkTGFiZWxIYXNoIjoiZ1FWbnZIMDVzSEJ1TzhFOGxIYVlwamtPVVZ3QnpjSXZETXFxSnE3cVhrZHRyS0c3Um5qNzhnY0xSTlwvYmY1eG4ifQ== x-ctpclassification: CTP_NT dlp-product: dlpe-windows dlp-version: 11.0.200.100 dlp-reaction: no-action x-originating-ip: [163.33.239.181] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH v4 1/5] compress/zlib: add ZLIB PMD X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 23 Jul 2018 21:58:40 -0000 > -----Original Message----- > From: Shally Verma [mailto:shally.verma@caviumnetworks.com] > Sent: Monday, July 23, 2018 3:51 PM > To: De Lara Guarch, Pablo > Cc: dev@dpdk.org; pathreya@caviumnetworks.com; > mchalla@caviumnetworks.com; Ashish Gupta > ; Sunila Sahu > > Subject: [PATCH v4 1/5] compress/zlib: add ZLIB PMD >=20 > From: Ashish Gupta >=20 > Add initial PMD setup routines in compressdev framework. ZLIB PMD appears= as > virtual compression device. User would need to install zlib prior to enab= ling this > PMD. >=20 > Signed-off-by: Sunila Sahu > Signed-off-by: Shally Verma > Signed-off-by: Ashish Gupta ... > +++ b/drivers/compress/zlib/zlib_pmd.c ... > +static int > +zlib_probe(struct rte_vdev_device *vdev) { > + struct rte_compressdev_pmd_init_params init_params =3D { > + "", > + rte_socket_id() > + }; > + const char *name; > + const char *input_args; > + > + name =3D rte_vdev_device_name(vdev); > + > + if (name =3D=3D NULL) > + return -EINVAL; > + input_args =3D rte_vdev_device_args(vdev); > + rte_compressdev_pmd_parse_input_args(&init_params, input_args); Need to check the return value of this function.