DPDK patches and discussions
 help / color / mirror / Atom feed
From: "De Lara Guarch, Pablo" <pablo.de.lara.guarch@intel.com>
To: "Daly, Lee" <lee.daly@intel.com>,
	"akhil.goyal@nxp.com" <akhil.goyal@nxp.com>
Cc: "dev@dpdk.org" <dev@dpdk.org>,
	"Varghese, Vipin" <vipin.varghese@intel.com>,
	"Daly, Lee" <lee.daly@intel.com>
Subject: Re: [dpdk-dev] [PATCH v6 1/2] test/compress: add checksum tests
Date: Tue, 8 Jan 2019 14:58:39 +0000	[thread overview]
Message-ID: <E115CCD9D858EF4F90C690B0DCB4D8978036093E@irsmsx112.ger.corp.intel.com> (raw)
In-Reply-To: <1546943360-48851-1-git-send-email-lee.daly@intel.com>

Hi Lee,

> -----Original Message-----
> From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Lee Daly
> Sent: Tuesday, January 8, 2019 10:29 AM
> To: akhil.goyal@nxp.com
> Cc: dev@dpdk.org; Varghese, Vipin <vipin.varghese@intel.com>; Daly, Lee
> <lee.daly@intel.com>
> Subject: [dpdk-dev] [PATCH v6 1/2] test/compress: add checksum tests


> +
> +	struct rte_comp_xform *compress_xform =
> +			rte_malloc(NULL, sizeof(struct rte_comp_xform), 0);
> +	if (compress_xform == NULL) {
> +		RTE_LOG(ERR, USER1, "Compress xform could not be
> created\n");

test/test/test_compressdev.c:1531:6: error: variable 'decompress_xform' is used uninitialized whenever 'if' condition is true
      [-Werror,-Wsometimes-uninitialized]
        if (compress_xform == NULL) {
            ^~~~~~~~~~~~~~~~~~~~~~
test/test/test_compressdev.c:1661:11: note: uninitialized use occurs here
        rte_free(decompress_xform);
                 ^~~~~~~~~~~~~~~~

There are clang compilation issues iwith this patch.
Could you fix them?

Thanks,
Pablo

  parent reply	other threads:[~2019-01-08 14:58 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <11544697752-156863-1-git-send-email-lee.daly@intel.com>
2018-12-14  9:59 ` [dpdk-dev] [PATCH v4 1/3] compress/isal: enable checksum support in driver Lee Daly
2018-12-14  9:59   ` [dpdk-dev] [PATCH v4 2/3] test/compress: add checksum tests Lee Daly
2018-12-14  9:59   ` [dpdk-dev] [PATCH v4 3/3] doc: update ISA-L guide to reflect checksum support Lee Daly
2018-12-17  8:19   ` [dpdk-dev] [PATCH v4 1/3] compress/isal: enable checksum support in driver Varghese, Vipin
2018-12-17  9:20     ` Daly, Lee
2018-12-17 12:33       ` Varghese, Vipin
2018-12-19 15:48   ` [dpdk-dev] [PATCH v5 " Lee Daly
2018-12-19 15:48     ` [dpdk-dev] [PATCH v5 2/3] test/compress: add checksum tests Lee Daly
2018-12-19 15:48     ` [dpdk-dev] [PATCH v5 3/3] doc: update ISA-L guide to reflect checksum support Lee Daly
2019-01-08 10:29     ` [dpdk-dev] [PATCH v6 1/2] test/compress: add checksum tests Lee Daly
2019-01-08 10:29       ` [dpdk-dev] [PATCH v6 2/2] compress/isal: enable checksum support in driver Lee Daly
2019-01-08 14:58       ` De Lara Guarch, Pablo [this message]
2019-01-08 16:20       ` [dpdk-dev] [PATCH v7 1/2] test/compress: add checksum tests Lee Daly
2019-01-08 16:20         ` [dpdk-dev] [PATCH v7 2/2] compress/isal: enable checksum support in driver Lee Daly
2019-01-08 17:19         ` [dpdk-dev] [PATCH v7 1/2] test/compress: add checksum tests De Lara Guarch, Pablo

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=E115CCD9D858EF4F90C690B0DCB4D8978036093E@irsmsx112.ger.corp.intel.com \
    --to=pablo.de.lara.guarch@intel.com \
    --cc=akhil.goyal@nxp.com \
    --cc=dev@dpdk.org \
    --cc=lee.daly@intel.com \
    --cc=vipin.varghese@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).