From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga03.intel.com (mga03.intel.com [134.134.136.65]) by dpdk.org (Postfix) with ESMTP id EEC811B185 for ; Wed, 9 Jan 2019 00:20:40 +0100 (CET) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga002.fm.intel.com ([10.253.24.26]) by orsmga103.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 08 Jan 2019 15:20:39 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.56,455,1539673200"; d="scan'208";a="132828208" Received: from irsmsx153.ger.corp.intel.com ([163.33.192.75]) by fmsmga002.fm.intel.com with ESMTP; 08 Jan 2019 15:20:38 -0800 Received: from irsmsx112.ger.corp.intel.com ([169.254.1.84]) by IRSMSX153.ger.corp.intel.com ([169.254.9.115]) with mapi id 14.03.0415.000; Tue, 8 Jan 2019 23:20:37 +0000 From: "De Lara Guarch, Pablo" To: "Zhang, Roy Fan" , "dev@dpdk.org" CC: "akhil.goyal@nxp.com" , "Trahe, Fiona" Thread-Topic: [PATCH v3 1/2] cryptodev: change queue pair configure structure Thread-Index: AQHUmTTp57wMXOht0Uuq0541T7LkxqWmGCHw Date: Tue, 8 Jan 2019 23:20:37 +0000 Message-ID: References: <20181211103402.81914-1-roy.fan.zhang@intel.com> <20181221135550.80745-1-roy.fan.zhang@intel.com> <20181221135550.80745-2-roy.fan.zhang@intel.com> In-Reply-To: <20181221135550.80745-2-roy.fan.zhang@intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiMDA4ODJkZTktNTNiYS00NGVhLWI5NzctZjIyNTE4Yzc1ODM0IiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX05UIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE3LjEwLjE4MDQuNDkiLCJUcnVzdGVkTGFiZWxIYXNoIjoibXF1MENWYTEzaDVmZjIrRFptZEhyQk01MHU2ZWNTMlh6aUl0N0lGVkhjdmlcL2RiK0ZTdXZtbnplKzVtOE1rSUsifQ== x-ctpclassification: CTP_NT dlp-product: dlpe-windows dlp-version: 11.0.400.15 dlp-reaction: no-action x-originating-ip: [163.33.239.181] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH v3 1/2] cryptodev: change queue pair configure structure X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 08 Jan 2019 23:20:41 -0000 > -----Original Message----- > From: Zhang, Roy Fan > Sent: Friday, December 21, 2018 1:56 PM > To: dev@dpdk.org > Cc: akhil.goyal@nxp.com; De Lara Guarch, Pablo > ; Trahe, Fiona > Subject: [PATCH v3 1/2] cryptodev: change queue pair configure structure >=20 > This patch changes the cryptodev queue pair configure structure > to enable two mempool passed into cryptodev PMD simutaneously. >=20 > Signed-off-by: Fan Zhang > Acked-by: Fiona Trahe ... > diff --git a/doc/guides/rel_notes/release_19_02.rst > b/doc/guides/rel_notes/release_19_02.rst > index 47768288a..4420c2441 100644 > --- a/doc/guides/rel_notes/release_19_02.rst > +++ b/doc/guides/rel_notes/release_19_02.rst > @@ -130,6 +130,11 @@ API Changes > ``rte_pdump_init()`` and enum ``rte_pdump_socktype`` were deprecated > since 18.05 and are removed in this release. >=20 > +* cryptodev: as shown in the the 18.08 deprecation notice, the structure Typo. "the 18.11" deprecation notice. > + ``rte_cryptodev_qp_conf`` has been added two parameters of symmetric > session > + mempool and symmetric session private data mempool, and the last > parameter of > + ``rte_cryptodev_queue_pair_setup()`` is removed. > + >=20 > ABI Changes > ----------- I think we need to bump the ABI version of cryptodev due to this, in releas= e notes. Also, the deprecation notice added for this change, should be removed in th= is patch. > diff --git a/drivers/crypto/aesni_gcm/aesni_gcm_pmd.c > b/drivers/crypto/aesni_gcm/aesni_gcm_pmd.c > index ebdf7c35a..abc7a6d5f 100644 ... > --- a/examples/fips_validation/main.c > +++ b/examples/fips_validation/main.c > @@ -39,7 +39,7 @@ static int > cryptodev_fips_validate_app_int(void) > { > struct rte_cryptodev_config conf =3D {rte_socket_id(), 1}; > - struct rte_cryptodev_qp_conf qp_conf =3D {128}; > + struct rte_cryptodev_qp_conf qp_conf =3D {128, NULL, NULL}; Is this OK? Below, it looks like a mempool was passes (env.mpool), but now = it is NULL here. > int ret; >=20 > ret =3D rte_cryptodev_configure(env.dev_id, &conf); > @@ -52,7 +52,7 @@ cryptodev_fips_validate_app_int(void) > return ret; >=20 > ret =3D rte_cryptodev_queue_pair_setup(env.dev_id, 0, &qp_conf, > - rte_socket_id(), env.mpool); > + rte_socket_id()); > if (ret < 0) > return ret; >=20