From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga14.intel.com (mga14.intel.com [192.55.52.115]) by dpdk.org (Postfix) with ESMTP id B10BA1B43B for ; Wed, 9 Jan 2019 12:01:10 +0100 (CET) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga006.fm.intel.com ([10.253.24.20]) by fmsmga103.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 09 Jan 2019 03:01:09 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.56,457,1539673200"; d="scan'208";a="308862999" Received: from irsmsx154.ger.corp.intel.com ([163.33.192.96]) by fmsmga006.fm.intel.com with ESMTP; 09 Jan 2019 03:01:08 -0800 Received: from irsmsx112.ger.corp.intel.com ([169.254.1.84]) by IRSMSX154.ger.corp.intel.com ([169.254.12.253]) with mapi id 14.03.0415.000; Wed, 9 Jan 2019 11:01:08 +0000 From: "De Lara Guarch, Pablo" To: "Zhang, Roy Fan" , "dev@dpdk.org" CC: "akhil.goyal@nxp.com" , "Trahe, Fiona" Thread-Topic: [PATCH v3 2/2] cryptodev: change symmetric session structure Thread-Index: AQHUmTTzgBzcfJ7320uKZycfJjUP4KWmH16w Date: Wed, 9 Jan 2019 11:01:07 +0000 Message-ID: References: <20181211103402.81914-1-roy.fan.zhang@intel.com> <20181221135550.80745-1-roy.fan.zhang@intel.com> <20181221135550.80745-3-roy.fan.zhang@intel.com> In-Reply-To: <20181221135550.80745-3-roy.fan.zhang@intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiMzUyZGYzY2EtYWY4Ni00YjBhLWE1OGItODVjM2ZkYjNiNTEwIiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX05UIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE3LjEwLjE4MDQuNDkiLCJUcnVzdGVkTGFiZWxIYXNoIjoiYWhXbDZrdnNiV1o1KzRzTGV3VThSTFpaTTNCZlh1eDMweFEybFFac3k0VWdOQVIxWVBBOVQ4ZldVWUk0ZTRMTSJ9 x-ctpclassification: CTP_NT dlp-product: dlpe-windows dlp-version: 11.0.400.15 dlp-reaction: no-action x-originating-ip: [163.33.239.182] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH v3 2/2] cryptodev: change symmetric session structure X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 09 Jan 2019 11:01:11 -0000 Hi Fan, > -----Original Message----- > From: Zhang, Roy Fan > Sent: Friday, December 21, 2018 1:56 PM > To: dev@dpdk.org > Cc: akhil.goyal@nxp.com; De Lara Guarch, Pablo > ; Trahe, Fiona > Subject: [PATCH v3 2/2] cryptodev: change symmetric session structure >=20 > This patch changes the symmetric session structure of cryptodev. > The symmetric session now contains extra information for secure > access purposes. The patch also includes the updates to the > PMDs, test applications, and examples to fit the change. >=20 Programmer's guide needs to be updated to reflect these changes. > Signed-off-by: Fan Zhang ... > diff --git a/lib/librte_cryptodev/Makefile b/lib/librte_cryptodev/Makefil= e > index a8f94c097..ade108b90 100644 > --- a/lib/librte_cryptodev/Makefile > +++ b/lib/librte_cryptodev/Makefile > @@ -12,6 +12,7 @@ LIBABIVER :=3D 5 This needs to be bumped to 6 (here and in meson.build), probably in the previous patch. > # build flags > CFLAGS +=3D -O3 > CFLAGS +=3D $(WERROR_FLAGS) > +CFLAGS +=3D -DALLOW_EXPERIMENTAL_API > LDLIBS +=3D -lrte_eal -lrte_mempool -lrte_ring -lrte_mbuf > LDLIBS +=3D -lrte_kvargs >=20 ... > +++ b/lib/librte_cryptodev/rte_cryptodev.c ... > +struct rte_mempool *__rte_experimental > +rte_cryptodev_sym_session_pool_create(const char *name, uint32_t > nb_elts, > + uint32_t elt_size, uint32_t cache_size, uint16_t user_data_size, > + int socket_id) Is elt_size a required parameter? This mempool is created specifically for = crypto sessions, so the size of it is known and can be transparent to the user (plus, I see = that in all apps, this is always 0). > + CDEV_LOG_INFO("elt_size %u is expanded to %u\n", elt_size, > + obj_sz); ... > +++ b/lib/librte_cryptodev/rte_cryptodev_version.map > @@ -105,4 +105,6 @@ EXPERIMENTAL { > rte_cryptodev_sym_session_set_user_data; > rte_crypto_asym_op_strings; > rte_crypto_asym_xform_strings; > + rte_cryptodev_sym_session_pool_create; > + rte_cryptodev_sym_get_existing_header_session_size; As far as I know, this new API is mandatory to be used, and therefore, I think this should not be marked as experimental, as the crypto library is a stable library.