From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga01.intel.com (mga01.intel.com [192.55.52.88]) by dpdk.org (Postfix) with ESMTP id 159B21B585 for ; Wed, 9 Jan 2019 18:02:59 +0100 (CET) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga006.jf.intel.com ([10.7.209.51]) by fmsmga101.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 09 Jan 2019 09:02:59 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.56,458,1539673200"; d="scan'208";a="106941010" Received: from irsmsx109.ger.corp.intel.com ([163.33.3.23]) by orsmga006.jf.intel.com with ESMTP; 09 Jan 2019 09:02:57 -0800 Received: from irsmsx156.ger.corp.intel.com (10.108.20.68) by IRSMSX109.ger.corp.intel.com (163.33.3.23) with Microsoft SMTP Server (TLS) id 14.3.408.0; Wed, 9 Jan 2019 17:02:57 +0000 Received: from irsmsx112.ger.corp.intel.com ([169.254.1.84]) by IRSMSX156.ger.corp.intel.com ([169.254.3.156]) with mapi id 14.03.0415.000; Wed, 9 Jan 2019 17:02:57 +0000 From: "De Lara Guarch, Pablo" To: "Kovacevic, Marko" , "dev@dpdk.org" CC: "akhil.goyal@nxp.com" , "Daly, Lee" , "Jozwiak, TomaszX" , "O'Hare, Cathal" , "Trahe, Fiona" , "Kovacevic, Marko" Thread-Topic: [dpdk-dev] [PATCH v2 2/2] test/compress: add varied buffer input/outputs Thread-Index: AQHUmHSS5yVOpXSj/E+TTAfuz24ulqWnNvGg Date: Wed, 9 Jan 2019 17:02:56 +0000 Message-ID: References: <20181214153326.17356-1-marko.kovacevic@intel.com> <20181220145824.37223-1-marko.kovacevic@intel.com> <20181220145824.37223-2-marko.kovacevic@intel.com> In-Reply-To: <20181220145824.37223-2-marko.kovacevic@intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiZWIwMWM5ZjAtY2ZiZS00Zjk4LTgwZmMtYWE0NmQxOGQzNDVjIiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX05UIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE3LjEwLjE4MDQuNDkiLCJUcnVzdGVkTGFiZWxIYXNoIjoiMVlWRVZSVmFDa0Q2WXlYb01lQTc3bnNTbEZKeEMwaVhROWc4b3oxQm5jUHZvZGROc2JUODZiejRpZjFWTmlPVSJ9 x-ctpclassification: CTP_NT dlp-product: dlpe-windows dlp-version: 11.0.400.15 dlp-reaction: no-action x-originating-ip: [163.33.239.182] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH v2 2/2] test/compress: add varied buffer input/outputs X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 09 Jan 2019 17:03:00 -0000 > -----Original Message----- > From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Marko Kovacevic > Sent: Thursday, December 20, 2018 2:58 PM > To: dev@dpdk.org > Cc: akhil.goyal@nxp.com; Daly, Lee ; Jozwiak, TomaszX > ; O'Hare, Cathal ; > Trahe, Fiona ; Kovacevic, Marko > > Subject: [dpdk-dev] [PATCH v2 2/2] test/compress: add varied buffer > input/outputs >=20 > Added unit test to check if a SGL buffer was added as an input and a Line= ar > Buffer as output and vice versa so we can test if the application would > process the different buffers properly. >=20 > Signed-off-by: Marko Kovacevic > Acked-by: Lee Daly > --- > test/test/test_compressdev.c | 173 ++++++++++++++++++++++++++++++++--- > -------- > 1 file changed, 130 insertions(+), 43 deletions(-) >=20 > diff --git a/test/test/test_compressdev.c b/test/test/test_compressdev.c > index b2999fa..5d62206 100644 > --- a/test/test/test_compressdev.c > +++ b/test/test/test_compressdev.c > @@ -71,6 +71,13 @@ struct comp_testsuite_params { > struct rte_comp_xform *def_decomp_xform; }; >=20 > +enum varied_buff { > + LB_BOTH =3D 0, /* both input and output are linear*/ > + SGL_BOTH, /* both input and output are chained */ > + SGL_TO_LB, /* input buffer is chained */ > + LB_TO_SGL /* output buffer is chained */ > Great idea to have this enum. It really makes the tests more readable :) >=20 > +static int > +test_compressdev_deflate_stateless_varied_buf(void) > +{ I think, since these new tests could be integrated in the SGL test, extendi= ng the existing ones, as so far they were only testing SGL in SGL out and this is extending to ot= her combinations. This way, we don't add another test unnecessarily. Thanks, Pablo