From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga03.intel.com (mga03.intel.com [134.134.136.65]) by dpdk.org (Postfix) with ESMTP id C40801B4D1 for ; Wed, 9 Jan 2019 23:32:30 +0100 (CET) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga003.fm.intel.com ([10.253.24.29]) by orsmga103.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 09 Jan 2019 14:32:29 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.56,459,1539673200"; d="scan'208";a="124699122" Received: from irsmsx102.ger.corp.intel.com ([163.33.3.155]) by FMSMGA003.fm.intel.com with ESMTP; 09 Jan 2019 14:32:28 -0800 Received: from irsmsx112.ger.corp.intel.com ([169.254.1.84]) by IRSMSX102.ger.corp.intel.com ([169.254.2.65]) with mapi id 14.03.0415.000; Wed, 9 Jan 2019 22:32:28 +0000 From: "De Lara Guarch, Pablo" To: "Trahe, Fiona" , "Zhang, Roy Fan" , "dev@dpdk.org" CC: "akhil.goyal@nxp.com" , "Nowak, DamianX" , "Krakowiak, LukaszX" Thread-Topic: [dpdk-dev] [PATCH v4] crypto/aesni_mb: support plain SHA Thread-Index: AQHUmF60B+zwqOVx7Ue56zkDZM259KWH6MCAgB+4QfA= Date: Wed, 9 Jan 2019 22:32:27 +0000 Message-ID: References: <20181219232416.38542-1-roy.fan.zhang@intel.com> <20181220122215.38943-1-roy.fan.zhang@intel.com> <348A99DA5F5B7549AA880327E580B435896A80A4@IRSMSX101.ger.corp.intel.com> In-Reply-To: <348A99DA5F5B7549AA880327E580B435896A80A4@IRSMSX101.ger.corp.intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiZTA1ZTM0ZjAtOTU5My00YmZmLThkYzgtNTdlNjU5ZDgzNDM5IiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX05UIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE3LjEwLjE4MDQuNDkiLCJUcnVzdGVkTGFiZWxIYXNoIjoidVNvTzVMOEpJQjVTVGJTYTZ3eFRkK0VQVjNDRUhZT3NHM3kwZkxxeGFDYlloYmlKazVGRWJzbU5maFZFRlAyMSJ9 x-ctpclassification: CTP_NT dlp-product: dlpe-windows dlp-version: 11.0.400.15 dlp-reaction: no-action x-originating-ip: [163.33.239.181] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH v4] crypto/aesni_mb: support plain SHA X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 09 Jan 2019 22:32:31 -0000 > -----Original Message----- > From: Trahe, Fiona > Sent: Thursday, December 20, 2018 5:52 PM > To: Zhang, Roy Fan ; dev@dpdk.org > Cc: akhil.goyal@nxp.com; De Lara Guarch, Pablo > ; Nowak, DamianX > ; Krakowiak, LukaszX > ; Trahe, Fiona > Subject: RE: [dpdk-dev] [PATCH v4] crypto/aesni_mb: support plain SHA >=20 > Hi Fan, >=20 > > -----Original Message----- > > From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Fan Zhang > > Sent: Thursday, December 20, 2018 5:22 AM > > To: dev@dpdk.org > > Cc: akhil.goyal@nxp.com; De Lara Guarch, Pablo > > ; Nowak, DamianX > > ; Krakowiak, LukaszX > > > > Subject: [dpdk-dev] [PATCH v4] crypto/aesni_mb: support plain SHA > > > > This patch adds the plain SHA1, SHA224, SHA256, SHA384, and SHA512 > > algorithms support to AESNI-MB PMD. The cryptodev unit test and > > documentation are updated accordingly. > > > > This patch depends on "[v6] crypto/aesni_mb: support AES-GMAC" > > (http://patchwork.dpdk.org/patch/49180/) > > > > Signed-off-by: Damian Nowak > > Signed-off-by: Lukasz Krakowiak > > Signed-off-by: Fan Zhang > > --- >=20 >=20 > //snip// >=20 > > @@ -428,7 +433,12 @@ static const struct blockcipher_test_case > hash_test_cases[] =3D { > > .pmd_mask =3D BLOCKCIPHER_TEST_TARGET_PMD_OPENSSL | > > BLOCKCIPHER_TEST_TARGET_PMD_CCP | > > BLOCKCIPHER_TEST_TARGET_PMD_MVSAM | > > +#if IMB_VERSION(0, 52, 0) > IMB_VERSION_NUM > > BLOCKCIPHER_TEST_TARGET_PMD_OCTEONTX > > +#else > > + BLOCKCIPHER_TEST_TARGET_PMD_OCTEONTX | > > + BLOCKCIPHER_TEST_TARGET_PMD_MB #endif > [Fiona] Only a nit, but it's messy to include OCTEONTX in this. > MB doesn't have to be added after the other flags, it would be more > readable and easier for other PMD flags to be added in future if it was p= ut > on the previous line, e.g. > > BLOCKCIPHER_TEST_TARGET_PMD_MVSAM | > > +#if IMB_VERSION_NUM >=3D IMB_VERSION(0, 52, 0) > > + BLOCKCIPHER_TEST_TARGET_PMD_MB | #endif > > BLOCKCIPHER_TEST_TARGET_PMD_OCTEONTX >=20 > Apart from that > Acked-by: Fiona Trahe Agree with Fiona's comment. Fan, are you ok with it? I can make the change for you and push it to the t= ree. Pablo