[dpdk-dev] [PATCH] common/qat: revert fix for invalid response from firmware

[dpdk-dev] [PATCH] common/qat: revert fix for invalid response from firmware

[Tomasz Jozwiak]

This reverts commit d09973f6c4df ("common/qat: fix for invalid
response from firmware") due to incorrectly reporting failures
on some older firmware versions.

Fixes: d09973f6c4df ("common/qat: fix for invalid response from firmware")
Cc: stable@dpdk.org

Signed-off-by: Tomasz Jozwiak <tomaszx.jozwiak@intel.com>
---
 drivers/common/qat/qat_qp.c | 8 --------
 1 file changed, 8 deletions(-)

diff --git a/drivers/common/qat/qat_qp.c b/drivers/common/qat/qat_qp.c
index 79f6a01..ec7f2b3 100644
--- a/drivers/common/qat/qat_qp.c
+++ b/drivers/common/qat/qat_qp.c
@@ -634,23 +634,15 @@ qat_dequeue_op_burst(void *qp, void **ops, uint16_t nb_ops)
 	uint32_t head;
 	uint32_t resp_counter = 0;
 	uint8_t *resp_msg;
-	uint8_t hdr_flags;
 
 	rx_queue = &(tmp_qp->rx_q);
 	tx_queue = &(tmp_qp->tx_q);
 	head = rx_queue->head;
 	resp_msg = (uint8_t *)rx_queue->base_addr + rx_queue->head;
-	hdr_flags = ((struct icp_qat_fw_comn_resp_hdr *)resp_msg)->hdr_flags;
 
 	while (*(uint32_t *)resp_msg != ADF_RING_EMPTY_SIG &&
 			resp_counter != nb_ops) {
 
-		if (unlikely(!ICP_QAT_FW_COMN_VALID_FLAG_GET(hdr_flags))) {
-			/* Fatal firmware error */
-			QAT_LOG(ERR, "QAT Firmware returned invalid response");
-			return 0;
-		}
-
 		if (tmp_qp->service_type == QAT_SERVICE_SYMMETRIC)
 			qat_sym_process_response(ops, resp_msg);
 		else if (tmp_qp->service_type == QAT_SERVICE_COMPRESSION)
-- 
2.7.4

[dpdk-dev] [PATCH] compress/qat: fix status return on error building request

[Tomasz Jozwiak]

This patch fixes error status which should be set inside
qat_comp_build_request function in case any errors are detected.
In these cases op.status is set to
RTE_COMP_OP_STATUS_INVALID_ARGS to help application debug.

Fixes: 1947bd18580b ("compress/qat: support scatter-gather buffers")
Cc: stable@dpdk.org

Signed-off-by: Tomasz Jozwiak <tomaszx.jozwiak@intel.com>
---
 drivers/compress/qat/qat_comp.c | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/drivers/compress/qat/qat_comp.c b/drivers/compress/qat/qat_comp.c
index 2754742..8a6fad0 100644
--- a/drivers/compress/qat/qat_comp.c
+++ b/drivers/compress/qat/qat_comp.c
@@ -36,6 +36,7 @@ qat_comp_build_request(void *in_op, uint8_t *out_msg,
 		QAT_DP_LOG(ERR, "QAT PMD only supports stateless compression "
 				"operation requests, op (%p) is not a "
 				"stateless operation.", op);
+		op->status = RTE_COMP_OP_STATUS_INVALID_ARGS;
 		return -EINVAL;
 	}
 
@@ -61,6 +62,7 @@ qat_comp_build_request(void *in_op, uint8_t *out_msg,
 				RTE_PMD_QAT_COMP_SGL_MAX_SEGMENTS);
 		if (ret) {
 			QAT_DP_LOG(ERR, "QAT PMD Cannot fill source sgl array");
+			op->status = RTE_COMP_OP_STATUS_INVALID_ARGS;
 			return ret;
 		}
 
@@ -71,6 +73,7 @@ qat_comp_build_request(void *in_op, uint8_t *out_msg,
 				RTE_PMD_QAT_COMP_SGL_MAX_SEGMENTS);
 		if (ret) {
 			QAT_DP_LOG(ERR, "QAT PMD Cannot fill dest. sgl array");
+			op->status = RTE_COMP_OP_STATUS_INVALID_ARGS;
 			return ret;
 		}
 
-- 
2.7.4

Re: [dpdk-dev] [PATCH] common/qat: revert fix for invalid response from firmware

[Trahe, Fiona]

> -----Original Message-----
> From: Jozwiak, TomaszX
> Sent: Friday, December 14, 2018 4:20 AM
> To: dev@dpdk.org; Trahe, Fiona <fiona.trahe@intel.com>; Jozwiak, TomaszX
> <tomaszx.jozwiak@intel.com>; akhil.goyal@nxp.com; stable@dpdk.org
> Subject: [PATCH] common/qat: revert fix for invalid response from firmware
> 
> This reverts commit d09973f6c4df ("common/qat: fix for invalid
> response from firmware") due to incorrectly reporting failures
> on some older firmware versions.
> 
> Fixes: d09973f6c4df ("common/qat: fix for invalid response from firmware")
> Cc: stable@dpdk.org
> 
> Signed-off-by: Tomasz Jozwiak <tomaszx.jozwiak@intel.com>
Acked-by: Fiona Trahe <fiona.trahe@intel.com>

Re: [dpdk-dev] [PATCH] compress/qat: fix status return on error building request

[Trahe, Fiona]

> -----Original Message-----
> From: Jozwiak, TomaszX
> Sent: Friday, December 14, 2018 4:20 AM
> To: dev@dpdk.org; Trahe, Fiona <fiona.trahe@intel.com>; Jozwiak, TomaszX
> <tomaszx.jozwiak@intel.com>; akhil.goyal@nxp.com; stable@dpdk.org
> Subject: [PATCH] compress/qat: fix status return on error building request
> 
> This patch fixes error status which should be set inside
> qat_comp_build_request function in case any errors are detected.
> In these cases op.status is set to
> RTE_COMP_OP_STATUS_INVALID_ARGS to help application debug.
> 
> Fixes: 1947bd18580b ("compress/qat: support scatter-gather buffers")
> Cc: stable@dpdk.org
> 
> Signed-off-by: Tomasz Jozwiak <tomaszx.jozwiak@intel.com>
Acked-by: Fiona Trahe <fiona.trahe@intel.com>

Re: [dpdk-dev] [PATCH] common/qat: revert fix for invalid response from firmware

[Akhil Goyal]

On 12/15/2018 12:17 AM, Trahe, Fiona wrote:
>> -----Original Message-----
>> From: Jozwiak, TomaszX
>> Sent: Friday, December 14, 2018 4:20 AM
>> To: dev@dpdk.org; Trahe, Fiona <fiona.trahe@intel.com>; Jozwiak, TomaszX
>> <tomaszx.jozwiak@intel.com>; akhil.goyal@nxp.com; stable@dpdk.org
>> Subject: [PATCH] common/qat: revert fix for invalid response from firmware
>>
>> This reverts commit d09973f6c4df ("common/qat: fix for invalid
>> response from firmware") due to incorrectly reporting failures
>> on some older firmware versions.
>>
>> Fixes: d09973f6c4df ("common/qat: fix for invalid response from firmware")
>> Cc: stable@dpdk.org
>>
>> Signed-off-by: Tomasz Jozwiak <tomaszx.jozwiak@intel.com>
> Acked-by: Fiona Trahe <fiona.trahe@intel.com>
>
Applied to dpdk-next-crypto

Thanks

Re: [dpdk-dev] [PATCH] compress/qat: fix status return on error building request

[Akhil Goyal]

On 12/15/2018 12:18 AM, Trahe, Fiona wrote:
>
>> -----Original Message-----
>> From: Jozwiak, TomaszX
>> Sent: Friday, December 14, 2018 4:20 AM
>> To: dev@dpdk.org; Trahe, Fiona <fiona.trahe@intel.com>; Jozwiak, TomaszX
>> <tomaszx.jozwiak@intel.com>; akhil.goyal@nxp.com; stable@dpdk.org
>> Subject: [PATCH] compress/qat: fix status return on error building request
>>
>> This patch fixes error status which should be set inside
>> qat_comp_build_request function in case any errors are detected.
>> In these cases op.status is set to
>> RTE_COMP_OP_STATUS_INVALID_ARGS to help application debug.
>>
>> Fixes: 1947bd18580b ("compress/qat: support scatter-gather buffers")
>> Cc: stable@dpdk.org
>>
>> Signed-off-by: Tomasz Jozwiak <tomaszx.jozwiak@intel.com>
> Acked-by: Fiona Trahe <fiona.trahe@intel.com>
Applied to dpdk-next-crypto

Thanks

Re: [dpdk-dev] [PATCH] compress/qat: fix status return on error building request

[De Lara Guarch, Pablo]

> -----Original Message-----
> From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Trahe, Fiona
> Sent: Friday, December 14, 2018 6:48 PM
> To: Jozwiak, TomaszX <tomaszx.jozwiak@intel.com>; dev@dpdk.org;
> akhil.goyal@nxp.com; stable@dpdk.org
> Subject: Re: [dpdk-dev] [PATCH] compress/qat: fix status return on error
> building request
> 
> 
> 
> > -----Original Message-----
> > From: Jozwiak, TomaszX
> > Sent: Friday, December 14, 2018 4:20 AM
> > To: dev@dpdk.org; Trahe, Fiona <fiona.trahe@intel.com>; Jozwiak,
> > TomaszX <tomaszx.jozwiak@intel.com>; akhil.goyal@nxp.com;
> > stable@dpdk.org
> > Subject: [PATCH] compress/qat: fix status return on error building
> > request
> >
> > This patch fixes error status which should be set inside
> > qat_comp_build_request function in case any errors are detected.
> > In these cases op.status is set to
> > RTE_COMP_OP_STATUS_INVALID_ARGS to help application debug.
> >
> > Fixes: 1947bd18580b ("compress/qat: support scatter-gather buffers")
> > Cc: stable@dpdk.org
> >
> > Signed-off-by: Tomasz Jozwiak <tomaszx.jozwiak@intel.com>
> Acked-by: Fiona Trahe <fiona.trahe@intel.com>

Applied to dpdk-next-crypto.

Thanks,
Pablo