Re: [dpdk-dev] [PATCH v4 01/12] cryptodev: change queue pair configure structure

["De Lara Guarch, Pablo" <pablo.de.lara.guarch@intel.com>]

Hi,

> -----Original Message-----
> From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of De Lara Guarch,
> Pablo
> Sent: Thursday, January 10, 2019 9:47 AM
> To: Zhang, Roy Fan <roy.fan.zhang@intel.com>; dev@dpdk.org
> Cc: akhil.goyal@nxp.com; Trahe, Fiona <fiona.trahe@intel.com>
> Subject: Re: [dpdk-dev] [PATCH v4 01/12] cryptodev: change queue pair
> configure structure
> 
> 
> 
> > -----Original Message-----
> > From: Zhang, Roy Fan
> > Sent: Wednesday, January 9, 2019 10:56 PM
> > To: dev@dpdk.org
> > Cc: akhil.goyal@nxp.com; De Lara Guarch, Pablo
> > <pablo.de.lara.guarch@intel.com>; Trahe, Fiona <fiona.trahe@intel.com>
> > Subject: [PATCH v4 01/12] cryptodev: change queue pair configure
> > structure
> >
> > This patch changes the cryptodev queue pair configure structure to
> > enable two mempool passed into cryptodev PMD simutaneously.
> >
> > Signed-off-by: Fan Zhang <roy.fan.zhang@intel.com>
> > Acked-by: Fiona Trahe <fiona.trahe@@intel.com>
> > ---
> 
> ...
> 
> > diff --git a/app/test-crypto-perf/main.c b/app/test-crypto-perf/main.c
> > index 953e058c9..38a2e429f 100644
> 
> ...
> 
> > +++ b/doc/guides/prog_guide/cryptodev_lib.rst
> 
> Could you also update the sample code which calls queue_pair_setup?
> 
> > +
> > +
> >  Logical Cores, Memory and Queues Pair Relationships
> > ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
> >
> > diff --git a/doc/guides/rel_notes/release_19_02.rst
> > b/doc/guides/rel_notes/release_19_02.rst
> > index e3b2055d0..75128f8f2 100644
> > --- a/doc/guides/rel_notes/release_19_02.rst
> > +++ b/doc/guides/rel_notes/release_19_02.rst
> > @@ -164,6 +164,9 @@ API Changes
> >    ``rte_pdump_init()`` and enum ``rte_pdump_socktype`` were deprecated
> >    since 18.05 and are removed in this release.
> >
> > +* cryptodev: as shown in the the 18.11 deprecation notice, the last
> > parameter
> > +  of ``rte_cryptodev_queue_pair_setup()``, ``session_pool``, is removed.
> > +
> 
> ABI versioning should be bumped in this document.
> 
> 
> >
> >  ABI Changes
> >  -----------
> > @@ -183,6 +186,10 @@ ABI Changes
> >  * mbuf: The format of the sched field of ``rte_mbuf`` has been changed
> >    to include the following fields: ``queue ID``, ``traffic class``, ``color``.
> >
> > +* cryptodev: as shown in the the 18.11 deprecation notice, the
> > +structure
> > +  ``rte_cryptodev_qp_conf`` has been added two parameters of
> > +symmetric
> > session
> > +  mempool and symmetric session private data mempool.
> > +
> >
> >  Shared Library Versions
> >  -----------------------
> > diff --git a/drivers/crypto/aesni_gcm/aesni_gcm_pmd.c
> > b/drivers/crypto/aesni_gcm/aesni_gcm_pmd.c
> > index ebdf7c35a..abc7a6d5f 100644
> 
> ...
> 
> > +++ b/lib/librte_cryptodev/Makefile
> > @@ -1,5 +1,5 @@
> >  # SPDX-License-Identifier: BSD-3-Clause -# Copyright(c) 2015 Intel
> > Corporation
> > +# Copyright(c) 2015-2018 Intel Corporation
> 
> Welcome to 2019 :D
> 
> >
> >  include $(RTE_SDK)/mk/rte.vars.mk
> >
> > @@ -7,7 +7,7 @@ include $(RTE_SDK)/mk/rte.vars.mk  LIB =
> > librte_cryptodev.a
> >
> >  # library version
> > -LIBABIVER := 5
> > +LIBABIVER := 6
> 
> Version should also be bumped in the meson.build file.
> 
> >
> >  # build flags
> >  CFLAGS += -O3

Forgot to say that the deprecation notice sent for the structure and
the API changed needs to be removed from deprecation.rst.

Apart from that:

Acked-by: Pablo de Lara <pablo.de.lara.guarch@intel.com>