From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga14.intel.com (mga14.intel.com [192.55.52.115]) by dpdk.org (Postfix) with ESMTP id 494151B615 for ; Thu, 10 Jan 2019 13:36:01 +0100 (CET) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga003.jf.intel.com ([10.7.209.27]) by fmsmga103.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 10 Jan 2019 04:36:01 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.56,461,1539673200"; d="scan'208";a="117045699" Received: from irsmsx152.ger.corp.intel.com ([163.33.192.66]) by orsmga003.jf.intel.com with ESMTP; 10 Jan 2019 04:36:00 -0800 Received: from irsmsx111.ger.corp.intel.com (10.108.20.4) by IRSMSX152.ger.corp.intel.com (163.33.192.66) with Microsoft SMTP Server (TLS) id 14.3.408.0; Thu, 10 Jan 2019 12:35:59 +0000 Received: from irsmsx112.ger.corp.intel.com ([169.254.1.84]) by irsmsx111.ger.corp.intel.com ([169.254.2.160]) with mapi id 14.03.0415.000; Thu, 10 Jan 2019 12:35:59 +0000 From: "De Lara Guarch, Pablo" To: "Zhang, Roy Fan" , "dev@dpdk.org" CC: "akhil.goyal@nxp.com" , "Trahe, Fiona" Thread-Topic: [PATCH v4 11/12] cryptodev: add reference count to session private data Thread-Index: AQHUqG6W1lMLMyK71k+ffP3NG2nhCaWocOcw Date: Thu, 10 Jan 2019 12:35:58 +0000 Message-ID: References: <20181221135550.80745-1-roy.fan.zhang@intel.com> <20190109225609.20590-1-roy.fan.zhang@intel.com> <20190109225609.20590-12-roy.fan.zhang@intel.com> In-Reply-To: <20190109225609.20590-12-roy.fan.zhang@intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiZTNkZjE0NTQtNGM0NC00ZGIxLThjM2UtNDE1NDNkYmEwMDliIiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX05UIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE3LjEwLjE4MDQuNDkiLCJUcnVzdGVkTGFiZWxIYXNoIjoiXC92bHNXZmlvejFOR256WW90UzRPXC9JcHdwMVpuZ0dwQzVjdHdJZ2VmdGFybE1lUms0cVZ2d3ZTUTBZZys4eUZZIn0= x-ctpclassification: CTP_NT dlp-product: dlpe-windows dlp-version: 11.0.400.15 dlp-reaction: no-action x-originating-ip: [163.33.239.180] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH v4 11/12] cryptodev: add reference count to session private data X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 10 Jan 2019 12:36:02 -0000 > -----Original Message----- > From: Zhang, Roy Fan > Sent: Wednesday, January 9, 2019 10:56 PM > To: dev@dpdk.org > Cc: akhil.goyal@nxp.com; De Lara Guarch, Pablo > ; Trahe, Fiona > Subject: [PATCH v4 11/12] cryptodev: add reference count to session priva= te > data >=20 > This patch adds a refcnt field to every session private data in the crypt= odev > symmetric session. The counter is used to prevent freeing symmetric sessi= on > blindly before it is not cleared by every type of crypto device in use. >=20 > Signed-off-by: Fan Zhang > Acked-by: Fiona Trahe > --- > doc/guides/prog_guide/img/cryptodev_sym_sess.svg | 7 +++++++ > doc/guides/rel_notes/release_19_02.rst | 6 ++++++ > lib/librte_cryptodev/rte_cryptodev.c | 14 +++++++++----- > lib/librte_cryptodev/rte_cryptodev.h | 1 + > 4 files changed, 23 insertions(+), 5 deletions(-) >=20 > diff --git a/doc/guides/prog_guide/img/cryptodev_sym_sess.svg > b/doc/guides/prog_guide/img/cryptodev_sym_sess.svg > index 20059cc0f..7d7052c38 100644 > --- a/doc/guides/prog_guide/img/cryptodev_sym_sess.svg I think it is worth mentioning in the programmer's guide that it is expecte= d for all devices to call sym_session_init, even if they are the same devic= e type (for safety reasons).