* [dpdk-dev] [PATCH] test/crypto: fix misleading trace message
@ 2018-12-21 0:01 Fiona Trahe
2018-12-21 11:41 ` De Lara Guarch, Pablo
2019-01-11 0:05 ` De Lara Guarch, Pablo
0 siblings, 2 replies; 4+ messages in thread
From: Fiona Trahe @ 2018-12-21 0:01 UTC (permalink / raw)
To: dev; +Cc: pablo.de.lara.guarch, fiona.trahe, roy.fan.zhang, akhil.goyal, stable
Test was reporting digest verification failed for all operation errors.
Fixed so it only reports this if the PMD actually reports an auth failure.
Fixes: 9c0eed2f06ae ("app/test: rework crypto AES unit test")
CC: stable@dpdk.org
Signed-off-by: Fiona Trahe <fiona.trahe@intel.com>
---
test/test/test_cryptodev_blockcipher.c | 5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)
diff --git a/test/test/test_cryptodev_blockcipher.c b/test/test/test_cryptodev_blockcipher.c
index 1c3f29f6b..4f1298ea2 100644
--- a/test/test/test_cryptodev_blockcipher.c
+++ b/test/test/test_cryptodev_blockcipher.c
@@ -401,13 +401,14 @@ test_blockcipher_one_case(const struct blockcipher_test_case *t,
/* Verify results */
if (op->status != RTE_CRYPTO_OP_STATUS_SUCCESS) {
- if (t->op_mask & BLOCKCIPHER_TEST_OP_AUTH_VERIFY)
+ if ((t->op_mask & BLOCKCIPHER_TEST_OP_AUTH_VERIFY) &&
+ (op->status == RTE_CRYPTO_OP_STATUS_AUTH_FAILED))
snprintf(test_msg, BLOCKCIPHER_TEST_MSG_LEN, "line %u "
"FAILED: Digest verification failed "
"(0x%X)", __LINE__, op->status);
else
snprintf(test_msg, BLOCKCIPHER_TEST_MSG_LEN, "line %u "
- "FAILED: Digest verification failed "
+ "FAILED: Operation failed "
"(0x%X)", __LINE__, op->status);
status = TEST_FAILED;
goto error_exit;
--
2.13.6
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [dpdk-dev] [PATCH] test/crypto: fix misleading trace message
2018-12-21 0:01 [dpdk-dev] [PATCH] test/crypto: fix misleading trace message Fiona Trahe
@ 2018-12-21 11:41 ` De Lara Guarch, Pablo
2019-01-09 22:45 ` De Lara Guarch, Pablo
2019-01-11 0:05 ` De Lara Guarch, Pablo
1 sibling, 1 reply; 4+ messages in thread
From: De Lara Guarch, Pablo @ 2018-12-21 11:41 UTC (permalink / raw)
To: Trahe, Fiona, dev; +Cc: Zhang, Roy Fan, akhil.goyal, stable
> -----Original Message-----
> From: Trahe, Fiona
> Sent: Friday, December 21, 2018 12:01 AM
> To: dev@dpdk.org
> Cc: De Lara Guarch, Pablo <pablo.de.lara.guarch@intel.com>; Trahe, Fiona
> <fiona.trahe@intel.com>; Zhang, Roy Fan <roy.fan.zhang@intel.com>;
> akhil.goyal@nxp.com; stable@dpdk.org
> Subject: [PATCH] test/crypto: fix misleading trace message
>
> Test was reporting digest verification failed for all operation errors.
> Fixed so it only reports this if the PMD actually reports an auth failure.
>
> Fixes: 9c0eed2f06ae ("app/test: rework crypto AES unit test")
> CC: stable@dpdk.org
>
> Signed-off-by: Fiona Trahe <fiona.trahe@intel.com>
Acked-by: Pablo de Lara <pablo.de.lara.guarch@intel.com>
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [dpdk-dev] [PATCH] test/crypto: fix misleading trace message
2018-12-21 11:41 ` De Lara Guarch, Pablo
@ 2019-01-09 22:45 ` De Lara Guarch, Pablo
0 siblings, 0 replies; 4+ messages in thread
From: De Lara Guarch, Pablo @ 2019-01-09 22:45 UTC (permalink / raw)
To: De Lara Guarch, Pablo, Trahe, Fiona, dev
Cc: Zhang, Roy Fan, akhil.goyal, stable
> -----Original Message-----
> From: stable [mailto:stable-bounces@dpdk.org] On Behalf Of De Lara
> Guarch, Pablo
> Sent: Friday, December 21, 2018 11:42 AM
> To: Trahe, Fiona <fiona.trahe@intel.com>; dev@dpdk.org
> Cc: Zhang, Roy Fan <roy.fan.zhang@intel.com>; akhil.goyal@nxp.com;
> stable@dpdk.org
> Subject: Re: [dpdk-stable] [PATCH] test/crypto: fix misleading trace message
>
>
>
> > -----Original Message-----
> > From: Trahe, Fiona
> > Sent: Friday, December 21, 2018 12:01 AM
> > To: dev@dpdk.org
> > Cc: De Lara Guarch, Pablo <pablo.de.lara.guarch@intel.com>; Trahe,
> > Fiona <fiona.trahe@intel.com>; Zhang, Roy Fan
> > <roy.fan.zhang@intel.com>; akhil.goyal@nxp.com; stable@dpdk.org
> > Subject: [PATCH] test/crypto: fix misleading trace message
> >
> > Test was reporting digest verification failed for all operation errors.
> > Fixed so it only reports this if the PMD actually reports an auth failure.
> >
> > Fixes: 9c0eed2f06ae ("app/test: rework crypto AES unit test")
> > CC: stable@dpdk.org
> >
> > Signed-off-by: Fiona Trahe <fiona.trahe@intel.com>
>
> Acked-by: Pablo de Lara <pablo.de.lara.guarch@intel.com>
Applied to dpdk-next-crypto.
Thanks,
Pablo
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [dpdk-dev] [PATCH] test/crypto: fix misleading trace message
2018-12-21 0:01 [dpdk-dev] [PATCH] test/crypto: fix misleading trace message Fiona Trahe
2018-12-21 11:41 ` De Lara Guarch, Pablo
@ 2019-01-11 0:05 ` De Lara Guarch, Pablo
1 sibling, 0 replies; 4+ messages in thread
From: De Lara Guarch, Pablo @ 2019-01-11 0:05 UTC (permalink / raw)
To: Trahe, Fiona, dev; +Cc: Zhang, Roy Fan, akhil.goyal, stable
> -----Original Message-----
> From: Trahe, Fiona
> Sent: Friday, December 21, 2018 12:01 AM
> To: dev@dpdk.org
> Cc: De Lara Guarch, Pablo <pablo.de.lara.guarch@intel.com>; Trahe, Fiona
> <fiona.trahe@intel.com>; Zhang, Roy Fan <roy.fan.zhang@intel.com>;
> akhil.goyal@nxp.com; stable@dpdk.org
> Subject: [PATCH] test/crypto: fix misleading trace message
>
> Test was reporting digest verification failed for all operation errors.
> Fixed so it only reports this if the PMD actually reports an auth failure.
>
> Fixes: 9c0eed2f06ae ("app/test: rework crypto AES unit test")
> CC: stable@dpdk.org
>
> Signed-off-by: Fiona Trahe <fiona.trahe@intel.com>
Applied to dpdk-next-crypto.
Thanks,
Pablo
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2019-01-11 0:05 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-12-21 0:01 [dpdk-dev] [PATCH] test/crypto: fix misleading trace message Fiona Trahe
2018-12-21 11:41 ` De Lara Guarch, Pablo
2019-01-09 22:45 ` De Lara Guarch, Pablo
2019-01-11 0:05 ` De Lara Guarch, Pablo
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).