* [dpdk-dev] [PATCH] test/crypto: don't attempt unsupported SGL tests on aesni mb PMD
@ 2018-12-21 0:02 Fiona Trahe
2018-12-21 11:52 ` De Lara Guarch, Pablo
2019-01-11 11:04 ` De Lara Guarch, Pablo
0 siblings, 2 replies; 5+ messages in thread
From: Fiona Trahe @ 2018-12-21 0:02 UTC (permalink / raw)
To: dev; +Cc: pablo.de.lara.guarch, fiona.trahe, roy.fan.zhang, akhil.goyal
Remove AESNI_MB flag from SGL test cases which it doesn't support.
Signed-off-by: Fiona Trahe <fiona.trahe@intel.com>
---
test/test/test_cryptodev_aes_test_vectors.h | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/test/test/test_cryptodev_aes_test_vectors.h b/test/test/test_cryptodev_aes_test_vectors.h
index fff28bc9b..6dd8e5f96 100644
--- a/test/test/test_cryptodev_aes_test_vectors.h
+++ b/test/test/test_cryptodev_aes_test_vectors.h
@@ -1213,7 +1213,7 @@ static const struct blockcipher_test_case aes_chain_test_cases[] = {
.op_mask = BLOCKCIPHER_TEST_OP_AUTH_VERIFY_DEC,
.feature_mask = BLOCKCIPHER_TEST_FEATURE_SG |
BLOCKCIPHER_TEST_FEATURE_OOP,
- .pmd_mask = BLOCKCIPHER_TEST_TARGET_PMD_MB |
+ .pmd_mask =
BLOCKCIPHER_TEST_TARGET_PMD_QAT |
BLOCKCIPHER_TEST_TARGET_PMD_SCHEDULER
},
@@ -1278,7 +1278,7 @@ static const struct blockcipher_test_case aes_chain_test_cases[] = {
.op_mask = BLOCKCIPHER_TEST_OP_ENC_AUTH_GEN,
.feature_mask = BLOCKCIPHER_TEST_FEATURE_SG |
BLOCKCIPHER_TEST_FEATURE_OOP,
- .pmd_mask = BLOCKCIPHER_TEST_TARGET_PMD_MB |
+ .pmd_mask =
BLOCKCIPHER_TEST_TARGET_PMD_OPENSSL |
BLOCKCIPHER_TEST_TARGET_PMD_QAT |
BLOCKCIPHER_TEST_TARGET_PMD_SCHEDULER |
@@ -1408,7 +1408,7 @@ static const struct blockcipher_test_case aes_chain_test_cases[] = {
.feature_mask = BLOCKCIPHER_TEST_FEATURE_SESSIONLESS |
BLOCKCIPHER_TEST_FEATURE_SG |
BLOCKCIPHER_TEST_FEATURE_OOP,
- .pmd_mask = BLOCKCIPHER_TEST_TARGET_PMD_MB |
+ .pmd_mask =
BLOCKCIPHER_TEST_TARGET_PMD_OPENSSL |
BLOCKCIPHER_TEST_TARGET_PMD_OCTEONTX
},
@@ -1435,7 +1435,7 @@ static const struct blockcipher_test_case aes_chain_test_cases[] = {
.op_mask = BLOCKCIPHER_TEST_OP_AUTH_VERIFY_DEC,
.feature_mask = BLOCKCIPHER_TEST_FEATURE_SG |
BLOCKCIPHER_TEST_FEATURE_OOP,
- .pmd_mask = BLOCKCIPHER_TEST_TARGET_PMD_MB |
+ .pmd_mask =
BLOCKCIPHER_TEST_TARGET_PMD_OPENSSL |
BLOCKCIPHER_TEST_TARGET_PMD_QAT |
BLOCKCIPHER_TEST_TARGET_PMD_DPAA2_SEC |
--
2.13.6
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: [dpdk-dev] [PATCH] test/crypto: don't attempt unsupported SGL tests on aesni mb PMD
2018-12-21 0:02 [dpdk-dev] [PATCH] test/crypto: don't attempt unsupported SGL tests on aesni mb PMD Fiona Trahe
@ 2018-12-21 11:52 ` De Lara Guarch, Pablo
2018-12-21 17:44 ` Trahe, Fiona
2019-01-11 11:04 ` De Lara Guarch, Pablo
1 sibling, 1 reply; 5+ messages in thread
From: De Lara Guarch, Pablo @ 2018-12-21 11:52 UTC (permalink / raw)
To: Trahe, Fiona, dev; +Cc: Zhang, Roy Fan, akhil.goyal
> -----Original Message-----
> From: Trahe, Fiona
> Sent: Friday, December 21, 2018 12:02 AM
> To: dev@dpdk.org
> Cc: De Lara Guarch, Pablo <pablo.de.lara.guarch@intel.com>; Trahe, Fiona
> <fiona.trahe@intel.com>; Zhang, Roy Fan <roy.fan.zhang@intel.com>;
> akhil.goyal@nxp.com
> Subject: [PATCH] test/crypto: don't attempt unsupported SGL tests on aesni
> mb PMD
>
> Remove AESNI_MB flag from SGL test cases which it doesn't support.
>
> Signed-off-by: Fiona Trahe <fiona.trahe@intel.com>
Patch looks good, but I wonder if this is a fix and therefore, if it needs to be backported.
Thanks,
Pablo
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [dpdk-dev] [PATCH] test/crypto: don't attempt unsupported SGL tests on aesni mb PMD
2018-12-21 11:52 ` De Lara Guarch, Pablo
@ 2018-12-21 17:44 ` Trahe, Fiona
0 siblings, 0 replies; 5+ messages in thread
From: Trahe, Fiona @ 2018-12-21 17:44 UTC (permalink / raw)
To: De Lara Guarch, Pablo, dev; +Cc: Zhang, Roy Fan, akhil.goyal, Trahe, Fiona
Hi Pablo,
Thanks for reviewing
> -----Original Message-----
> From: De Lara Guarch, Pablo
> Sent: Friday, December 21, 2018 4:52 AM
> To: Trahe, Fiona <fiona.trahe@intel.com>; dev@dpdk.org
> Cc: Zhang, Roy Fan <roy.fan.zhang@intel.com>; akhil.goyal@nxp.com
> Subject: RE: [PATCH] test/crypto: don't attempt unsupported SGL tests on aesni mb PMD
>
>
>
> > -----Original Message-----
> > From: Trahe, Fiona
> > Sent: Friday, December 21, 2018 12:02 AM
> > To: dev@dpdk.org
> > Cc: De Lara Guarch, Pablo <pablo.de.lara.guarch@intel.com>; Trahe, Fiona
> > <fiona.trahe@intel.com>; Zhang, Roy Fan <roy.fan.zhang@intel.com>;
> > akhil.goyal@nxp.com
> > Subject: [PATCH] test/crypto: don't attempt unsupported SGL tests on aesni
> > mb PMD
> >
> > Remove AESNI_MB flag from SGL test cases which it doesn't support.
> >
> > Signed-off-by: Fiona Trahe <fiona.trahe@intel.com>
>
> Patch looks good, but I wonder if this is a fix and therefore, if it needs to be backported.
[Fiona] It did previously print a message saying the device doesn't support
the test case, so I think more of a style change than a bug. I think this way is clearer but
not necessary to backport cause only really of interest to developers and
dev of new test cases are usually done on latest.
>
> Thanks,
> Pablo
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [dpdk-dev] [PATCH] test/crypto: don't attempt unsupported SGL tests on aesni mb PMD
2018-12-21 0:02 [dpdk-dev] [PATCH] test/crypto: don't attempt unsupported SGL tests on aesni mb PMD Fiona Trahe
2018-12-21 11:52 ` De Lara Guarch, Pablo
@ 2019-01-11 11:04 ` De Lara Guarch, Pablo
2019-01-11 11:13 ` De Lara Guarch, Pablo
1 sibling, 1 reply; 5+ messages in thread
From: De Lara Guarch, Pablo @ 2019-01-11 11:04 UTC (permalink / raw)
To: Trahe, Fiona, dev; +Cc: Zhang, Roy Fan, akhil.goyal
> -----Original Message-----
> From: Trahe, Fiona
> Sent: Friday, December 21, 2018 12:02 AM
> To: dev@dpdk.org
> Cc: De Lara Guarch, Pablo <pablo.de.lara.guarch@intel.com>; Trahe, Fiona
> <fiona.trahe@intel.com>; Zhang, Roy Fan <roy.fan.zhang@intel.com>;
> akhil.goyal@nxp.com
> Subject: [PATCH] test/crypto: don't attempt unsupported SGL tests on aesni
> mb PMD
>
> Remove AESNI_MB flag from SGL test cases which it doesn't support.
>
> Signed-off-by: Fiona Trahe <fiona.trahe@intel.com>
Acked-by: Pablo de Lara <pablo.de.lara.guarch@intel.com>
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [dpdk-dev] [PATCH] test/crypto: don't attempt unsupported SGL tests on aesni mb PMD
2019-01-11 11:04 ` De Lara Guarch, Pablo
@ 2019-01-11 11:13 ` De Lara Guarch, Pablo
0 siblings, 0 replies; 5+ messages in thread
From: De Lara Guarch, Pablo @ 2019-01-11 11:13 UTC (permalink / raw)
To: De Lara Guarch, Pablo, Trahe, Fiona, dev; +Cc: Zhang, Roy Fan, akhil.goyal
> -----Original Message-----
> From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of De Lara Guarch,
> Pablo
> Sent: Friday, January 11, 2019 11:05 AM
> To: Trahe, Fiona <fiona.trahe@intel.com>; dev@dpdk.org
> Cc: Zhang, Roy Fan <roy.fan.zhang@intel.com>; akhil.goyal@nxp.com
> Subject: Re: [dpdk-dev] [PATCH] test/crypto: don't attempt unsupported SGL
> tests on aesni mb PMD
>
>
>
> > -----Original Message-----
> > From: Trahe, Fiona
> > Sent: Friday, December 21, 2018 12:02 AM
> > To: dev@dpdk.org
> > Cc: De Lara Guarch, Pablo <pablo.de.lara.guarch@intel.com>; Trahe,
> > Fiona <fiona.trahe@intel.com>; Zhang, Roy Fan
> > <roy.fan.zhang@intel.com>; akhil.goyal@nxp.com
> > Subject: [PATCH] test/crypto: don't attempt unsupported SGL tests on
> > aesni mb PMD
> >
> > Remove AESNI_MB flag from SGL test cases which it doesn't support.
> >
> > Signed-off-by: Fiona Trahe <fiona.trahe@intel.com>
>
> Acked-by: Pablo de Lara <pablo.de.lara.guarch@intel.com>
Applied to dpdk-next-crypto.
Thanks,
Pablo
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2019-01-11 11:13 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-12-21 0:02 [dpdk-dev] [PATCH] test/crypto: don't attempt unsupported SGL tests on aesni mb PMD Fiona Trahe
2018-12-21 11:52 ` De Lara Guarch, Pablo
2018-12-21 17:44 ` Trahe, Fiona
2019-01-11 11:04 ` De Lara Guarch, Pablo
2019-01-11 11:13 ` De Lara Guarch, Pablo
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).