DPDK patches and discussions
 help / color / mirror / Atom feed
* [dpdk-dev] [PATCH] lib: fix to free trail queue entry after use
@ 2018-11-13 11:45 Hari Kumar Vemula
  2018-11-13 16:43 ` Pattan, Reshma
                   ` (4 more replies)
  0 siblings, 5 replies; 13+ messages in thread
From: Hari Kumar Vemula @ 2018-11-13 11:45 UTC (permalink / raw)
  To: dev
  Cc: reshma.pattan, byron.marohn, pablo.de.lara.guarch,
	Hari Kumar Vemula, stable

In rte_efd_create() allocated memory for trail queue entry but
not freed.
Added freeing the trail queue entry.

Fixes: 56b6ef874f80 ("efd: new Elastic Flow Distributor library")
Cc: stable@dpdk.org

Signed-off-by: Hari Kumar Vemula <hari.kumarx.vemula@intel.com>
---
 lib/librte_efd/rte_efd.c | 21 +++++++++++++++++++++
 1 file changed, 21 insertions(+)

diff --git a/lib/librte_efd/rte_efd.c b/lib/librte_efd/rte_efd.c
index a780e2fe8..f8c6c447f 100644
--- a/lib/librte_efd/rte_efd.c
+++ b/lib/librte_efd/rte_efd.c
@@ -739,17 +739,38 @@ void
 rte_efd_free(struct rte_efd_table *table)
 {
 	uint8_t socket_id;
+	struct rte_efd_list *efd_list = NULL;
+	struct rte_tailq_entry *te;
 
 	if (table == NULL)
 		return;
 
+	efd_list = RTE_TAILQ_CAST(rte_efd_tailq.head, rte_efd_list);
+
 	for (socket_id = 0; socket_id < RTE_MAX_NUMA_NODES; socket_id++)
 		rte_free(table->chunks[socket_id]);
 
+	rte_rwlock_write_lock(RTE_EAL_TAILQ_RWLOCK);
+
+	/* find our tailq entry */
+	TAILQ_FOREACH(te, efd_list, next) {
+		if (te->data == (void *) table)
+			break;
+	}
+
+	if (te == NULL) {
+		rte_rwlock_write_unlock(RTE_EAL_TAILQ_RWLOCK);
+		return;
+	}
+
+	TAILQ_REMOVE(efd_list, te, next);
+	rte_rwlock_write_unlock(RTE_EAL_TAILQ_RWLOCK);
+
 	rte_ring_free(table->free_slots);
 	rte_free(table->offline_chunks);
 	rte_free(table->keys);
 	rte_free(table);
+	rte_free(te);
 }
 
 /**
-- 
2.13.6

^ permalink raw reply	[flat|nested] 13+ messages in thread

end of thread, other threads:[~2019-01-18 18:21 UTC | newest]

Thread overview: 13+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-11-13 11:45 [dpdk-dev] [PATCH] lib: fix to free trail queue entry after use Hari Kumar Vemula
2018-11-13 16:43 ` Pattan, Reshma
2018-11-14 11:17 ` [dpdk-dev] [PATCH v2] lib/efd: fix to free tail " Hari Kumar Vemula
2018-11-18 14:57   ` Thomas Monjalon
2018-11-23 13:30   ` Maxime Coquelin
2018-11-23 14:39     ` Maxime Coquelin
2019-01-11 11:49 ` [dpdk-dev] [PATCH v3] " Hari Kumar Vemula
2019-01-14 22:30   ` [dpdk-dev] [dpdk-stable] " Thomas Monjalon
2019-01-14 22:39     ` Honnappa Nagarahalli
2019-01-17 13:36 ` [dpdk-dev] [PATCH v4] " Hari Kumar Vemula
2019-01-17 16:41   ` De Lara Guarch, Pablo
2019-01-18  7:40 ` [dpdk-dev] [PATCH v5] " Hari Kumar Vemula
2019-01-18 18:21   ` Thomas Monjalon

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).