From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga05.intel.com (mga05.intel.com [192.55.52.43]) by dpdk.org (Postfix) with ESMTP id AA8F11B209 for ; Tue, 23 Apr 2019 16:44:00 +0200 (CEST) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga005.fm.intel.com ([10.253.24.32]) by fmsmga105.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 23 Apr 2019 07:43:59 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.60,386,1549958400"; d="scan'208";a="340017486" Received: from irsmsx106.ger.corp.intel.com ([163.33.3.31]) by fmsmga005.fm.intel.com with ESMTP; 23 Apr 2019 07:38:59 -0700 Received: from irsmsx112.ger.corp.intel.com ([169.254.1.101]) by IRSMSX106.ger.corp.intel.com ([169.254.8.235]) with mapi id 14.03.0415.000; Tue, 23 Apr 2019 15:38:58 +0100 From: "De Lara Guarch, Pablo" To: "Richardson, Bruce" , "dev@dpdk.org" CC: "Doherty, Declan" Thread-Topic: [PATCH 1/2] crypto/aesni_gcm: add dependency version check Thread-Index: AQHU9pbedrVwQATck0WbStJUbVvanKZJ1wKA Date: Tue, 23 Apr 2019 14:38:58 +0000 Message-ID: References: <20190419100113.31284-1-bruce.richardson@intel.com> In-Reply-To: <20190419100113.31284-1-bruce.richardson@intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiMzcwOWY3YmMtMzI5NC00OWRjLTgyMTktNjM1OWQ3ZWQ4NjFhIiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX05UIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE3LjEwLjE4MDQuNDkiLCJUcnVzdGVkTGFiZWxIYXNoIjoiWVwvQmZnMTJVNnRKejZ1SUx2aE9vdUVpWGlKTnlUWnBZcUNXY21cLzZaaDBaRGt2MHFNd1NFTzhMR01YZHVvMG5mIn0= x-ctpclassification: CTP_NT dlp-product: dlpe-windows dlp-version: 11.0.600.7 dlp-reaction: no-action x-originating-ip: [163.33.239.180] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH 1/2] crypto/aesni_gcm: add dependency version check X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 23 Apr 2019 14:44:01 -0000 > -----Original Message----- > From: Richardson, Bruce > Sent: Friday, April 19, 2019 11:01 AM > To: dev@dpdk.org > Cc: De Lara Guarch, Pablo ; Doherty, > Declan ; Richardson, Bruce > > Subject: [PATCH 1/2] crypto/aesni_gcm: add dependency version check >=20 > The aesni_mb driver and the aesni_gcm driver both require the same versio= n > of the IPSec_MB library, but only the former has a check of the library f= ound > to see if it's the correct version. Add a similar check to the aesni_gcm > library's meson.build file, so that the auto-detection of dependencies wo= rks > correctly. >=20 > Signed-off-by: Bruce Richardson > --- > drivers/crypto/aesni_gcm/meson.build | 11 +++++++++++ > 1 file changed, 11 insertions(+) >=20 > diff --git a/drivers/crypto/aesni_gcm/meson.build > b/drivers/crypto/aesni_gcm/meson.build > index 70f57ad73..7183cfcba 100644 > --- a/drivers/crypto/aesni_gcm/meson.build > +++ b/drivers/crypto/aesni_gcm/meson.build The patch looks good, but we should broaden its scope and also modify the M= akefile, to check for the library version, like in the aesni_mb PMD. Could you add that check too? Thanks! Pablo From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by dpdk.space (Postfix) with ESMTP id AB933A05D3 for ; Tue, 23 Apr 2019 16:44:03 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id B9F8F1B399; Tue, 23 Apr 2019 16:44:02 +0200 (CEST) Received: from mga05.intel.com (mga05.intel.com [192.55.52.43]) by dpdk.org (Postfix) with ESMTP id AA8F11B209 for ; Tue, 23 Apr 2019 16:44:00 +0200 (CEST) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga005.fm.intel.com ([10.253.24.32]) by fmsmga105.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 23 Apr 2019 07:43:59 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.60,386,1549958400"; d="scan'208";a="340017486" Received: from irsmsx106.ger.corp.intel.com ([163.33.3.31]) by fmsmga005.fm.intel.com with ESMTP; 23 Apr 2019 07:38:59 -0700 Received: from irsmsx112.ger.corp.intel.com ([169.254.1.101]) by IRSMSX106.ger.corp.intel.com ([169.254.8.235]) with mapi id 14.03.0415.000; Tue, 23 Apr 2019 15:38:58 +0100 From: "De Lara Guarch, Pablo" To: "Richardson, Bruce" , "dev@dpdk.org" CC: "Doherty, Declan" Thread-Topic: [PATCH 1/2] crypto/aesni_gcm: add dependency version check Thread-Index: AQHU9pbedrVwQATck0WbStJUbVvanKZJ1wKA Date: Tue, 23 Apr 2019 14:38:58 +0000 Message-ID: References: <20190419100113.31284-1-bruce.richardson@intel.com> In-Reply-To: <20190419100113.31284-1-bruce.richardson@intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiMzcwOWY3YmMtMzI5NC00OWRjLTgyMTktNjM1OWQ3ZWQ4NjFhIiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX05UIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE3LjEwLjE4MDQuNDkiLCJUcnVzdGVkTGFiZWxIYXNoIjoiWVwvQmZnMTJVNnRKejZ1SUx2aE9vdUVpWGlKTnlUWnBZcUNXY21cLzZaaDBaRGt2MHFNd1NFTzhMR01YZHVvMG5mIn0= x-ctpclassification: CTP_NT dlp-product: dlpe-windows dlp-version: 11.0.600.7 dlp-reaction: no-action x-originating-ip: [163.33.239.180] Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH 1/2] crypto/aesni_gcm: add dependency version check X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Message-ID: <20190423143858.vkM1VSLEstwu3c7uG96YfEnvsTOph5ZdcHjoWfiK7T8@z> > -----Original Message----- > From: Richardson, Bruce > Sent: Friday, April 19, 2019 11:01 AM > To: dev@dpdk.org > Cc: De Lara Guarch, Pablo ; Doherty, > Declan ; Richardson, Bruce > > Subject: [PATCH 1/2] crypto/aesni_gcm: add dependency version check >=20 > The aesni_mb driver and the aesni_gcm driver both require the same versio= n > of the IPSec_MB library, but only the former has a check of the library f= ound > to see if it's the correct version. Add a similar check to the aesni_gcm > library's meson.build file, so that the auto-detection of dependencies wo= rks > correctly. >=20 > Signed-off-by: Bruce Richardson > --- > drivers/crypto/aesni_gcm/meson.build | 11 +++++++++++ > 1 file changed, 11 insertions(+) >=20 > diff --git a/drivers/crypto/aesni_gcm/meson.build > b/drivers/crypto/aesni_gcm/meson.build > index 70f57ad73..7183cfcba 100644 > --- a/drivers/crypto/aesni_gcm/meson.build > +++ b/drivers/crypto/aesni_gcm/meson.build The patch looks good, but we should broaden its scope and also modify the M= akefile, to check for the library version, like in the aesni_mb PMD. Could you add that check too? Thanks! Pablo