From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga01.intel.com (mga01.intel.com [192.55.52.88]) by dpdk.org (Postfix) with ESMTP id E824C1DB9 for ; Tue, 23 Apr 2019 16:40:27 +0200 (CEST) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga002.fm.intel.com ([10.253.24.26]) by fmsmga101.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 23 Apr 2019 07:40:27 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.60,386,1549958400"; d="scan'208";a="164091876" Received: from irsmsx102.ger.corp.intel.com ([163.33.3.155]) by fmsmga002.fm.intel.com with ESMTP; 23 Apr 2019 07:40:26 -0700 Received: from irsmsx112.ger.corp.intel.com ([169.254.1.101]) by IRSMSX102.ger.corp.intel.com ([169.254.2.21]) with mapi id 14.03.0415.000; Tue, 23 Apr 2019 15:40:25 +0100 From: "De Lara Guarch, Pablo" To: "Richardson, Bruce" , "dev@dpdk.org" CC: "Doherty, Declan" Thread-Topic: [PATCH 2/2] crypto/aesni_mb: cleanup of version check code Thread-Index: AQHU9pbjvJDJdqzW+ESs+25KNcOwVaZJ13jQ Date: Tue, 23 Apr 2019 14:40:25 +0000 Message-ID: References: <20190419100113.31284-1-bruce.richardson@intel.com> <20190419100113.31284-2-bruce.richardson@intel.com> In-Reply-To: <20190419100113.31284-2-bruce.richardson@intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiMmUyYzRlOWUtYzdkNS00ZDI2LTgwZjYtODhhMmExYzgwZmY1IiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX05UIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE3LjEwLjE4MDQuNDkiLCJUcnVzdGVkTGFiZWxIYXNoIjoiaU1iQVozbjNMd3FDXC9lVTM0ZkNFUDFrcUdwWVNDcWhFRzJLSUpjdXZlRVZqMWVENGhlblBBSDdzcTQ2TmRXb3QifQ== x-ctpclassification: CTP_NT dlp-product: dlpe-windows dlp-version: 11.0.600.7 dlp-reaction: no-action x-originating-ip: [163.33.239.180] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH 2/2] crypto/aesni_mb: cleanup of version check code X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 23 Apr 2019 14:40:28 -0000 > -----Original Message----- > From: Richardson, Bruce > Sent: Friday, April 19, 2019 11:01 AM > To: dev@dpdk.org > Cc: De Lara Guarch, Pablo ; Doherty, > Declan ; Richardson, Bruce > > Subject: [PATCH 2/2] crypto/aesni_mb: cleanup of version check code >=20 > The version check for the IPSec_MB library present in the aesni_gcm libra= ry's > meson.build file is a little cleaner than that given here, so update this= one so > that both work identically. >=20 > While one could use the checks done in the other right now, potentially i= n > future they may have different version dependencies, or may be compiled i= n > different orders, so keep the code duplicated for safety, since it's only= a few > lines. >=20 > Signed-off-by: Bruce Richardson Acked-by: Pablo de Lara From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by dpdk.space (Postfix) with ESMTP id BF4EAA05D3 for ; Tue, 23 Apr 2019 16:40:29 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id D73815B2E; Tue, 23 Apr 2019 16:40:28 +0200 (CEST) Received: from mga01.intel.com (mga01.intel.com [192.55.52.88]) by dpdk.org (Postfix) with ESMTP id E824C1DB9 for ; Tue, 23 Apr 2019 16:40:27 +0200 (CEST) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga002.fm.intel.com ([10.253.24.26]) by fmsmga101.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 23 Apr 2019 07:40:27 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.60,386,1549958400"; d="scan'208";a="164091876" Received: from irsmsx102.ger.corp.intel.com ([163.33.3.155]) by fmsmga002.fm.intel.com with ESMTP; 23 Apr 2019 07:40:26 -0700 Received: from irsmsx112.ger.corp.intel.com ([169.254.1.101]) by IRSMSX102.ger.corp.intel.com ([169.254.2.21]) with mapi id 14.03.0415.000; Tue, 23 Apr 2019 15:40:25 +0100 From: "De Lara Guarch, Pablo" To: "Richardson, Bruce" , "dev@dpdk.org" CC: "Doherty, Declan" Thread-Topic: [PATCH 2/2] crypto/aesni_mb: cleanup of version check code Thread-Index: AQHU9pbjvJDJdqzW+ESs+25KNcOwVaZJ13jQ Date: Tue, 23 Apr 2019 14:40:25 +0000 Message-ID: References: <20190419100113.31284-1-bruce.richardson@intel.com> <20190419100113.31284-2-bruce.richardson@intel.com> In-Reply-To: <20190419100113.31284-2-bruce.richardson@intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiMmUyYzRlOWUtYzdkNS00ZDI2LTgwZjYtODhhMmExYzgwZmY1IiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX05UIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE3LjEwLjE4MDQuNDkiLCJUcnVzdGVkTGFiZWxIYXNoIjoiaU1iQVozbjNMd3FDXC9lVTM0ZkNFUDFrcUdwWVNDcWhFRzJLSUpjdXZlRVZqMWVENGhlblBBSDdzcTQ2TmRXb3QifQ== x-ctpclassification: CTP_NT dlp-product: dlpe-windows dlp-version: 11.0.600.7 dlp-reaction: no-action x-originating-ip: [163.33.239.180] Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH 2/2] crypto/aesni_mb: cleanup of version check code X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Message-ID: <20190423144025.jFz76p-vJiwLoeCYtnpW48MLkhLNOvbA9TH5U5aDuvA@z> > -----Original Message----- > From: Richardson, Bruce > Sent: Friday, April 19, 2019 11:01 AM > To: dev@dpdk.org > Cc: De Lara Guarch, Pablo ; Doherty, > Declan ; Richardson, Bruce > > Subject: [PATCH 2/2] crypto/aesni_mb: cleanup of version check code >=20 > The version check for the IPSec_MB library present in the aesni_gcm libra= ry's > meson.build file is a little cleaner than that given here, so update this= one so > that both work identically. >=20 > While one could use the checks done in the other right now, potentially i= n > future they may have different version dependencies, or may be compiled i= n > different orders, so keep the code duplicated for safety, since it's only= a few > lines. >=20 > Signed-off-by: Bruce Richardson Acked-by: Pablo de Lara