DPDK patches and discussions
 help / color / mirror / Atom feed
From: "Wiles, Roger Keith" <keith.wiles@windriver.com>
To: Thomas Monjalon <thomas.monjalon@6wind.com>
Cc: "dev@dpdk.org" <dev@dpdk.org>, Hayato Momma <h-momma@ce.jp.nec.com>
Subject: Re: [dpdk-dev] [memnic PATCH 7/7] pmd: split calling mbuf free
Date: Wed, 24 Sep 2014 16:01:00 +0000	[thread overview]
Message-ID: <E13F384F-E4F9-46B2-8874-CB7EDB816D1A@windriver.com> (raw)
In-Reply-To: <16805029.uPnEfVsb0t@xps13>


On Sep 24, 2014, at 10:20 AM, Thomas Monjalon <thomas.monjalon@6wind.com> wrote:

> 2014-09-11 07:52, Hiroshi Shimamoto:
>> @@ -408,9 +408,9 @@ retry:
>> 
>> 		rte_compiler_barrier();
>> 		p->status = MEMNIC_PKT_ST_FILLED;
>> -
>> -		rte_pktmbuf_free(tx_pkts[nr]);
>> 	}
>> +	for (i = 0; i < nr; i++)
>> +		rte_pktmbuf_free(tx_pkts[i]);
>> 
>> 	/* stats */
>> 	st->opackets += pkts;
>> 
> 
> You are bursting mbuf freeing. Why title is about "split”?

Maybe this should be a new API as in rte_pktmbuf_bulk_free(tx_pkts, nr); ??
This would remove the loop in the application and I know I have done the same thing for Pktgen too.
> 
> -- 
> Thomas

Keith Wiles, Principal Technologist with CTO office, Wind River mobile 972-213-5533

  reply	other threads:[~2014-09-24 15:54 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-09-11  7:52 Hiroshi Shimamoto
2014-09-24 15:20 ` Thomas Monjalon
2014-09-24 16:01   ` Wiles, Roger Keith [this message]
2014-09-25  1:12     ` Hiroshi Shimamoto
2014-09-25  2:18       ` Wiles, Roger Keith

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=E13F384F-E4F9-46B2-8874-CB7EDB816D1A@windriver.com \
    --to=keith.wiles@windriver.com \
    --cc=dev@dpdk.org \
    --cc=h-momma@ce.jp.nec.com \
    --cc=thomas.monjalon@6wind.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).