From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail1.windriver.com (mail1.windriver.com [147.11.146.13]) by dpdk.org (Postfix) with ESMTP id 2E6C96885 for ; Wed, 24 Sep 2014 17:54:55 +0200 (CEST) Received: from ALA-HCB.corp.ad.wrs.com (ala-hcb.corp.ad.wrs.com [147.11.189.41]) by mail1.windriver.com (8.14.9/8.14.5) with ESMTP id s8OG11kJ006757 (version=TLSv1/SSLv3 cipher=AES128-SHA bits=128 verify=FAIL); Wed, 24 Sep 2014 09:01:01 -0700 (PDT) Received: from ALA-MBB.corp.ad.wrs.com ([169.254.1.18]) by ALA-HCB.corp.ad.wrs.com ([147.11.189.41]) with mapi id 14.03.0174.001; Wed, 24 Sep 2014 09:01:00 -0700 From: "Wiles, Roger Keith" To: Thomas Monjalon Thread-Topic: [dpdk-dev] [memnic PATCH 7/7] pmd: split calling mbuf free Thread-Index: Ac/NlUxI5nJ3s/X2TP+cHArf+IKJdAKsHXwAAAFpgQA= Date: Wed, 24 Sep 2014 16:01:00 +0000 Message-ID: References: <7F861DC0615E0C47A872E6F3C5FCDDBD011A99C6@BPXM14GP.gisp.nec.co.jp> <16805029.uPnEfVsb0t@xps13> In-Reply-To: <16805029.uPnEfVsb0t@xps13> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [172.25.40.166] Content-Type: text/plain; charset="Windows-1252" Content-ID: Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Cc: "dev@dpdk.org" , Hayato Momma Subject: Re: [dpdk-dev] [memnic PATCH 7/7] pmd: split calling mbuf free X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 24 Sep 2014 15:54:55 -0000 On Sep 24, 2014, at 10:20 AM, Thomas Monjalon w= rote: > 2014-09-11 07:52, Hiroshi Shimamoto: >> @@ -408,9 +408,9 @@ retry: >>=20 >> rte_compiler_barrier(); >> p->status =3D MEMNIC_PKT_ST_FILLED; >> - >> - rte_pktmbuf_free(tx_pkts[nr]); >> } >> + for (i =3D 0; i < nr; i++) >> + rte_pktmbuf_free(tx_pkts[i]); >>=20 >> /* stats */ >> st->opackets +=3D pkts; >>=20 >=20 > You are bursting mbuf freeing. Why title is about "split=94? Maybe this should be a new API as in rte_pktmbuf_bulk_free(tx_pkts, nr); ?? This would remove the loop in the application and I know I have done the sa= me thing for Pktgen too. >=20 > --=20 > Thomas Keith Wiles, Principal Technologist with CTO office, Wind River mobile 972-= 213-5533