From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <zhiyong.yang@intel.com>
Received: from mga03.intel.com (mga03.intel.com [134.134.136.65])
 by dpdk.org (Postfix) with ESMTP id 009B52B86
 for <dev@dpdk.org>; Thu, 29 Sep 2016 15:50:30 +0200 (CEST)
Received: from fmsmga005.fm.intel.com ([10.253.24.32])
 by orsmga103.jf.intel.com with ESMTP; 29 Sep 2016 06:50:29 -0700
X-ExtLoop1: 1
X-IronPort-AV: E=Sophos;i="5.30,415,1470726000"; d="scan'208";a="14544480"
Received: from fmsmsx105.amr.corp.intel.com ([10.18.124.203])
 by fmsmga005.fm.intel.com with ESMTP; 29 Sep 2016 06:50:29 -0700
Received: from fmsmsx125.amr.corp.intel.com (10.18.125.40) by
 FMSMSX105.amr.corp.intel.com (10.18.124.203) with Microsoft SMTP Server (TLS)
 id 14.3.248.2; Thu, 29 Sep 2016 06:50:29 -0700
Received: from bgsmsx102.gar.corp.intel.com (10.223.4.172) by
 FMSMSX125.amr.corp.intel.com (10.18.125.40) with Microsoft SMTP Server (TLS)
 id 14.3.248.2; Thu, 29 Sep 2016 06:50:29 -0700
Received: from bgsmsx101.gar.corp.intel.com ([169.254.1.10]) by
 BGSMSX102.gar.corp.intel.com ([169.254.2.193]) with mapi id 14.03.0248.002;
 Thu, 29 Sep 2016 19:20:26 +0530
From: "Yang, Zhiyong" <zhiyong.yang@intel.com>
To: Yuanhan Liu <yuanhan.liu@linux.intel.com>
CC: "dev@dpdk.org" <dev@dpdk.org>, "Loftus, Ciara" <ciara.loftus@intel.com>
Thread-Topic: [PATCH v8 2/2] net/vhost: add pmd xstats
Thread-Index: AQHSGk5e+vQxwVS4+Ua1kseCahcoWaCQE1CAgABoOvA=
Date: Thu, 29 Sep 2016 13:50:25 +0000
Message-ID: <E182254E98A5DA4EB1E657AC7CB9BD2A3EB18CC7@BGSMSX101.gar.corp.intel.com>
References: <1475069208-137698-2-git-send-email-zhiyong.yang@intel.com>
 <1475152549-12295-1-git-send-email-zhiyong.yang@intel.com>
 <1475152549-12295-3-git-send-email-zhiyong.yang@intel.com>
 <20160929130451.GL1597@yliu-dev.sh.intel.com>
In-Reply-To: <20160929130451.GL1597@yliu-dev.sh.intel.com>
Accept-Language: en-US
Content-Language: en-US
X-MS-Has-Attach: 
X-MS-TNEF-Correlator: 
x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiMTU5ZmNhNjQtMDI5Yi00NjFhLWFkZDItZmM2NGRlNDAzZDA0IiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX0lDIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE1LjkuNi42IiwiVHJ1c3RlZExhYmVsSGFzaCI6InlmdlBPVmtSRjZ2MExQNVZCbXJ5dlZqVGxNeG9hYlphUVJzMk1Lekd0TXM9In0=
x-ctpclassification: CTP_IC
x-originating-ip: [10.223.10.10]
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
Subject: Re: [dpdk-dev] [PATCH v8 2/2] net/vhost: add pmd xstats
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Thu, 29 Sep 2016 13:50:31 -0000

Thanks very much,  yuanhan.

> -----Original Message-----
> From: Yuanhan Liu [mailto:yuanhan.liu@linux.intel.com]
> Sent: Thursday, September 29, 2016 9:05 PM
> To: Yang, Zhiyong <zhiyong.yang@intel.com>
> Cc: dev@dpdk.org; Loftus, Ciara <ciara.loftus@intel.com>
> Subject: Re: [PATCH v8 2/2] net/vhost: add pmd xstats
>=20
> On Thu, Sep 29, 2016 at 08:35:49PM +0800, Zhiyong Yang wrote:
> > This feature adds vhost pmd extended statistics from per port
> > perspective in order to meet the requirements of the applications such =
as
> OVS etc.
> > RX/TX xstats count the bytes without CRC. This is different from
> > physical NIC stats with CRC.
> ...
> > net/virtio pmd xstats(the function virtio_update_packet_stats) is used
> > as reference when implementing the feature.
> >
> > Thanks for the patches Zhiyong. I've tested the size stats and they
> > look good to me.
>=20
> The above paragraph should not be in the commit log.
>=20
> > Tested-by: Ciara Loftus <ciara.loftus@intel.com>
> >
> > Signed-off-by: Zhiyong Yang <zhiyong.yang@intel.com>
>=20
> There should be no whitespace line bewteen the Tested-by and your SoB.
>=20
> Fixed, and series applied to dpdk-next-virtio.
>=20
> 	--yliu