From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga11.intel.com (mga11.intel.com [192.55.52.93]) by dpdk.org (Postfix) with ESMTP id 344FA2BC5 for ; Wed, 7 Dec 2016 10:43:09 +0100 (CET) Received: from fmsmga006.fm.intel.com ([10.253.24.20]) by fmsmga102.fm.intel.com with ESMTP; 07 Dec 2016 01:43:09 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.33,310,1477983600"; d="scan'208";a="39931562" Received: from fmsmsx107.amr.corp.intel.com ([10.18.124.205]) by fmsmga006.fm.intel.com with ESMTP; 07 Dec 2016 01:43:09 -0800 Received: from fmsmsx119.amr.corp.intel.com (10.18.124.207) by fmsmsx107.amr.corp.intel.com (10.18.124.205) with Microsoft SMTP Server (TLS) id 14.3.248.2; Wed, 7 Dec 2016 01:43:09 -0800 Received: from bgsmsx106.gar.corp.intel.com (10.223.43.196) by FMSMSX119.amr.corp.intel.com (10.18.124.207) with Microsoft SMTP Server (TLS) id 14.3.248.2; Wed, 7 Dec 2016 01:43:08 -0800 Received: from bgsmsx101.gar.corp.intel.com ([169.254.1.239]) by BGSMSX106.gar.corp.intel.com ([10.223.43.196]) with mapi id 14.03.0248.002; Wed, 7 Dec 2016 15:13:06 +0530 From: "Yang, Zhiyong" To: Yuanhan Liu CC: Maxime Coquelin , "dev@dpdk.org" , "Richardson, Bruce" , "Ananyev, Konstantin" , "Pierre Pfister (ppfister)" Thread-Topic: [dpdk-dev] [PATCH 0/4] eal/common: introduce rte_memset and related test Thread-Index: AQHSTIMNk96An4FgQk6QFEotIgsnhKD6eePw///GpYCAAffB4P//rZoAgABczJA= Date: Wed, 7 Dec 2016 09:43:06 +0000 Message-ID: References: <1480926387-63838-1-git-send-email-zhiyong.yang@intel.com> <20161207093742.GF31182@yliu-dev.sh.intel.com> In-Reply-To: <20161207093742.GF31182@yliu-dev.sh.intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiOWQ3ODM1ZmUtNTQ4Ny00YmY1LWI3YjUtZThjYTZhNWMxMGMyIiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX0lDIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE1LjkuNi42IiwiVHJ1c3RlZExhYmVsSGFzaCI6Ik5RYmc1alBnUmdNTmZcL2lPMzZGUXRkdlZSXC9mNFJxMWlrTjJEaDlJdHZRdz0ifQ== x-ctpclassification: CTP_IC x-originating-ip: [10.223.10.10] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH 0/4] eal/common: introduce rte_memset and related test X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 07 Dec 2016 09:43:10 -0000 Hi, yuanhan: > -----Original Message----- > From: Yuanhan Liu [mailto:yuanhan.liu@linux.intel.com] > Sent: Wednesday, December 7, 2016 5:38 PM > To: Yang, Zhiyong > Cc: Maxime Coquelin ; dev@dpdk.org; > Richardson, Bruce ; Ananyev, Konstantin > ; Pierre Pfister (ppfister) > > Subject: Re: [dpdk-dev] [PATCH 0/4] eal/common: introduce rte_memset > and related test >=20 > On Wed, Dec 07, 2016 at 09:28:17AM +0000, Yang, Zhiyong wrote: > > > >> Wouldn't be worth to also use rte_memset in Virtio PMD (not > > > >> compiled/tested)? : > > > >> > > > > > > > > I think rte_memset maybe can bring some benefit here, but , I'm > > > > not clear how to enter the branch and test it. :) > > > > > > Indeed, you will need Pierre's patch: > > > [dpdk-dev] [PATCH] virtio: tx with can_push when VERSION_1 is set >=20 > I will apply it shortly. >=20 > > > Thanks, > > > Maxime > > > > > > Thank you Maxime. > > I can see a little, but not obviously performance improvement here. >=20 > Are you you have run into that code piece? FYI, you have to enable virtio= 1.0 > explicitly, which is disabled by deafault. Yes. I use the patch from Pierre and set offload =3D 0 ;=20 Thanks Zhiyong >=20 > > You know, memset(hdr, 0, head_size); only consumes fewer cycles for > virtio pmd. > > head_size only 10 or 12 bytes. > > I optimize rte_memset perf further for N=3D8~15 bytes. > > The main purpose of Introducing rte_memset is that we can use it to > > avoid perf drop issue instead of glibc memset on some platform, I think= . >=20 > For this case (as well as the 4th patch), it's more about making sure > rte_memset is inlined. >=20 > --yliu