From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga05.intel.com (mga05.intel.com [192.55.52.43]) by dpdk.org (Postfix) with ESMTP id DAF423277 for ; Wed, 18 Jan 2017 03:42:24 +0100 (CET) Received: from orsmga003.jf.intel.com ([10.7.209.27]) by fmsmga105.fm.intel.com with ESMTP; 17 Jan 2017 18:42:23 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.33,247,1477983600"; d="scan'208";a="923748901" Received: from fmsmsx104.amr.corp.intel.com ([10.18.124.202]) by orsmga003.jf.intel.com with ESMTP; 17 Jan 2017 18:42:23 -0800 Received: from fmsmsx152.amr.corp.intel.com (10.18.125.5) by fmsmsx104.amr.corp.intel.com (10.18.124.202) with Microsoft SMTP Server (TLS) id 14.3.248.2; Tue, 17 Jan 2017 18:42:23 -0800 Received: from BGSMSX108.gar.corp.intel.com (10.223.4.192) by FMSMSX152.amr.corp.intel.com (10.18.125.5) with Microsoft SMTP Server (TLS) id 14.3.248.2; Tue, 17 Jan 2017 18:42:23 -0800 Received: from bgsmsx101.gar.corp.intel.com ([169.254.1.43]) by BGSMSX108.gar.corp.intel.com ([169.254.8.175]) with mapi id 14.03.0248.002; Wed, 18 Jan 2017 08:12:20 +0530 From: "Yang, Zhiyong" To: Thomas Monjalon CC: "Richardson, Bruce" , "Ananyev, Konstantin" , "yuanhan.liu@linux.intel.com" , "De Lara Guarch, Pablo" , "dev@dpdk.org" Thread-Topic: [dpdk-dev] [PATCH v2 0/4] eal/common: introduce rte_memset and related test Thread-Index: AQHScP5L8DuI0WrQd0GJ+TBXopfp1KE9eEQQ Date: Wed, 18 Jan 2017 02:42:19 +0000 Message-ID: References: <1480926387-63838-2-git-send-email-zhiyong.yang@intel.com> <2941830.sLC5GUQ46q@xps13> In-Reply-To: <2941830.sLC5GUQ46q@xps13> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiYmZkNTI2OWQtMWZkYi00ZmY5LTlmNzgtYzEyMGNlYzc1YjcwIiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX0lDIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE1LjkuNi42IiwiVHJ1c3RlZExhYmVsSGFzaCI6IjA4MTdFZGZ6ZCtlWFpKTTFzNU9QNWVycEYyaytUSkwyNXMxZ2kxaTh3cUk9In0= x-ctpclassification: CTP_IC x-originating-ip: [10.223.10.10] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH v2 0/4] eal/common: introduce rte_memset and related test X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 18 Jan 2017 02:42:25 -0000 hi, Thomas: Thanks for your reply. > -----Original Message----- > From: Thomas Monjalon [mailto:thomas.monjalon@6wind.com] > Sent: Wednesday, January 18, 2017 4:14 AM > To: Yang, Zhiyong > Cc: Richardson, Bruce ; Ananyev, Konstantin > ; yuanhan.liu@linux.intel.com; De Lara > Guarch, Pablo ; dev@dpdk.org > Subject: Re: [dpdk-dev] [PATCH v2 0/4] eal/common: introduce rte_memset > and related test >=20 > 2017-01-17 06:24, Yang, Zhiyong: > > Hi, Thomas: > > Does this patchset have chance to be applied for 1702 release? >=20 > It could be part of 17.02 but there are some issues: >=20 > The x86 part did not receive any ack from x86 maintainers. Ok >=20 > checkpatch reports some warnings, especially about counting elements of a= n > array. Please use RTE_DIM. Ok, I ignore these warning as reference to current release code. More clean= code will been sent in future. >=20 > The file in generic/ is for doxygen only. > Please check how it is done for other files. Ok. I don't know this before. :), thank you. >=20 > The description is "Functions for vectorised implementation of memset()." > Does it mean memset from glibc does not use vector instructions? >=20 Sorry for causing misleading understanding, Glibc memset() use vectorization instructions to implement optimization, of= course. I just want to say "the functions for implementing the same functionality like glibc memset() ". My bad English expressions. :) > The functional autotest is not integrated in the basic test suite. >=20 I can run command line "memset_autotest", It seems that I leave something = out. > I wish this kind of review would be done by someone else. > As it has not a big performance impact, this series could wait the next r= elease. Ok. Maybe memset() consumes small ratio for current DPDK data path.=20 > By the way, have you tried to work on glibc, as I had suggested? I'm not familiar with glibc regulation, as far as I know, glibc is using X8= 6 asm, rather than intrinsic. I will consider your suggestion.=20 =20