From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga04.intel.com (mga04.intel.com [192.55.52.120]) by dpdk.org (Postfix) with ESMTP id 49198106A for ; Sat, 21 Jan 2017 05:14:04 +0100 (CET) Received: from fmsmga002.fm.intel.com ([10.253.24.26]) by fmsmga104.fm.intel.com with ESMTP; 20 Jan 2017 20:14:04 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.33,261,1477983600"; d="scan'208,217";a="1115778040" Received: from fmsmsx106.amr.corp.intel.com ([10.18.124.204]) by fmsmga002.fm.intel.com with ESMTP; 20 Jan 2017 20:14:03 -0800 Received: from fmsmsx120.amr.corp.intel.com (10.18.124.208) by FMSMSX106.amr.corp.intel.com (10.18.124.204) with Microsoft SMTP Server (TLS) id 14.3.248.2; Fri, 20 Jan 2017 20:14:04 -0800 Received: from BGSMSX107.gar.corp.intel.com (10.223.4.191) by fmsmsx120.amr.corp.intel.com (10.18.124.208) with Microsoft SMTP Server (TLS) id 14.3.248.2; Fri, 20 Jan 2017 20:14:03 -0800 Received: from bgsmsx101.gar.corp.intel.com ([169.254.1.43]) by BGSMSX107.gar.corp.intel.com ([169.254.9.175]) with mapi id 14.03.0248.002; Sat, 21 Jan 2017 09:44:00 +0530 From: "Yang, Zhiyong" To: Andrew Rybchenko , "dev@dpdk.org" CC: "thomas.monjalon@6wind.com" , "Richardson, Bruce" , "Ananyev, Konstantin" Thread-Topic: [dpdk-dev] [RFC] lib/librte_ether: consistent PMD batching behavior Thread-Index: AQHScwLxY9/t//0KCkG+GNAuCk/VhKFAzQkAgAGFA8A= Date: Sat, 21 Jan 2017 04:13:59 +0000 Message-ID: References: <1484905876-60165-1-git-send-email-zhiyong.yang@intel.com> In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiYmI2YTgxNTQtNzVlZS00NjM3LTk5YTYtYjA4ZmI3ZjNhNDdhIiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX0lDIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE1LjkuNi42IiwiVHJ1c3RlZExhYmVsSGFzaCI6IkZydVlrcVVtV0FMNE56UGlvZXl6Wk10MXc1M0V6ckI4T1NMbExINWlMOGs9In0= x-ctpclassification: CTP_IC x-originating-ip: [10.223.10.10] MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable X-Content-Filtered-By: Mailman/MimeDel 2.1.15 Subject: Re: [dpdk-dev] [RFC] lib/librte_ether: consistent PMD batching behavior X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 21 Jan 2017 04:14:05 -0000 From: Andrew Rybchenko [mailto:arybchenko@solarflare.com] Sent: Friday, January 20, 2017 6:26 PM To: Yang, Zhiyong ; dev@dpdk.org Cc: thomas.monjalon@6wind.com; Richardson, Bruce ; Ananyev, Konstantin Subject: Re: [dpdk-dev] [RFC] lib/librte_ether: consistent PMD batching beh= avior On 01/20/2017 12:51 PM, Zhiyong Yang wrote: The rte_eth_tx_burst() function in the file Rte_ethdev.h is invoked to transmit output packets on the output queue for DPDK applications as follows. static inline uint16_t rte_eth_tx_burst(uint8_t port_id, uint16_t queue_id, struct rte_mbuf **tx_pkts, uint16_t nb_pkts); Note: The fourth parameter nb_pkts: The number of packets to transmit. The rte_eth_tx_burst() function returns the number of packets it actually sent. The return value equal to *nb_pkts* means that all packets have been sent, and this is likely to signify that other output packets could be immediately transmitted again. Applications that implement a "send as many packets to transmit as possible" policy can check this specific case and keep invoking the rte_eth_tx_burst() function until a value less than *nb_pkts* is returned. When you call TX only once in rte_eth_tx_burst, you may get different behaviors from different PMDs. One problem that every DPDK user has to face is that they need to take the policy into consideration at the app- lication level when using any specific PMD to send the packets whether or not it is necessary, which brings usage complexities and makes DPDK users easily confused since they have to learn the details on TX function limit of specific PMDs and have to handle the different return value: the number of packets transmitted successfully for various PMDs. Some PMDs Tx func- tions have a limit of sending at most 32 packets for every invoking, some PMDs have another limit of at most 64 packets once, another ones have imp- lemented to send as many packets to transmit as possible, etc. This will easily cause wrong usage for DPDK users. This patch proposes to implement the above policy in DPDK lib in order to simplify the application implementation and avoid the incorrect invoking as well. So, DPDK Users don't need to consider the implementation policy and to write duplicated code at the application level again when sending packets. In addition to it, the users don't need to know the difference of specific PMD TX and can transmit the arbitrary number of packets as they expect when invoking TX API rte_eth_tx_burst, then check the return value to get the number of packets actually sent. How to implement the policy in DPDK lib? Two solutions are proposed below. Solution 1: Implement the wrapper functions to remove some limits for each specific PMDs as i40e_xmit_pkts_simple and ixgbe_xmit_pkts_simple do like that. IMHO, the solution is a bit better since it: 1. Does not affect other PMDs at all 2. Could be a bit faster for the PMDs which require it since has no indire= ct function call on each iteration 3. No ABI change Solution 2: Implement the policy in the function rte_eth_tx_burst() at the ethdev lay- er in a more consistent batching way. Make best effort to send *nb_pkts* packets with bursts of no more than 32 by default since many DPDK TX PMDs are using this max TX burst size(32). In addition, one data member which defines the max TX burst size such as "uint16_t max_tx_burst_pkts;"will be added to rte_eth_dev_data, which drivers can override if they work with bursts of 64 or other NB(thanks for Bruce 's suggestion). This can reduce the performance impacting to the lowest limit. I see no noticeable difference in performance, so don't mind if this is fin= ally choosen. Just be sure that you update all PMDs to set reasonable default values, or = may be even better, set UINT16_MAX in generic place - 0 is a bad default here. (Lost few seconds wondering why nothing is sent and cannot stop) Agree with you, 0 is not a good default value. I recommend 32 by default = here, of course, The driver writers Can configure it as they expect before starting to sending packets. Zhiyong