From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga09.intel.com (mga09.intel.com [134.134.136.24]) by dpdk.org (Postfix) with ESMTP id F3BF6CFBA for ; Thu, 27 Apr 2017 10:32:20 +0200 (CEST) Received: from fmsmga004.fm.intel.com ([10.253.24.48]) by orsmga102.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 27 Apr 2017 01:32:19 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.37,382,1488873600"; d="scan'208";a="254078483" Received: from fmsmsx104.amr.corp.intel.com ([10.18.124.202]) by fmsmga004.fm.intel.com with ESMTP; 27 Apr 2017 01:32:17 -0700 Received: from FMSMSX110.amr.corp.intel.com (10.18.116.10) by fmsmsx104.amr.corp.intel.com (10.18.124.202) with Microsoft SMTP Server (TLS) id 14.3.319.2; Thu, 27 Apr 2017 01:32:17 -0700 Received: from BGSMSX108.gar.corp.intel.com (10.223.4.192) by fmsmsx110.amr.corp.intel.com (10.18.116.10) with Microsoft SMTP Server (TLS) id 14.3.319.2; Thu, 27 Apr 2017 01:32:17 -0700 Received: from bgsmsx101.gar.corp.intel.com ([169.254.1.71]) by BGSMSX108.gar.corp.intel.com ([169.254.8.149]) with mapi id 14.03.0319.002; Thu, 27 Apr 2017 14:02:14 +0530 From: "Yang, Zhiyong" To: Yuanhan Liu CC: "dev@dpdk.org" , "maxime.coquelin@redhat.com" , "Loftus, Ciara" Thread-Topic: [PATCH] vhost: fix MQ fails to startup Thread-Index: AQHSvyEOq2t0gheEhkWnlgPgHtxoBaHYgXGAgABgREA= Date: Thu, 27 Apr 2017 08:32:14 +0000 Message-ID: References: <1493274893-40764-1-git-send-email-zhiyong.yang@intel.com> <20170427081203.GK11512@yliu-dev.sh.intel.com> In-Reply-To: <20170427081203.GK11512@yliu-dev.sh.intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-product: dlpe-windows dlp-version: 10.0.102.7 dlp-reaction: no-action x-originating-ip: [10.223.10.10] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH] vhost: fix MQ fails to startup X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 27 Apr 2017 08:32:21 -0000 Hi, yuanhan: > -----Original Message----- > From: Yuanhan Liu [mailto:yuanhan.liu@linux.intel.com] > Sent: Thursday, April 27, 2017 4:12 PM > To: Yang, Zhiyong > Cc: dev@dpdk.org; maxime.coquelin@redhat.com; Loftus, Ciara > > Subject: Re: [PATCH] vhost: fix MQ fails to startup >=20 > On Thu, Apr 27, 2017 at 02:34:53PM +0800, Zhiyong Yang wrote: > > vhost since dpdk17.02 + qemu2.7 and above will cause failures of new > > connection when negotiating to set MQ. (one queue pair works > > well).Because there exist some bugs in qemu code when introducing > > VHOST_USER_PROTOCOL_F_REPLY_ACK to qemu. when dealing with the > vhost > > message VHOST_USER_SET_MEM_TABLE for the second time, qemu indeed > > doesn't send the messge (The message needs to be sent only once)but > > still will be waiting for dpdk's reply ack, then, qemu is always > > freezing. DPDK code works in the right way. But the feature > > VHOST_USER_PROTOCOL_F_REPLY_ACK has to be disabled by default at the > > dpdk side in order to avoid the feature support of DPDK + qemu at the > > same time. if doing like that, MQ can works well. > ... > > Once Qemu bugs > > have been fixed and upstreamed, we can enable it. >=20 > As I have said, we should not enable it again, because there are already = few > buggy QEMU releases out. We should make sure DPDK also works well with > them. Ok. >=20 > > Fixes: 73c8f9f69c6c("vhost: introduce reply ack feature") >=20 > That commit does nothing wrong. It's QEMU being buggy. That said, I will = not > add such fixline. I will also use "workaround" instead of "fix" in the ti= tle. > Ok. I also think dpdk works in the right way. But I'm using "fix" in the ti= tle here. Your suggestion is good. =20 > Also, this patch should be backported to stable release. So, you should > add: > Cc: stable@dpdk.org >=20 Ok > Besides, please reformat you commit log a bit. For example, add space aft= er > punctuation, use paragraph as possible, etc. Ok. >=20 > > > > Reported-by: Loftus, Ciara >=20 > No "," is allowed. >=20 Ok > > Signed-off-by: Zhiyong Yang > > --- > > lib/librte_vhost/vhost_user.h | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/lib/librte_vhost/vhost_user.h > > b/lib/librte_vhost/vhost_user.h index 2ba22db..a3d2900 100644 > > --- a/lib/librte_vhost/vhost_user.h > > +++ b/lib/librte_vhost/vhost_user.h > > @@ -52,7 +52,7 @@ > > #define VHOST_USER_PROTOCOL_FEATURES ((1ULL << > VHOST_USER_PROTOCOL_F_MQ) | \ > > (1ULL << > VHOST_USER_PROTOCOL_F_LOG_SHMFD) |\ > > (1ULL << > VHOST_USER_PROTOCOL_F_RARP) | \ > > - (1ULL << > VHOST_USER_PROTOCOL_F_REPLY_ACK) | \ > > + (0ULL << > VHOST_USER_PROTOCOL_F_REPLY_ACK) | \ > > (1ULL << > VHOST_USER_PROTOCOL_F_NET_MTU)) >=20 > I think you might want to add a simple comment here, something like >=20 > /* > * disable REPLY_ACK feature to workaround the buggy QEMU > implementation. > * Proved buggy QEMU includes v2.7 - v2.9. > */ >=20 > So, please send v2? > Ok.=20 I will send it later. Zhiyong =20 > --yliu