From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga14.intel.com (mga14.intel.com [192.55.52.115]) by dpdk.org (Postfix) with ESMTP id 76821532E; Wed, 10 May 2017 04:07:14 +0200 (CEST) Received: from fmsmga003.fm.intel.com ([10.253.24.29]) by fmsmga103.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 09 May 2017 19:07:13 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.38,317,1491289200"; d="scan'208";a="854984611" Received: from fmsmsx105.amr.corp.intel.com ([10.18.124.203]) by FMSMGA003.fm.intel.com with ESMTP; 09 May 2017 19:07:13 -0700 Received: from bgsmsx106.gar.corp.intel.com (10.223.43.196) by FMSMSX105.amr.corp.intel.com (10.18.124.203) with Microsoft SMTP Server (TLS) id 14.3.319.2; Tue, 9 May 2017 19:07:12 -0700 Received: from bgsmsx101.gar.corp.intel.com ([169.254.1.71]) by BGSMSX106.gar.corp.intel.com ([169.254.1.68]) with mapi id 14.03.0319.002; Wed, 10 May 2017 07:37:10 +0530 From: "Yang, Zhiyong" To: Yuanhan Liu , Maxime Coquelin CC: "dev@dpdk.org" , "Loftus, Ciara" , "stable@dpdk.org" Thread-Topic: [PATCH v2] vhost: workaround MQ fails to startup Thread-Index: AQHSvzsfLLFM4boP6EWzME7JMB8PZ6HYn6QAgAE1sYCAEw2eMA== Date: Wed, 10 May 2017 02:07:09 +0000 Message-ID: References: <1493274893-40764-1-git-send-email-zhiyong.yang@intel.com> <1493286083-53632-1-git-send-email-zhiyong.yang@intel.com> <9dd4408d-0d01-5e44-06e9-8dca15bf18f8@redhat.com> <20170428042917.GN11512@yliu-dev.sh.intel.com> In-Reply-To: <20170428042917.GN11512@yliu-dev.sh.intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-product: dlpe-windows dlp-version: 10.0.102.7 dlp-reaction: no-action x-originating-ip: [10.223.10.10] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH v2] vhost: workaround MQ fails to startup X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 10 May 2017 02:07:15 -0000 Hi, all: The patch which is used to fix the Qemu bug has been accepted in qe= mu community. http://patchwork.ozlabs.org/patch/760118/ Thanks Zhiyong > -----Original Message----- > From: Yuanhan Liu [mailto:yuanhan.liu@linux.intel.com] > Sent: Friday, April 28, 2017 12:29 PM > To: Maxime Coquelin > Cc: Yang, Zhiyong ; dev@dpdk.org; Loftus, Ciara > ; stable@dpdk.org > Subject: Re: [PATCH v2] vhost: workaround MQ fails to startup >=20 > On Thu, Apr 27, 2017 at 12:00:52PM +0200, Maxime Coquelin wrote: > > > > > > On 04/27/2017 11:41 AM, Zhiyong Yang wrote: > > > vhost since dpdk17.02 + qemu2.7 and above will cause failures of > > >new connection when negotiating to set MQ. (one queue pair works > > >well). > > > Because there exist some bugs in qemu code when introducing > > >VHOST_USER_PROTOCOL_F_REPLY_ACK to qemu. when dealing with the > vhost > > >message VHOST_USER_SET_MEM_TABLE for the second time, qemu indeed > > >doesn't send the messge (The message needs to be sent only once)but > > >still will be waiting for dpdk's reply ack, then, qemu is always > > >freezing. DPDK code indeed works in the right way. > > > The feature VHOST_USER_PROTOCOL_F_REPLY_ACK has to be disabled by > > >default at the dpdk side in order to avoid the feature support of > > >DPDK + qemu at the same time. if doing like that, MQ can works well. > > > > > >Cc: stable@dpdk.org > > > > > >Reported-by: Ciara Loftus > > >Signed-off-by: Zhiyong Yang > > >Tested-by: Ciara Loftus > > >--- > > > > > >changes in V2 > > >1. modify "workaround" instead of "fix" in the title. > > >2. add a simple comment suggested by yuanhan > > > > > > lib/librte_vhost/vhost_user.h | 6 +++++- > > > 1 file changed, 5 insertions(+), 1 deletion(-) > > > > > > > Reviewed-by: Maxime Coquelin >=20 > Applied to dpdk-next-virtio. >=20 > Thanks. >=20 > --yliu