From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: <zhiyong.yang@intel.com> Received: from mga03.intel.com (mga03.intel.com [134.134.136.65]) by dpdk.org (Postfix) with ESMTP id C53902C19 for <dev@dpdk.org>; Fri, 4 Aug 2017 07:36:47 +0200 (CEST) Received: from fmsmga004.fm.intel.com ([10.253.24.48]) by orsmga103.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 03 Aug 2017 22:36:46 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.41,319,1498546800"; d="scan'208";a="295639860" Received: from fmsmsx105.amr.corp.intel.com ([10.18.124.203]) by fmsmga004.fm.intel.com with ESMTP; 03 Aug 2017 22:36:46 -0700 Received: from fmsmsx123.amr.corp.intel.com (10.18.125.38) by FMSMSX105.amr.corp.intel.com (10.18.124.203) with Microsoft SMTP Server (TLS) id 14.3.319.2; Thu, 3 Aug 2017 22:36:45 -0700 Received: from bgsmsx153.gar.corp.intel.com (10.224.23.4) by fmsmsx123.amr.corp.intel.com (10.18.125.38) with Microsoft SMTP Server (TLS) id 14.3.319.2; Thu, 3 Aug 2017 22:36:45 -0700 Received: from bgsmsx101.gar.corp.intel.com ([169.254.1.180]) by BGSMSX153.gar.corp.intel.com ([169.254.2.91]) with mapi id 14.03.0319.002; Fri, 4 Aug 2017 11:06:42 +0530 From: "Yang, Zhiyong" <zhiyong.yang@intel.com> To: Yuanhan Liu <yliu@fridaylinux.org> CC: "dev@dpdk.org" <dev@dpdk.org>, "Wang, Zhihong" <zhihong.wang@intel.com>, "Mcnamara, John" <john.mcnamara@intel.com>, "thomas@monjalon.net" <thomas@monjalon.net>, Olivier Matz <olivier.matz@6wind.com> Thread-Topic: [dpdk-dev] [PATCH] doc: announce API and ABI change for ethdev Thread-Index: AQHS+uS9Bhnqt4h+wUqG6hiMjRAPzKJzXGIAgAB0VIA= Date: Fri, 4 Aug 2017 05:36:42 +0000 Message-ID: <E182254E98A5DA4EB1E657AC7CB9BD2A8AEE33EC@BGSMSX101.gar.corp.intel.com> References: <20170712075846.14834-1-zhiyong.yang@intel.com> <20170804040728.GE9612@yliu-home> In-Reply-To: <20170804040728.GE9612@yliu-home> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiMTUwNjVjZjAtZTRhNS00NjEyLTkzOTItY2FhZTE3MWQxNGYwIiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX0lDIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE2LjUuOS4zIiwiVHJ1c3RlZExhYmVsSGFzaCI6Ik1oajBUM3pVZFNhZEtcL3Qybm1GZXY1V3Y2R3BKMG94NlJqZkFUaFJXRWdBPSJ9 x-ctpclassification: CTP_IC dlp-product: dlpe-windows dlp-version: 10.0.102.7 dlp-reaction: no-action x-originating-ip: [10.223.10.10] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH] doc: announce API and ABI change for ethdev X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions <dev.dpdk.org> List-Unsubscribe: <http://dpdk.org/ml/options/dev>, <mailto:dev-request@dpdk.org?subject=unsubscribe> List-Archive: <http://dpdk.org/ml/archives/dev/> List-Post: <mailto:dev@dpdk.org> List-Help: <mailto:dev-request@dpdk.org?subject=help> List-Subscribe: <http://dpdk.org/ml/listinfo/dev>, <mailto:dev-request@dpdk.org?subject=subscribe> X-List-Received-Date: Fri, 04 Aug 2017 05:36:48 -0000 Hi, yuanhan: > -----Original Message----- > From: Yuanhan Liu [mailto:yliu@fridaylinux.org] > Sent: Friday, August 4, 2017 12:07 PM > To: Yang, Zhiyong <zhiyong.yang@intel.com> > Cc: dev@dpdk.org; Wang, Zhihong <zhihong.wang@intel.com>; Mcnamara, > John <john.mcnamara@intel.com>; oilvier.matz@6wind.com; > thomas@monjalon.net > Subject: Re: [dpdk-dev] [PATCH] doc: announce API and ABI change for ethd= ev >=20 > On Wed, Jul 12, 2017 at 03:58:46PM +0800, Zhiyong Yang wrote: > > This is an API/ABI change notice for DPDK 17.11 on redefinition of >=20 > Don't put 2 whitespace char indentation here. >=20 > > port_id. port_id is defined as uint8_t by now, which is just ranged > > from 0 to 255. For more and more scenerioes, more than 256 devices are > > needed to support for vdev scalability. > > > > It is necessary for redefinition of port_id to extend from 1 bytes > > to 2 bytes. All ethdev APIs and use cases related to port_id will be > > changed at the same time. > > > > Signed-off-by: Zhiyong Yang <zhiyong.yang@intel.com> > > --- > > doc/guides/rel_notes/deprecation.rst | 4 ++++ > > 1 file changed, 4 insertions(+) > > > > diff --git a/doc/guides/rel_notes/deprecation.rst > > b/doc/guides/rel_notes/deprecation.rst > > index 257dcba..f265980 100644 > > --- a/doc/guides/rel_notes/deprecation.rst > > +++ b/doc/guides/rel_notes/deprecation.rst > > @@ -54,6 +54,10 @@ Deprecation Notices > > Target release for removal of the legacy API will be defined once mo= st > > PMDs have switched to rte_flow. > > > > +* ABI/API changes are planned for 17.11 in the "rte_eth_dev_data" stru= cture. >=20 > That's for ABI only and you missed the API part. Meaning, you need also m= ention > that all APIs have port_id parameter will be changed too. >=20 > Also, rte_eth_dev_data is not the only structure has ABI changes. There a= re few > more (for instance, rte_port_ethdev.h). As said before, you don't have to= list all > of them, but at least you should not list one example only as it seems th= at's the > only structure has ABI change. >=20 > > + Change the definition of port_id from 8bits to 16bits in order to > > + support more than 256 devices in DPDK. >=20 > 8bits -> 8 bits. You might want to reword it further. Besides that, this = change is > indeed needed. Thus, >=20 > Acked-by: Yuanhan Liu <yliu@fridaylinux.org> >=20 > --yliu Thank you, yuanhan. I have reworded and sent v2 according to your comments= . Zhiyong Yang > > + > > * librte_table: The ``key_mask`` parameter will be added to all the ha= sh tables > > that currently do not have it, as well as to the hash compute functi= on > prototype. > > The non-"do-sig" versions of the hash tables will be removed > > -- > > 2.9.3