From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga04.intel.com (mga04.intel.com [192.55.52.120]) by dpdk.org (Postfix) with ESMTP id 2C1DB376C for ; Mon, 4 Sep 2017 16:18:40 +0200 (CEST) Received: from orsmga005.jf.intel.com ([10.7.209.41]) by fmsmga104.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 04 Sep 2017 07:18:39 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.41,475,1498546800"; d="scan'208";a="145309927" Received: from fmsmsx108.amr.corp.intel.com ([10.18.124.206]) by orsmga005.jf.intel.com with ESMTP; 04 Sep 2017 07:18:39 -0700 Received: from fmsmsx115.amr.corp.intel.com (10.18.116.19) by FMSMSX108.amr.corp.intel.com (10.18.124.206) with Microsoft SMTP Server (TLS) id 14.3.319.2; Mon, 4 Sep 2017 07:18:39 -0700 Received: from bgsmsx106.gar.corp.intel.com (10.223.43.196) by fmsmsx115.amr.corp.intel.com (10.18.116.19) with Microsoft SMTP Server (TLS) id 14.3.319.2; Mon, 4 Sep 2017 07:18:39 -0700 Received: from bgsmsx101.gar.corp.intel.com ([169.254.1.62]) by BGSMSX106.gar.corp.intel.com ([10.223.43.196]) with mapi id 14.03.0319.002; Mon, 4 Sep 2017 19:48:35 +0530 From: "Yang, Zhiyong" To: "Ananyev, Konstantin" , "Richardson, Bruce" CC: "Yao, Lei A" , "dev@dpdk.org" , "thomas@monjalon.net" , "Yigit, Ferruh" , "Wiles, Keith" , "stephen@networkplumber.org" Thread-Topic: [dpdk-dev] [PATCH v2 3/4] common_base: extend RTE_MAX_ETHPORTS from 32 to 1024 Thread-Index: AQHTJVHiJfsn2VqxlESVHPjzzVa456KkW9wg//+4NICAAGb48P//rtsAgACYfFA= Date: Mon, 4 Sep 2017 14:18:34 +0000 Message-ID: References: <20170809084203.17562-1-zhiyong.yang@intel.com> <20170904055734.21354-1-zhiyong.yang@intel.com> <20170904055734.21354-4-zhiyong.yang@intel.com> <2DBBFF226F7CF64BAFCA79B681719D953A266703@shsmsx102.ccr.corp.intel.com> <20170904090903.GB17464@bricha3-MOBL3.ger.corp.intel.com> <2601191342CEEE43887BDE71AB9772584F244EC0@irsmsx105.ger.corp.intel.com> In-Reply-To: <2601191342CEEE43887BDE71AB9772584F244EC0@irsmsx105.ger.corp.intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiMTllZmUxYTAtZDk3Yy00ZTJiLTk4OWItMzBlNGE1YTkwNWRkIiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX0lDIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE2LjUuOS4zIiwiVHJ1c3RlZExhYmVsSGFzaCI6ImZRZHV0RG42VkV2cWdqQzFcL21HejR3NDVlK0JEb3ZySW5QaVBaUExZaG9NPSJ9 x-ctpclassification: CTP_IC dlp-product: dlpe-windows dlp-version: 11.0.0.116 dlp-reaction: no-action x-originating-ip: [10.223.10.10] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH v2 3/4] common_base: extend RTE_MAX_ETHPORTS from 32 to 1024 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 04 Sep 2017 14:18:41 -0000 Hi, konstantin: > > > It should be possible to have a dynamically allocated ethdev array, > > > which would allow use to have a default value - which could be e.g. > > > 32 or 64 as now - while also allowing a run-time parameter to increas= e that > to thousands if needed. > > > > > > /Bruce > > > > In testpmd, the following function will be called to validate the port= _id. > > So, It is necessary to modify the max port num RTE_MAX_ETHPORTS. >=20 > There are quite a lot memory allocations (both static an dynamic) inside = DPDK > libs and sample apps that use RTE_MAX_ETHPORTS. > Increasing RTE_MAX_ETHPORTS would increase DPDK memory requirements > quite significantly. > Why do you think it is *necessary* to increase default RTE_MAX_ETHPORTS t= o > 1024? > Konstantin One reason is that some users have the requirement of more than 32 ports no= w. But it need to reconfigure and recompile dpdk.=20 Another reason is that validating team doesn't modify the common_base when doing regression test. But they need to validate if uint16_t port_id can wo= rk. Bruce suggests to pass parameter and dynamically allocate ethdev array at r= un time. It is another method. I'm thinking about it.=20 Thanks Zhiyong