From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga06.intel.com (mga06.intel.com [134.134.136.31]) by dpdk.org (Postfix) with ESMTP id 3F9C02882 for ; Thu, 19 Oct 2017 02:55:46 +0200 (CEST) Received: from fmsmga005.fm.intel.com ([10.253.24.32]) by orsmga104.jf.intel.com with ESMTP; 18 Oct 2017 17:55:44 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.43,398,1503385200"; d="scan'208";a="164295974" Received: from fmsmsx108.amr.corp.intel.com ([10.18.124.206]) by fmsmga005.fm.intel.com with ESMTP; 18 Oct 2017 17:55:44 -0700 Received: from FMSMSX110.amr.corp.intel.com (10.18.116.10) by FMSMSX108.amr.corp.intel.com (10.18.124.206) with Microsoft SMTP Server (TLS) id 14.3.319.2; Wed, 18 Oct 2017 17:55:44 -0700 Received: from bgsmsx102.gar.corp.intel.com (10.223.4.172) by fmsmsx110.amr.corp.intel.com (10.18.116.10) with Microsoft SMTP Server (TLS) id 14.3.319.2; Wed, 18 Oct 2017 17:55:44 -0700 Received: from bgsmsx101.gar.corp.intel.com ([169.254.1.200]) by BGSMSX102.gar.corp.intel.com ([169.254.2.11]) with mapi id 14.03.0319.002; Thu, 19 Oct 2017 06:25:41 +0530 From: "Yang, Zhiyong" To: "De Lara Guarch, Pablo" , "dev@dpdk.org" CC: "Yigit, Ferruh" Thread-Topic: [dpdk-dev] [PATCH] examples/l2fwd-crypto: fix port id type Thread-Index: AQHTR/aQZ+Q/hgeG4UyGg4PuG7yCWqLpOMmAgAEgwfA= Date: Thu, 19 Oct 2017 00:55:40 +0000 Message-ID: References: <20171018095019.42807-1-zhiyong.yang@intel.com> In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiYjAyODQ0Y2YtZGIxYi00OTljLWE5NTItM2MxYTJkM2FjMDEyIiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX0lDIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE2LjUuOS4zIiwiVHJ1c3RlZExhYmVsSGFzaCI6IjI5XC9URTdPVmlucXJrNTI2OFlhTnMzUzVvQUxzSU9vRFJQRFkxN2ZneURNPSJ9 x-ctpclassification: CTP_IC dlp-product: dlpe-windows dlp-version: 11.0.0.116 dlp-reaction: no-action x-originating-ip: [10.223.10.10] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH] examples/l2fwd-crypto: fix port id type X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 19 Oct 2017 00:55:46 -0000 Hi Pablo, > -----Original Message----- > From: De Lara Guarch, Pablo > Sent: Wednesday, October 18, 2017 9:10 PM > To: Yang, Zhiyong ; dev@dpdk.org > Cc: Yigit, Ferruh ; Yang, Zhiyong > > Subject: RE: [dpdk-dev] [PATCH] examples/l2fwd-crypto: fix port id type >=20 > Hi Zhiyong, >=20 > > -----Original Message----- > > From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Zhiyong Yang > > Sent: Wednesday, October 18, 2017 10:50 AM > > To: dev@dpdk.org > > Cc: Yigit, Ferruh ; Yang, Zhiyong > > > > Subject: [dpdk-dev] [PATCH] examples/l2fwd-crypto: fix port id type > > > > Fix port id issue and remove unnecessary cast. > > > > Fixes: f8244c6399d9 ("ethdev: increase port id range") > > Signed-off-by: Zhiyong Yang >=20 > Actually, I think we can extend this patch to declare all variables relat= ed to port > ids to uint16_t. > I have seen the following: "l2fwd_dst_ports", "portid", "dest_portid", "d= st_port". >=20 > Rest of the patch looks good to me, so you can keep the ack if you are do= ing a > v2. >=20 > Acked-by: Pablo de Lara >=20 Thanks for your review and acked by. I can do as you comment in V2. zhiyong