From: "Yang, Zhiyong" <zhiyong.yang@intel.com>
To: "dev@dpdk.org" <dev@dpdk.org>
Cc: "yliu@fridaylinux.org" <yliu@fridaylinux.org>,
"maxime.coquelin@redhat.com" <maxime.coquelin@redhat.com>,
"stable@dpdk.org" <stable@dpdk.org>
Subject: Re: [dpdk-dev] [PATCH] net/virtio: fix wrong use_msix value for legacy device
Date: Thu, 28 Dec 2017 06:21:15 +0000 [thread overview]
Message-ID: <E182254E98A5DA4EB1E657AC7CB9BD2A8B01C73D@BGSMSX101.gar.corp.intel.com> (raw)
In-Reply-To: <20171227100925.12953-1-zhiyong.yang@intel.com>
Self Nack.
Another patch has been sent out to fix testpmd startup failure issue using uio_pci_generic on virtio legacy device.
http://www.dpdk.org/dev/patchwork/patch/32779/
> -----Original Message-----
> From: Yang, Zhiyong
> Sent: Wednesday, December 27, 2017 6:09 PM
> To: dev@dpdk.org
> Cc: yliu@fridaylinux.org; maxime.coquelin@redhat.com; stable@dpdk.org; Yang,
> Zhiyong <zhiyong.yang@intel.com>
> Subject: [PATCH] net/virtio: fix wrong use_msix value for legacy device
>
> If virtio fails to detect modern device, use_misx should be reset to
> VIRTIO_MSIX_NONE, otherwise this wrong value will be used after legacy device
> detection succeeds to be done.
>
> Fixes: fe19d49cb525 ("net/virtio: fix Rx interrupt with VFIO")
> Cc: stable@dpdk.org
> Signed-off-by: Zhiyong Yang <zhiyong.yang@intel.com>
> ---
> drivers/net/virtio/virtio_pci.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/net/virtio/virtio_pci.c b/drivers/net/virtio/virtio_pci.c index
> 9574498fb..5582238fd 100644
> --- a/drivers/net/virtio/virtio_pci.c
> +++ b/drivers/net/virtio/virtio_pci.c
> @@ -695,6 +695,7 @@ vtpci_init(struct rte_pci_device *dev, struct virtio_hw
> *hw)
> return 0;
> }
>
> + hw->use_msix = VIRTIO_MSIX_NONE;
> PMD_INIT_LOG(INFO, "trying with legacy virtio pci.");
> if (rte_pci_ioport_map(dev, 0, VTPCI_IO(hw)) < 0) {
> if (dev->kdrv == RTE_KDRV_UNKNOWN &&
> --
> 2.13.3
prev parent reply other threads:[~2017-12-28 6:21 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-12-27 10:09 Zhiyong Yang
2017-12-28 6:21 ` Yang, Zhiyong [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=E182254E98A5DA4EB1E657AC7CB9BD2A8B01C73D@BGSMSX101.gar.corp.intel.com \
--to=zhiyong.yang@intel.com \
--cc=dev@dpdk.org \
--cc=maxime.coquelin@redhat.com \
--cc=stable@dpdk.org \
--cc=yliu@fridaylinux.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).