From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga09.intel.com (mga09.intel.com [134.134.136.24]) by dpdk.org (Postfix) with ESMTP id 56F1F1B53; Thu, 28 Dec 2017 07:21:20 +0100 (CET) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga004.jf.intel.com ([10.7.209.38]) by orsmga102.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 27 Dec 2017 22:21:19 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.45,469,1508828400"; d="scan'208";a="162267642" Received: from fmsmsx105.amr.corp.intel.com ([10.18.124.203]) by orsmga004.jf.intel.com with ESMTP; 27 Dec 2017 22:21:19 -0800 Received: from fmsmsx158.amr.corp.intel.com (10.18.116.75) by FMSMSX105.amr.corp.intel.com (10.18.124.203) with Microsoft SMTP Server (TLS) id 14.3.319.2; Wed, 27 Dec 2017 22:21:19 -0800 Received: from bgsmsx151.gar.corp.intel.com (10.224.48.42) by fmsmsx158.amr.corp.intel.com (10.18.116.75) with Microsoft SMTP Server (TLS) id 14.3.319.2; Wed, 27 Dec 2017 22:21:19 -0800 Received: from bgsmsx101.gar.corp.intel.com ([169.254.1.245]) by BGSMSX151.gar.corp.intel.com ([169.254.3.14]) with mapi id 14.03.0319.002; Thu, 28 Dec 2017 11:51:16 +0530 From: "Yang, Zhiyong" To: "dev@dpdk.org" CC: "yliu@fridaylinux.org" , "maxime.coquelin@redhat.com" , "stable@dpdk.org" Thread-Topic: [PATCH] net/virtio: fix wrong use_msix value for legacy device Thread-Index: AQHTfvrNfSyxnGvr1UKBb9OpIemqaaNYSHIQ Date: Thu, 28 Dec 2017 06:21:15 +0000 Message-ID: References: <20171227100925.12953-1-zhiyong.yang@intel.com> In-Reply-To: <20171227100925.12953-1-zhiyong.yang@intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-product: dlpe-windows dlp-version: 11.0.0.116 dlp-reaction: no-action x-originating-ip: [10.223.10.10] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH] net/virtio: fix wrong use_msix value for legacy device X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 28 Dec 2017 06:21:22 -0000 Self Nack.=20 Another patch has been sent out to fix testpmd startup failure issue using = uio_pci_generic on virtio legacy device. http://www.dpdk.org/dev/patchwork/patch/32779/ > -----Original Message----- > From: Yang, Zhiyong > Sent: Wednesday, December 27, 2017 6:09 PM > To: dev@dpdk.org > Cc: yliu@fridaylinux.org; maxime.coquelin@redhat.com; stable@dpdk.org; Ya= ng, > Zhiyong > Subject: [PATCH] net/virtio: fix wrong use_msix value for legacy device >=20 > If virtio fails to detect modern device, use_misx should be reset to > VIRTIO_MSIX_NONE, otherwise this wrong value will be used after legacy de= vice > detection succeeds to be done. >=20 > Fixes: fe19d49cb525 ("net/virtio: fix Rx interrupt with VFIO") > Cc: stable@dpdk.org > Signed-off-by: Zhiyong Yang > --- > drivers/net/virtio/virtio_pci.c | 1 + > 1 file changed, 1 insertion(+) >=20 > diff --git a/drivers/net/virtio/virtio_pci.c b/drivers/net/virtio/virtio_= pci.c index > 9574498fb..5582238fd 100644 > --- a/drivers/net/virtio/virtio_pci.c > +++ b/drivers/net/virtio/virtio_pci.c > @@ -695,6 +695,7 @@ vtpci_init(struct rte_pci_device *dev, struct virtio_= hw > *hw) > return 0; > } >=20 > + hw->use_msix =3D VIRTIO_MSIX_NONE; > PMD_INIT_LOG(INFO, "trying with legacy virtio pci."); > if (rte_pci_ioport_map(dev, 0, VTPCI_IO(hw)) < 0) { > if (dev->kdrv =3D=3D RTE_KDRV_UNKNOWN && > -- > 2.13.3