From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga04.intel.com (mga04.intel.com [192.55.52.120]) by dpdk.org (Postfix) with ESMTP id 63FF61B01F; Wed, 10 Jan 2018 02:26:51 +0100 (CET) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga006.fm.intel.com ([10.253.24.20]) by fmsmga104.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 09 Jan 2018 17:26:50 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.46,337,1511856000"; d="scan'208";a="193708423" Received: from fmsmsx104.amr.corp.intel.com ([10.18.124.202]) by fmsmga006.fm.intel.com with ESMTP; 09 Jan 2018 17:26:50 -0800 Received: from fmsmsx119.amr.corp.intel.com (10.18.124.207) by fmsmsx104.amr.corp.intel.com (10.18.124.202) with Microsoft SMTP Server (TLS) id 14.3.319.2; Tue, 9 Jan 2018 17:26:50 -0800 Received: from bgsmsx153.gar.corp.intel.com (10.224.23.4) by FMSMSX119.amr.corp.intel.com (10.18.124.207) with Microsoft SMTP Server (TLS) id 14.3.319.2; Tue, 9 Jan 2018 17:26:49 -0800 Received: from bgsmsx101.gar.corp.intel.com ([169.254.1.245]) by BGSMSX153.gar.corp.intel.com ([10.224.23.4]) with mapi id 14.03.0319.002; Wed, 10 Jan 2018 06:56:47 +0530 From: "Yang, Zhiyong" To: Yuanhan Liu CC: "dev@dpdk.org" , "stable@dpdk.org" Thread-Topic: [dpdk-dev] [PATCH] examples/vhost: fix extend MAX_QUEUES to resolve startup failure Thread-Index: AQHThSX6uxjJWdhdA0yuSbk4KCm4nKNrM6mAgAElOIA= Date: Wed, 10 Jan 2018 01:26:46 +0000 Message-ID: References: <20180104063332.5248-1-zhiyong.yang@intel.com> <20180109132347.GL29540@yliu-mob> In-Reply-To: <20180109132347.GL29540@yliu-mob> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-product: dlpe-windows dlp-version: 11.0.0.116 dlp-reaction: no-action x-originating-ip: [10.223.10.10] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH] examples/vhost: fix extend MAX_QUEUES to resolve startup failure X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 10 Jan 2018 01:26:51 -0000 Yuanhan, > -----Original Message----- > From: Yuanhan Liu [mailto:yliu@fridaylinux.org] > Sent: Tuesday, January 9, 2018 9:24 PM > To: Yang, Zhiyong > Cc: dev@dpdk.org; stable@dpdk.org > Subject: Re: [dpdk-dev] [PATCH] examples/vhost: fix extend MAX_QUEUES > to resolve startup failure >=20 > On Thu, Jan 04, 2018 at 02:33:32PM +0800, Zhiyong Yang wrote: > > When binding X710 NIC (i40e driver) to DPDK, vhost sample startups > > failure. > > The sample requires that MAX_QUEUES should be defined no less than 320. > > So, the patch redefines MAX_QUEUES 320 to fix the issue. >=20 > It just makes the issue disappear. It doesn't really fix the issue. > And I belive we have tried to fix this kind of issues in this way many ti= mes. > (just check the git history). As you known, none of them really worked. Y= ou > just added one more try, which is very likely will be broken again when I= ntel > has one more new NIC. >=20 > The error comes from: >=20 > if (dev_info.max_rx_queues > MAX_QUEUES) { > rte_exit(EXIT_FAILURE, > "please define MAX_QUEUES no less than %u in %s\n= ", > dev_info.max_rx_queues, __FILE__); > } >=20 > I think such check is overkill and we don't really need that. Could you j= ust > remove such check and do some validations on few difference nics? >=20 Agreed, Such check doesn't help anything, Let me send V2 to remove it if no= thing can be affected. Thanks Zhiyong > Thanks. >=20 > --yliu