From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga09.intel.com (mga09.intel.com [134.134.136.24]) by dpdk.org (Postfix) with ESMTP id 295823250 for ; Fri, 12 Jan 2018 11:56:13 +0100 (CET) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga003.jf.intel.com ([10.7.209.27]) by orsmga102.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 12 Jan 2018 02:56:12 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.46,348,1511856000"; d="scan'208";a="19546922" Received: from fmsmsx104.amr.corp.intel.com ([10.18.124.202]) by orsmga003.jf.intel.com with ESMTP; 12 Jan 2018 02:56:12 -0800 Received: from fmsmsx153.amr.corp.intel.com (10.18.125.6) by fmsmsx104.amr.corp.intel.com (10.18.124.202) with Microsoft SMTP Server (TLS) id 14.3.319.2; Fri, 12 Jan 2018 02:56:12 -0800 Received: from bgsmsx105.gar.corp.intel.com (10.223.43.197) by FMSMSX153.amr.corp.intel.com (10.18.125.6) with Microsoft SMTP Server (TLS) id 14.3.319.2; Fri, 12 Jan 2018 02:56:12 -0800 Received: from bgsmsx101.gar.corp.intel.com ([169.254.1.245]) by BGSMSX105.gar.corp.intel.com ([169.254.3.4]) with mapi id 14.03.0319.002; Fri, 12 Jan 2018 16:26:09 +0530 From: "Yang, Zhiyong" To: "Kovacevic, Marko" , "dev@dpdk.org" CC: "Mcnamara, John" Thread-Topic: [dpdk-dev] [PATCH] doc: fix link bonding pmd typo in prog guide Thread-Index: AQHTgG7UHiGGs/kCzUWgweHw5roEO6NvtNaAgABxzxA= Date: Fri, 12 Jan 2018 10:56:08 +0000 Message-ID: References: <20171229063220.11221-1-zhiyong.yang@intel.com> <6DC05C7C5F25994B81B3F2F214251F66331A92@IRSMSX104.ger.corp.intel.com> In-Reply-To: <6DC05C7C5F25994B81B3F2F214251F66331A92@IRSMSX104.ger.corp.intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-product: dlpe-windows dlp-version: 11.0.0.116 dlp-reaction: no-action x-originating-ip: [10.223.10.10] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH] doc: fix link bonding pmd typo in prog guide X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 12 Jan 2018 10:56:14 -0000 Thanks Marko,=20 Fix the issues according to your comments. V2 has been sent out. Thanks Zhiyong > -----Original Message----- > From: Kovacevic, Marko > Sent: Friday, January 12, 2018 5:37 PM > To: Yang, Zhiyong ; dev@dpdk.org > Cc: Mcnamara, John > Subject: RE: [dpdk-dev] [PATCH] doc: fix link bonding pmd typo in prog gu= ide >=20 > > fix one typo and a grammatical mistake. > > > > Fixes: b0152b1b40fe("doc: update bonding") > > Signed-off-by: Zhiyong Yang >=20 > First thing the git check log spit this error out so can you please just = make > these changes >=20 > Running git check log on HEAD~1: 32787 > =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D > Wrong headline lowercase: > doc: fix link bonding pmd typo in prog guide Wrong tag: > ^^^^ > Upper case PMD >=20 > Fixes: b0152b1b40fe("doc: update bonding") Wrong 'Fixes' reference: > Fixes: b0152b1b40fe("doc: update bonding") > ^^ > Insert a space..... Fixes: b0152b1b40fe ("doc: update bonding") >=20 > Is it candidate for Cc: stable@dpdk.org backport? > If it is Cc: the stable mailing list in the commit message body >=20 > I don't think this is really an error but put a space between Fixes And S= igned - > off-by >=20 > > Fixes: b0152b1b40fe("doc: update bonding") > > Signed-off-by: Zhiyong Yang >=20 >=20 > <...> >=20 > > > > The Link Bonding PMD library(librte_pmd_bond) supports bonding of > > groups of ``rte_eth_dev`` ports of the same speed and duplex to > > provide -similar the capabilities to that found in Linux bonding > > driver to allow the > ^^^^^^^^^^^^^^^^^^^^^^^^^^ > "to provide the similar capabilities" sounds better to me >=20 > > +the capabilities similar to that found in Linux bonding driver to > > +allow the > > aggregation of multiple (slave) NICs into a single logical interface > > between a server and a switch. The new bonded PMD will then process > > these interfaces based on the mode of operation specified to provide > > support for features such >=20 > Once this has been changed you can include my Ack in the next version of > the patch. >=20 > Acked-by: Marko Kovacevic