From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga12.intel.com (mga12.intel.com [192.55.52.136]) by dpdk.org (Postfix) with ESMTP id C12A22C2E for ; Tue, 16 Jan 2018 01:57:13 +0100 (CET) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga007.fm.intel.com ([10.253.24.52]) by fmsmga106.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 15 Jan 2018 16:57:12 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.46,366,1511856000"; d="scan'208";a="10490422" Received: from fmsmsx108.amr.corp.intel.com ([10.18.124.206]) by fmsmga007.fm.intel.com with ESMTP; 15 Jan 2018 16:57:10 -0800 Received: from fmsmsx156.amr.corp.intel.com (10.18.116.74) by FMSMSX108.amr.corp.intel.com (10.18.124.206) with Microsoft SMTP Server (TLS) id 14.3.319.2; Mon, 15 Jan 2018 16:57:10 -0800 Received: from bgsmsx106.gar.corp.intel.com (10.223.43.196) by fmsmsx156.amr.corp.intel.com (10.18.116.74) with Microsoft SMTP Server (TLS) id 14.3.319.2; Mon, 15 Jan 2018 16:57:10 -0800 Received: from bgsmsx101.gar.corp.intel.com ([169.254.1.245]) by BGSMSX106.gar.corp.intel.com ([169.254.1.105]) with mapi id 14.03.0319.002; Tue, 16 Jan 2018 06:27:07 +0530 From: "Yang, Zhiyong" To: "Chen, Junjie J" , "yliu@fridaylinux.org" , "maxime.coquelin@redhat.com" CC: "dev@dpdk.org" Thread-Topic: [dpdk-dev] [PATCH] vhost: do deep copy while reallocate vq Thread-Index: AQHTjbQ/5KsxoduuNUyWcernZcX9X6N0oo6Q//+oaYCAAVyD8A== Date: Tue, 16 Jan 2018 00:57:06 +0000 Message-ID: References: <1516015939-11266-1-git-send-email-junjie.j.chen@intel.com> In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-product: dlpe-windows dlp-version: 11.0.0.116 dlp-reaction: no-action x-originating-ip: [10.223.10.10] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH] vhost: do deep copy while reallocate vq X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 16 Jan 2018 00:57:14 -0000 > -----Original Message----- > From: Chen, Junjie J > Sent: Monday, January 15, 2018 5:15 PM > To: Yang, Zhiyong ; yliu@fridaylinux.org; > maxime.coquelin@redhat.com > Cc: dev@dpdk.org > Subject: RE: [dpdk-dev] [PATCH] vhost: do deep copy while reallocate vq >=20 > Hi >=20 > > > @@ -227,6 +227,7 @@ vhost_user_set_vring_num(struct virtio_net *dev, > > > "zero copy is force disabled\n"); > > > dev->dequeue_zero_copy =3D 0; > > > } > > > + TAILQ_INIT(&vq->zmbuf_list); > > > } > > > > > > vq->shadow_used_ring =3D rte_malloc(NULL, @@ -261,6 +262,9 @@ > > > numa_realloc(struct virtio_net *dev, int index) > > > int oldnode, newnode; > > > struct virtio_net *old_dev; > > > struct vhost_virtqueue *old_vq, *vq; > > > + struct zcopy_mbuf *new_zmbuf; > > > + struct vring_used_elem *new_shadow_used_ring; > > > + struct batch_copy_elem *new_batch_copy_elems; > > > int ret; > > > > > > old_dev =3D dev; > > > @@ -285,6 +289,33 @@ numa_realloc(struct virtio_net *dev, int index) > > > return dev; > > > > > > memcpy(vq, old_vq, sizeof(*vq)); > > > + TAILQ_INIT(&vq->zmbuf_list); > > > + > > > + new_zmbuf =3D rte_malloc_socket(NULL, vq->zmbuf_size * > > > + sizeof(struct zcopy_mbuf), 0, newnode); > > > + if (new_zmbuf) { > > > + rte_free(vq->zmbufs); > > > + vq->zmbufs =3D new_zmbuf; > > > + } > > > > You need to consider how to handle the case ( rte_malloc_socket > > return NULL). >=20 > If it failed to allocate new_zmbuf, it uses old zmbufs, so as to keep vho= st > alive. It sounds reasonable, another question is,=20 for the 3 blocks of memory being allocated, If some succeed , others fails= , Does it mean that the code will run on different socket? What's the perf impact if it happen= s. thanks Zhiyong