From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga09.intel.com (mga09.intel.com [134.134.136.24]) by dpdk.org (Postfix) with ESMTP id 2BC4625B3 for ; Thu, 25 Jan 2018 07:02:50 +0100 (CET) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga007.jf.intel.com ([10.7.209.58]) by orsmga102.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 24 Jan 2018 22:02:49 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.46,409,1511856000"; d="scan'208";a="12453655" Received: from fmsmsx106.amr.corp.intel.com ([10.18.124.204]) by orsmga007.jf.intel.com with ESMTP; 24 Jan 2018 22:02:49 -0800 Received: from fmsmsx158.amr.corp.intel.com (10.18.116.75) by FMSMSX106.amr.corp.intel.com (10.18.124.204) with Microsoft SMTP Server (TLS) id 14.3.319.2; Wed, 24 Jan 2018 22:02:49 -0800 Received: from BGSMSX107.gar.corp.intel.com (10.223.4.191) by fmsmsx158.amr.corp.intel.com (10.18.116.75) with Microsoft SMTP Server (TLS) id 14.3.319.2; Wed, 24 Jan 2018 22:02:49 -0800 Received: from bgsmsx101.gar.corp.intel.com ([169.254.1.245]) by BGSMSX107.gar.corp.intel.com ([169.254.9.78]) with mapi id 14.03.0319.002; Thu, 25 Jan 2018 11:32:46 +0530 From: "Yang, Zhiyong" To: "Zhang, Qi Z" , "Xing, Beilei" CC: "dev@dpdk.org" , "Zhao1, Wei" , "Zhang, Qi Z" Thread-Topic: [dpdk-dev] [PATCH] net/i40e: fix bug in RSS flow action parser Thread-Index: AQHTlZrz1OzKvw2ZO0iKgSeNhfCSTKOEFz+Q Date: Thu, 25 Jan 2018 06:02:45 +0000 Message-ID: References: <20180125051033.40453-1-qi.z.zhang@intel.com> In-Reply-To: <20180125051033.40453-1-qi.z.zhang@intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-product: dlpe-windows dlp-version: 11.0.0.116 dlp-reaction: no-action x-originating-ip: [10.223.10.10] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH] net/i40e: fix bug in RSS flow action parser X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 25 Jan 2018 06:02:51 -0000 Hi Qi, > -----Original Message----- > From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Qi Zhang > Sent: Thursday, January 25, 2018 1:11 PM > To: Xing, Beilei > Cc: dev@dpdk.org; Zhao1, Wei ; Zhang, Qi Z > > Subject: [dpdk-dev] [PATCH] net/i40e: fix bug in RSS flow action parser >=20 > Parameter action_flag is not used correctly in i40e_flow_parse_rss_action= . > Also change it from point type to value type since it is not an output > parameter. >=20 > Fixes: ecad87d22383e ("net/i40e: move RSS to flow API") >=20 > Signed-off-by: Qi Zhang > --- > drivers/net/i40e/i40e_flow.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) >=20 > diff --git a/drivers/net/i40e/i40e_flow.c b/drivers/net/i40e/i40e_flow.c > index a74fa08ab..74708f168 100644 > --- a/drivers/net/i40e/i40e_flow.c > +++ b/drivers/net/i40e/i40e_flow.c > @@ -4188,7 +4188,7 @@ static int > i40e_flow_parse_rss_action(struct rte_eth_dev *dev, > const struct rte_flow_action *actions, > struct rte_flow_error *error, > - uint8_t *action_flag, > + uint8_t action_flag, > struct i40e_queue_regions *conf_info, > union i40e_filter_t *filter) > { > @@ -4378,7 +4378,7 @@ i40e_parse_rss_filter(struct rte_eth_dev *dev, > return ret; >=20 > ret =3D i40e_flow_parse_rss_action(dev, actions, error, > - &action_flag, &info, filter); > + action_flag, &info, filter); I wonder if action_flag =3D=3D ture targets to handle only the case RTE_= FLOW_ITEM_TYPE_ETH ? Thanks Zhiyong > if (ret) > return ret; >=20 > -- > 2.13.6