From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga06.intel.com (mga06.intel.com [134.134.136.31]) by dpdk.org (Postfix) with ESMTP id C30573256; Wed, 28 Mar 2018 09:49:14 +0200 (CEST) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga004.fm.intel.com ([10.253.24.48]) by orsmga104.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 28 Mar 2018 00:48:51 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.48,370,1517904000"; d="scan'208";a="41344712" Received: from fmsmsx104.amr.corp.intel.com ([10.18.124.202]) by fmsmga004.fm.intel.com with ESMTP; 28 Mar 2018 00:48:51 -0700 Received: from fmsmsx111.amr.corp.intel.com (10.18.116.5) by fmsmsx104.amr.corp.intel.com (10.18.124.202) with Microsoft SMTP Server (TLS) id 14.3.319.2; Wed, 28 Mar 2018 00:48:50 -0700 Received: from bgsmsx151.gar.corp.intel.com (10.224.48.42) by fmsmsx111.amr.corp.intel.com (10.18.116.5) with Microsoft SMTP Server (TLS) id 14.3.319.2; Wed, 28 Mar 2018 00:48:50 -0700 Received: from bgsmsx101.gar.corp.intel.com ([169.254.1.233]) by BGSMSX151.gar.corp.intel.com ([169.254.3.220]) with mapi id 14.03.0319.002; Wed, 28 Mar 2018 13:18:47 +0530 From: "Yang, Zhiyong" To: "Tan, Jianfeng" , "dev@dpdk.org" CC: "Wang, Zhihong" , "maxime.coquelin@redhat.com" , "thomas@monjalon.net" , "Wang, Dong1" , "Bie, Tiwei" , "stable@dpdk.org" Thread-Topic: [PATCH v3 1/4] net/virtio: fix add pointer checking Thread-Index: AQHTwMFCJMO7Ol4gF0W2eWx0ehAo0qPk7mUAgABhUmA= Date: Wed, 28 Mar 2018 07:48:46 +0000 Message-ID: References: <20180214145330.4679-1-zhiyong.yang@intel.com> <20180321030343.64399-1-zhiyong.yang@intel.com> <20180321030343.64399-2-zhiyong.yang@intel.com> <7f1021a3-b625-687d-ca13-9a289be8a1f3@intel.com> In-Reply-To: <7f1021a3-b625-687d-ca13-9a289be8a1f3@intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-product: dlpe-windows dlp-version: 11.0.0.116 dlp-reaction: no-action x-originating-ip: [10.223.10.10] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH v3 1/4] net/virtio: fix add pointer checking X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 28 Mar 2018 07:49:16 -0000 > -----Original Message----- > From: Tan, Jianfeng > Sent: Wednesday, March 28, 2018 3:26 PM > To: Yang, Zhiyong ; dev@dpdk.org > Cc: Wang, Zhihong ; > maxime.coquelin@redhat.com; thomas@monjalon.net; Wang, Dong1 > ; Bie, Tiwei ; > stable@dpdk.org > Subject: Re: [PATCH v3 1/4] net/virtio: fix add pointer checking >=20 >=20 >=20 > On 3/21/2018 11:03 AM, zhiyong.yang@intel.com wrote: > > It is necessary to add pointer checking because in some case the code > > will cause crash. For example, the code goes here before memory > > allocation of rxvq is finished. > > > > Fixes: 7365504f77e3("net/virtio: support guest announce") > > Cc: stable@dpdk.org > > Signed-off-by: Zhiyong Yang >=20 > This fix is not related to the topic of this patch series, correct? > Maybe next time, we can put it out of the patch series. >=20 > Reviewed-by: Jianfeng Tan >=20 > Thanks, > Jianfeng >=20 Thanks for Jianfeng's review. The bug must be fixed firstly in order=20 that code can go in the right way for virito-user server mode patch. :) Thanks Zhiyong