From: "Yang, Zhiyong" <zhiyong.yang@intel.com>
To: Pavan Nikhilesh <pbhagavatula@caviumnetworks.com>,
"jerin.jacob@caviumnetworks.com" <jerin.jacob@caviumnetworks.com>,
"Yigit, Ferruh" <ferruh.yigit@intel.com>,
"pascal.mazon@6wind.com" <pascal.mazon@6wind.com>,
"Varghese, Vipin" <vipin.varghese@intel.com>,
"thomas@monjalon.net" <thomas@monjalon.net>
Cc: "dev@dpdk.org" <dev@dpdk.org>
Subject: Re: [dpdk-dev] [PATCH] net/tap: fix memcpy with incorrect size
Date: Fri, 6 Apr 2018 11:50:32 +0000 [thread overview]
Message-ID: <E182254E98A5DA4EB1E657AC7CB9BD2A8B08890B@BGSMSX101.gar.corp.intel.com> (raw)
In-Reply-To: <20180406113031.30340-1-pbhagavatula@caviumnetworks.com>
> -----Original Message-----
> From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Pavan Nikhilesh
> Sent: Friday, April 6, 2018 7:31 PM
> To: jerin.jacob@caviumnetworks.com; Yigit, Ferruh <ferruh.yigit@intel.com>;
> pascal.mazon@6wind.com; Varghese, Vipin <vipin.varghese@intel.com>;
> thomas@monjalon.net
> Cc: dev@dpdk.org; Pavan Nikhilesh <pbhagavatula@caviumnetworks.com>
> Subject: [dpdk-dev] [PATCH] net/tap: fix memcpy with incorrect size
>
> Fix incorrect sizeof operation being used for getting mac addr size.
>
> Found while compiling with arm64 clang.
> drivers/net/tap/rte_eth_tap.c:1410:40: error: argument to 'sizeof' in
> 'memcpy' call is the same pointer type 'struct ether_addr *' as the
> destination; expected 'struct ether_addr' or an explicit length
> [-Werror,-Wsizeof-pointer-memaccess]
> rte_memcpy(&pmd->eth_addr, mac_addr, sizeof(mac_addr));
> ~~~~~~~~~~~~~~ ^~~~~~~~~~~~~~~~
>
> Fixes: bcab6c1d27fa ("net/tap: allow user MAC to be passed as args")
>
> Signed-off-by: Pavan Nikhilesh <pbhagavatula@caviumnetworks.com>
> ---
Good catch!
Acked-by: Zhiyong Yang <zhiyong.yang@intel.com>
next prev parent reply other threads:[~2018-04-06 11:50 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-04-06 11:30 Pavan Nikhilesh
2018-04-06 11:50 ` Yang, Zhiyong [this message]
2018-04-06 15:02 ` Ferruh Yigit
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=E182254E98A5DA4EB1E657AC7CB9BD2A8B08890B@BGSMSX101.gar.corp.intel.com \
--to=zhiyong.yang@intel.com \
--cc=dev@dpdk.org \
--cc=ferruh.yigit@intel.com \
--cc=jerin.jacob@caviumnetworks.com \
--cc=pascal.mazon@6wind.com \
--cc=pbhagavatula@caviumnetworks.com \
--cc=thomas@monjalon.net \
--cc=vipin.varghese@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).