From: "Yang, Zhiyong" <zhiyong.yang@intel.com>
To: "Bie, Tiwei" <tiwei.bie@intel.com>, "Hu, Jiayu" <jiayu.hu@intel.com>
Cc: "dev@dpdk.org" <dev@dpdk.org>
Subject: Re: [dpdk-dev] [PATCH v3] net/virtio-user: fix feature setting with vhost-net backend
Date: Fri, 11 May 2018 07:45:27 +0000 [thread overview]
Message-ID: <E182254E98A5DA4EB1E657AC7CB9BD2A8B0BE663@BGSMSX101.gar.corp.intel.com> (raw)
In-Reply-To: <20180511073316.isttci5kiuicuns2@debian>
> -----Original Message-----
> From: Bie, Tiwei
> Sent: Friday, May 11, 2018 3:33 PM
> To: Hu, Jiayu <jiayu.hu@intel.com>
> Cc: dev@dpdk.org; Yang, Zhiyong <zhiyong.yang@intel.com>
> Subject: Re: [PATCH v3] net/virtio-user: fix feature setting with vhost-net
> backend
>
> On Fri, May 11, 2018 at 03:26:07PM +0800, Jiayu Hu wrote:
> > When the backend is vhost-net, virtio-user must work in client mode
> > and needs to request features from the backend in virtio_user_dev_init().
> > But currently, virtio-user is assigned to default features in this case.
> >
> > This patch is to fix this inappropriate feature setting.
> >
> > Fixes: bd8f50a45d0f ("net/virtio-user: support server mode")
> > Signed-off-by: Jiayu Hu <jiayu.hu@intel.com>
> > Tested-by: Lei Yao <lei.a.yao@intel.com>
> > ---
> > changes in v3:
> > - remove unnecessary code change.
> > changes in v2:
> > - remove unnecessary indent change.
> > - change commit log.
> >
> > drivers/net/virtio/virtio_user/virtio_user_dev.c | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
Reviewed-by: Zhiyong Yang <zhyong.yang@intel.com>
next prev parent reply other threads:[~2018-05-11 7:46 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-05-07 6:50 [dpdk-dev] [PATCH] " Jiayu Hu
2018-05-08 2:49 ` Tiwei Bie
2018-05-08 7:44 ` Jiayu Hu
2018-05-10 5:04 ` Tiwei Bie
2018-05-10 8:33 ` Hu, Jiayu
2018-05-08 8:14 ` [dpdk-dev] [PATCH v2] " Jiayu Hu
2018-05-09 2:58 ` Yao, Lei A
2018-05-11 7:26 ` [dpdk-dev] [PATCH v3] " Jiayu Hu
2018-05-11 7:33 ` Tiwei Bie
2018-05-11 7:45 ` Yang, Zhiyong [this message]
2018-05-16 6:05 ` Maxime Coquelin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=E182254E98A5DA4EB1E657AC7CB9BD2A8B0BE663@BGSMSX101.gar.corp.intel.com \
--to=zhiyong.yang@intel.com \
--cc=dev@dpdk.org \
--cc=jiayu.hu@intel.com \
--cc=tiwei.bie@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).