From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga03.intel.com (mga03.intel.com [134.134.136.65]) by dpdk.org (Postfix) with ESMTP id 4D74AB403 for ; Sun, 22 Feb 2015 19:52:03 +0100 (CET) Received: from fmsmga001.fm.intel.com ([10.253.24.23]) by orsmga103.jf.intel.com with ESMTP; 22 Feb 2015 10:46:27 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.09,626,1418112000"; d="scan'208";a="669849713" Received: from irsmsx106.ger.corp.intel.com ([163.33.3.31]) by fmsmga001.fm.intel.com with ESMTP; 22 Feb 2015 10:52:00 -0800 Received: from irsmsx103.ger.corp.intel.com ([169.254.3.247]) by IRSMSX106.ger.corp.intel.com ([169.254.8.235]) with mapi id 14.03.0195.001; Sun, 22 Feb 2015 18:51:59 +0000 From: "Richardson, Bruce" To: David Marchand Thread-Topic: Testpmd returns error. Thread-Index: AQHQTqpsuQJ3NUSHaUSSYffwEd9lZpz82UgAgAAqqbE= Date: Sun, 22 Feb 2015 18:51:58 +0000 Message-ID: References: <54E9695A.5010509@igel.co.jp> <3376494.YE1J4OXSVA@xps13>, In-Reply-To: Accept-Language: en-GB, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Cc: "dev@dpdk.org" Subject: Re: [dpdk-dev] Testpmd returns error. X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 22 Feb 2015 18:52:03 -0000 On 22 Feb 2015, at 16:19, David Marchand > wrote: Hello, On Sun, Feb 22, 2015 at 3:17 PM, Thomas Monjalon > wrote: Hi Tetsuya, > Someone, could you please check it? It is possible that this patchset was not correctly tested. We might revert it or try to fix it. I think the decision should be done by its authors (Danny, Bruce), or the Linux EAL maintainer (David). Well, I need to have a deeper look at this change. I did not find time before my holidays. - I think there may be an issue with the use of resource0 instead of /dev/u= io. I am not sure uio mmap will be happy or I overlooked something trivial. - Testing proc type in pci_uio_map_resource() looks wrong to me, since we v= alidated earlier in this same function that we are in primary process. - uio_res->maps indexes are not the same as the pci resources, might trigge= r problems (and it clearly does not make it easy to read ...). And now we are reading sysfs twice. I would prefer this code is reworked so that we avoid those loops in eal_pc= i_uio.c. Anyway, I am still on holiday (I should have kept my laptop away ...), I wi= ll be back tomorrow. I suppose Bruce or Danny will come with a fix, let's decide what the best s= olution is at this moment. I'll take another look at this but unfortunately I don't think I can necess= arily reproduce this issue as it seems to occur with enic driver, but I wil= l try. -- David Marchand