From: "Wang, Haiyue" <haiyue.wang@intel.com>
To: Maxime Coquelin <maxime.coquelin@redhat.com>,
"Zhang, Qi Z" <qi.z.zhang@intel.com>,
"dev@dpdk.org" <dev@dpdk.org>
Subject: Re: [dpdk-dev] [PATCH v1] net/ice: change RSS RETA size to meet with ETH_RSS_RETA_SIZE_x
Date: Thu, 16 May 2019 16:29:58 +0000 [thread overview]
Message-ID: <E3B9F2FDCB65864C82CD632F23D8AB877335D75B@SHSMSX101.ccr.corp.intel.com> (raw)
In-Reply-To: <d2683e7d-418b-c3cd-ef2d-8eb7c2b5ae47@redhat.com>
> -----Original Message-----
> From: Maxime Coquelin [mailto:maxime.coquelin@redhat.com]
> Sent: Thursday, May 16, 2019 19:36
> To: Wang, Haiyue <haiyue.wang@intel.com>; Zhang, Qi Z
> <qi.z.zhang@intel.com>; dev@dpdk.org
> Subject: Re: [dpdk-dev] [PATCH v1] net/ice: change RSS RETA size to meet with
> ETH_RSS_RETA_SIZE_x
>
>
>
> On 5/14/19 3:19 PM, Haiyue Wang wrote:
> > Since ice can support 128, 512, 2K three RSS RETA size, and if set 2K
> > by default, this will make it not compatible with ETH_RSS_RETA_SIZE_x
> > value definition, limit it to 512 if the cap.rss_table_size exceeds
> > the max value 512.
>
> It looks like a fix, so "Fixes:" tag would we welcome.
>
Will add it in patch v2.
> > Signed-off-by: Haiyue Wang <haiyue.wang@intel.com>
> > ---
> > drivers/net/ice/ice_ethdev.c | 22 ++++++++++++++++------
> > 1 file changed, 16 insertions(+), 6 deletions(-)
> >
prev parent reply other threads:[~2019-05-16 16:30 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-05-14 13:19 Haiyue Wang
2019-05-14 13:19 ` Haiyue Wang
2019-05-16 11:35 ` Maxime Coquelin
2019-05-16 16:29 ` Wang, Haiyue [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=E3B9F2FDCB65864C82CD632F23D8AB877335D75B@SHSMSX101.ccr.corp.intel.com \
--to=haiyue.wang@intel.com \
--cc=dev@dpdk.org \
--cc=maxime.coquelin@redhat.com \
--cc=qi.z.zhang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).