From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id D93EAA0487 for ; Tue, 2 Jul 2019 08:21:16 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id B74BE5905; Tue, 2 Jul 2019 08:21:16 +0200 (CEST) Received: from mga09.intel.com (mga09.intel.com [134.134.136.24]) by dpdk.org (Postfix) with ESMTP id C104058C6; Tue, 2 Jul 2019 08:21:14 +0200 (CEST) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga006.fm.intel.com ([10.253.24.20]) by orsmga102.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 01 Jul 2019 23:21:13 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.63,442,1557212400"; d="scan'208";a="362511990" Received: from fmsmsx104.amr.corp.intel.com ([10.18.124.202]) by fmsmga006.fm.intel.com with ESMTP; 01 Jul 2019 23:21:09 -0700 Received: from fmsmsx120.amr.corp.intel.com (10.18.124.208) by fmsmsx104.amr.corp.intel.com (10.18.124.202) with Microsoft SMTP Server (TLS) id 14.3.439.0; Mon, 1 Jul 2019 23:21:09 -0700 Received: from shsmsx108.ccr.corp.intel.com (10.239.4.97) by fmsmsx120.amr.corp.intel.com (10.18.124.208) with Microsoft SMTP Server (TLS) id 14.3.439.0; Mon, 1 Jul 2019 23:21:09 -0700 Received: from shsmsx101.ccr.corp.intel.com ([169.254.1.134]) by SHSMSX108.ccr.corp.intel.com ([169.254.8.174]) with mapi id 14.03.0439.000; Tue, 2 Jul 2019 14:21:07 +0800 From: "Wang, Haiyue" To: "Ye, Xiaolong" CC: "dev@dpdk.org" , "stable@dpdk.org" Thread-Topic: [dpdk-dev] [PATCH v2] app/testpmd: fix setting RSS queue rule failure on fedora30 Thread-Index: AQHVK0MBHkkcCwpFYE2DKjkDkHTr3aa2z62AgAAWKwA= Date: Tue, 2 Jul 2019 06:21:06 +0000 Message-ID: References: <1561459083-29808-1-git-send-email-haiyue.wang@intel.com> <20190702130043.GA86373@intel.com> In-Reply-To: <20190702130043.GA86373@intel.com> Accept-Language: zh-CN, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiNWM2YzNmNjYtNzYxYi00ZjcyLWJkNjAtYzZhMDVmOWEwZmZkIiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX05UIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE3LjEwLjE4MDQuNDkiLCJUcnVzdGVkTGFiZWxIYXNoIjoicGtJSkdNbDJweGk4ZGxkcUVFbDFlZ095dlJHUmd0NjEwMG9PTUE5N2ZoSUhkNXdZa2d5dFRGZmJzekpZbFB0dSJ9 x-ctpclassification: CTP_NT dlp-product: dlpe-windows dlp-version: 11.2.0.6 dlp-reaction: no-action x-originating-ip: [10.239.127.40] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH v2] app/testpmd: fix setting RSS queue rule failure on fedora30 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Hi > -----Original Message----- > From: Ye, Xiaolong > Sent: Tuesday, July 2, 2019 21:01 > To: Wang, Haiyue > Cc: dev@dpdk.org; stable@dpdk.org > Subject: Re: [dpdk-dev] [PATCH v2] app/testpmd: fix setting RSS queue rul= e failure on fedora30 >=20 > On 06/25, Haiyue Wang wrote: > >Declare a local variable 'arg' to hold the pointer to ARGS_ENTRY_ARB, > >otherwise, the pop 'arg' in 'parse_int' holds wrong data like 'arg-> > >offset =3D 5912737, arg->size =3D 0', this caused the parse failure. > > > >If calling like 'push_args(ctx, ARGS_ENTRY_ARB..)', the below code for > >assgining 'offset & size' will be missed for some gcc optimization. > > > >parse_vc_action_rss_queue > > 29c5: c5 f9 ef c0 vpxor %xmm0,%xmm0,%xmm0 > > 29c9: 43 8d 44 24 68 lea 0x68(%r12,%r12,1),%eax > > 29ce: 48 c7 44 24 20 00 00 movq $0x0,0x20(%rsp) > > 29d5: 00 00 > > 29d7: c5 f8 29 44 24 10 vmovaps %xmm0,0x10(%rsp) > > 29dd: 89 44 24 18 mov %eax,0x18(%rsp) > > 29e1: 48 63 83 0c 01 00 00 movslq 0x10c(%rbx),%rax > > 29e8: c7 44 24 1c 02 00 00 movl $0x2,0x1c(%rsp) > > 29ef: 00 > > 29f0: c5 f8 29 04 24 vmovaps %xmm0,(%rsp) > > > >The above assembly code is from this modification with: > > gcc version 9.1.1 20190503 (Red Hat 9.1.1-1) (GCC) > > Fedora release 30 (Thirty) > > 5.1.11-300.fc30.x86_64 >=20 > Do you mean without your patch, the above assembly code (for assgining of= fset & size) > is missing, after apply this patch, it would show up? >=20 Yes. > > > >Fixes: d0ad8648b1c5 ("app/testpmd: fix RSS flow action configuration") > >Cc: stable@dpdk.org > > > >Signed-off-by: Haiyue Wang > >--- >=20 > Minor nit, better to reply the v2 to v1 and add some changelog after the = `---` > mark. Got it, will notice next time, thanks! >=20 > > app/test-pmd/cmdline_flow.c | 9 +++++---- > > 1 file changed, 5 insertions(+), 4 deletions(-) > > > >diff --git a/app/test-pmd/cmdline_flow.c b/app/test-pmd/cmdline_flow.c > >index 201bd9d..4a083d4 100644 > >--- a/app/test-pmd/cmdline_flow.c > >+++ b/app/test-pmd/cmdline_flow.c > >@@ -3378,6 +3378,7 @@ parse_vc_action_rss_queue(struct context *ctx, con= st struct token *token, > > { > > static const enum index next[] =3D NEXT_ENTRY(ACTION_RSS_QUEUE); > > struct action_rss_data *action_rss_data; > >+ const struct arg *arg; > > int ret; > > int i; > > > >@@ -3393,10 +3394,10 @@ parse_vc_action_rss_queue(struct context *ctx, c= onst struct token *token, > > } > > if (i >=3D ACTION_RSS_QUEUE_NUM) > > return -1; > >- if (push_args(ctx, > >- ARGS_ENTRY_ARB(offsetof(struct action_rss_data, queue) + > >- i * sizeof(action_rss_data->queue[i]), > >- sizeof(action_rss_data->queue[i])))) > >+ arg =3D ARGS_ENTRY_ARB(offsetof(struct action_rss_data, queue) + > >+ i * sizeof(action_rss_data->queue[i]), > >+ sizeof(action_rss_data->queue[i])); > >+ if (push_args(ctx, arg)) > > return -1; > > ret =3D parse_int(ctx, token, str, len, NULL, 0); > > if (ret < 0) { >=20 > For the patch, Reviewed-by: Xiaolong Ye >=20 > Thanks, > Xiaolong >=20 > >-- > >2.7.4 > >