From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 4873FA0471 for ; Fri, 19 Jul 2019 04:17:45 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 93B735680; Fri, 19 Jul 2019 04:17:44 +0200 (CEST) Received: from mga17.intel.com (mga17.intel.com [192.55.52.151]) by dpdk.org (Postfix) with ESMTP id E68502BE5; Fri, 19 Jul 2019 04:17:41 +0200 (CEST) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga003.fm.intel.com ([10.253.24.29]) by fmsmga107.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 18 Jul 2019 19:17:41 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.64,280,1559545200"; d="scan'208";a="176175282" Received: from fmsmsx105.amr.corp.intel.com ([10.18.124.203]) by FMSMGA003.fm.intel.com with ESMTP; 18 Jul 2019 19:17:41 -0700 Received: from fmsmsx118.amr.corp.intel.com (10.18.116.18) by FMSMSX105.amr.corp.intel.com (10.18.124.203) with Microsoft SMTP Server (TLS) id 14.3.439.0; Thu, 18 Jul 2019 19:17:40 -0700 Received: from shsmsx152.ccr.corp.intel.com (10.239.6.52) by fmsmsx118.amr.corp.intel.com (10.18.116.18) with Microsoft SMTP Server (TLS) id 14.3.439.0; Thu, 18 Jul 2019 19:17:40 -0700 Received: from shsmsx101.ccr.corp.intel.com ([169.254.1.134]) by SHSMSX152.ccr.corp.intel.com ([169.254.6.22]) with mapi id 14.03.0439.000; Fri, 19 Jul 2019 10:17:38 +0800 From: "Wang, Haiyue" To: "Zhang, Xiao" , "dev@dpdk.org" CC: "Xing, Beilei" , "Zhang, Qi Z" , "stable@dpdk.org" Thread-Topic: [v4] net/i40e: fix SFP X722 not work with FW4.16 Thread-Index: AQHVPdZPU8mPwQnR9Uy+3IBguSgdj6bRNE3Q Date: Fri, 19 Jul 2019 02:17:37 +0000 Message-ID: References: <1563531994-10076-1-git-send-email-xiao.zhang@intel.com> <1563533997-10878-1-git-send-email-xiao.zhang@intel.com> In-Reply-To: <1563533997-10878-1-git-send-email-xiao.zhang@intel.com> Accept-Language: zh-CN, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiOTVmOGI0YWYtMDI5NS00ZTM0LThhM2YtY2MyZjUxYTFhNjhhIiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX05UIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE3LjEwLjE4MDQuNDkiLCJUcnVzdGVkTGFiZWxIYXNoIjoiNWJCV2dkaFJRV08waTJMTjV1WW1oejdqT1k2SEw4TEE0UW4wMWwzTlZsVjlraXpVNExaQ0Zja1kyMHIrNUI4eCJ9 x-ctpclassification: CTP_NT dlp-product: dlpe-windows dlp-version: 11.2.0.6 dlp-reaction: no-action x-originating-ip: [10.239.127.40] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [v4] net/i40e: fix SFP X722 not work with FW4.16 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" > -----Original Message----- > From: Zhang, Xiao > Sent: Friday, July 19, 2019 19:00 > To: dev@dpdk.org > Cc: Xing, Beilei ; Wang, Haiyue ; Zhang, Qi Z > ; Zhang, Xiao ; stable@dpdk.o= rg > Subject: [v4] net/i40e: fix SFP X722 not work with FW4.16 >=20 > The code checked the NVM API version of FW to check if support adminq > operation, when version is 1.7 or above adminq operation is support > and the adminq flag will be set. The code will use adminq to set TPID if > the flags set or to use register. The NVM API version of SFP X722 old > versions are lowwer than 1.7 and for FW4.16 is 1.8. But FW4.16 of SFP > X722 does not support adminq operation, the legacy logic is not compatibl= e > with device SFP X722 currently. Check the device id to unset adminq > flag to use resigter setting to make it work. >=20 > Fixes: 73cd7d6dc8e1 ("net/i40e: use set switch AQ instead of register > setting") > Cc: stable@dpdk.org >=20 > Signed-off-by: Xiao Zhang > --- Reviewed-by: Haiyue Wang