From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 1264CA2EFC for ; Thu, 19 Sep 2019 03:44:50 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id A866D1E4EA; Thu, 19 Sep 2019 03:44:48 +0200 (CEST) Received: from mga05.intel.com (mga05.intel.com [192.55.52.43]) by dpdk.org (Postfix) with ESMTP id 9F25E1D453 for ; Thu, 19 Sep 2019 03:44:46 +0200 (CEST) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga007.jf.intel.com ([10.7.209.58]) by fmsmga105.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 18 Sep 2019 18:44:45 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.64,522,1559545200"; d="scan'208";a="177899061" Received: from fmsmsx104.amr.corp.intel.com ([10.18.124.202]) by orsmga007.jf.intel.com with ESMTP; 18 Sep 2019 18:44:45 -0700 Received: from fmsmsx162.amr.corp.intel.com (10.18.125.71) by fmsmsx104.amr.corp.intel.com (10.18.124.202) with Microsoft SMTP Server (TLS) id 14.3.439.0; Wed, 18 Sep 2019 18:44:41 -0700 Received: from shsmsx154.ccr.corp.intel.com (10.239.6.54) by fmsmsx162.amr.corp.intel.com (10.18.125.71) with Microsoft SMTP Server (TLS) id 14.3.439.0; Wed, 18 Sep 2019 18:44:41 -0700 Received: from shsmsx102.ccr.corp.intel.com ([169.254.2.113]) by SHSMSX154.ccr.corp.intel.com ([169.254.7.195]) with mapi id 14.03.0439.000; Thu, 19 Sep 2019 09:44:25 +0800 From: "Wang, Haiyue" To: "Ye, Xiaolong" , "Rong, Leyi" CC: "Lu, Wenzhuo" , "Zhang, Qi Z" , "dev@dpdk.org" Thread-Topic: [PATCH v3 3/5] net/ice: add protocol extraction support for per Rx queue Thread-Index: AQHVbTXHj65vky9JZ0yDSqMmwN77/acxkYaAgACqgTA= Date: Thu, 19 Sep 2019 01:44:25 +0000 Message-ID: References: <20190829023421.112551-1-leyi.rong@intel.com> <20190917085317.57598-1-leyi.rong@intel.com> <20190917085317.57598-4-leyi.rong@intel.com> <20190918233017.GA77813@intel.com> In-Reply-To: <20190918233017.GA77813@intel.com> Accept-Language: zh-CN, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiZmMyZGE5OTUtMjJjZi00NTE4LWI1M2ItZWI3YmZjODg5ODYwIiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX05UIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE3LjEwLjE4MDQuNDkiLCJUcnVzdGVkTGFiZWxIYXNoIjoidm1wY05ETldhT1gzR2RTVnNnXC9OWjRVY3RmNXFsckJrM3pcL0pTdElrRGY2U1V4M0xEbWpGV1ptSDdIMGl2eHVXIn0= x-ctpclassification: CTP_NT dlp-product: dlpe-windows dlp-version: 11.2.0.6 dlp-reaction: no-action x-originating-ip: [10.239.127.40] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH v3 3/5] net/ice: add protocol extraction support for per Rx queue X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" > -----Original Message----- > From: Ye, Xiaolong > Sent: Thursday, September 19, 2019 07:30 > To: Rong, Leyi > Cc: Wang, Haiyue ; Lu, Wenzhuo ; Zhang, Qi Z > ; dev@dpdk.org > Subject: Re: [PATCH v3 3/5] net/ice: add protocol extraction support for = per Rx queue >=20 > On 09/17, Leyi Rong wrote: > >From: Haiyue Wang > > > >The ice has the feature to extract protocol fields into flex descriptor > >by programming per queue. Currently, the ice PMD will put the protocol > >fields into rte_mbuf::udata64 with different type format. Application > >can access the protocol fields quickly. > > [snip] > >+ > >+ rte_kvargs_process(kvlist, ICE_PROTO_XTR_ARG, > >+ handle_proto_xtr_arg, devargs); >=20 > Do we need to check ret of rte_kvargs_process here and change ice_parse_p= roto_xtr_devarg > to return int? >=20 May be return error is a good idea, if the application wants to use it. I j= ust give a graceful warning message. Will change it, thanks! PMD_DRV_LOG(ERR, "The protocol extraction parameter is wrong : '%s'", value); return -1; > >-- > >2.17.1 > >