From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id D7593A0613 for ; Mon, 23 Sep 2019 13:03:25 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 49A331BE9D; Mon, 23 Sep 2019 13:03:25 +0200 (CEST) Received: from mga07.intel.com (mga07.intel.com [134.134.136.100]) by dpdk.org (Postfix) with ESMTP id D172A1BE9C for ; Mon, 23 Sep 2019 13:03:23 +0200 (CEST) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga002.fm.intel.com ([10.253.24.26]) by orsmga105.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 23 Sep 2019 04:03:22 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.64,539,1559545200"; d="scan'208";a="218500268" Received: from fmsmsx108.amr.corp.intel.com ([10.18.124.206]) by fmsmga002.fm.intel.com with ESMTP; 23 Sep 2019 04:03:22 -0700 Received: from fmsmsx116.amr.corp.intel.com (10.18.116.20) by FMSMSX108.amr.corp.intel.com (10.18.124.206) with Microsoft SMTP Server (TLS) id 14.3.439.0; Mon, 23 Sep 2019 04:03:22 -0700 Received: from shsmsx104.ccr.corp.intel.com (10.239.4.70) by fmsmsx116.amr.corp.intel.com (10.18.116.20) with Microsoft SMTP Server (TLS) id 14.3.439.0; Mon, 23 Sep 2019 04:03:22 -0700 Received: from shsmsx102.ccr.corp.intel.com ([169.254.2.113]) by SHSMSX104.ccr.corp.intel.com ([169.254.5.32]) with mapi id 14.03.0439.000; Mon, 23 Sep 2019 19:03:20 +0800 From: "Wang, Haiyue" To: "Ye, Xiaolong" , "Yang, Qiming" CC: "Rong, Leyi" , "Lu, Wenzhuo" , "Zhang, Qi Z" , "dev@dpdk.org" Thread-Topic: [dpdk-dev] [PATCH v4 3/6] net/ice: add protocol extraction support for per Rx queue Thread-Index: AQHVcb6TW0g01wRQPkO9g3nGAM+gsac4aImAgACwjtA= Date: Mon, 23 Sep 2019 11:03:19 +0000 Message-ID: References: <20190829023421.112551-1-leyi.rong@intel.com> <20190919062553.79257-1-leyi.rong@intel.com> <20190919062553.79257-4-leyi.rong@intel.com> <20190923082951.GB5202@intel.com> In-Reply-To: <20190923082951.GB5202@intel.com> Accept-Language: zh-CN, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiY2U5YzBiYmItM2EzNC00NmIxLWEwNjItODE1OWRmNjdhOGY5IiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX05UIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE3LjEwLjE4MDQuNDkiLCJUcnVzdGVkTGFiZWxIYXNoIjoiaGlwdEZQaXlcL0dKaXZjaWM4Z3pVNDJkVmN6emowOEhJeFB4Nm1xTWNtUFNud2xOVllvRjc4MUdtMzFhM1wvVzlUIn0= x-ctpclassification: CTP_NT dlp-product: dlpe-windows dlp-version: 11.2.0.6 dlp-reaction: no-action x-originating-ip: [10.239.127.40] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH v4 3/6] net/ice: add protocol extraction support for per Rx queue X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" > -----Original Message----- > From: Ye, Xiaolong > Sent: Monday, September 23, 2019 16:30 > To: Yang, Qiming > Cc: Rong, Leyi ; Wang, Haiyue ; Lu, Wenzhuo > ; Zhang, Qi Z ; dev@dpdk.org > Subject: Re: [dpdk-dev] [PATCH v4 3/6] net/ice: add protocol extraction s= upport for per Rx queue >=20 > On 09/23, Yang, Qiming wrote: > > > > >=20 > [snip] >=20 > >> @@ -1378,9 +1666,18 @@ static int ice_parse_devargs(struct rte_eth_dev > >> *dev) > >> return -EINVAL; > >> } > >> > >> + memset(ad->devargs.proto_xtr, PROTO_XTR_NONE, > >> + sizeof(ad->devargs.proto_xtr)); > >> + > >> + ret =3D rte_kvargs_process(kvlist, ICE_PROTO_XTR_ARG, > >> + &handle_proto_xtr_arg, &ad->devargs); > >> + if (ret) > >> + goto bail; > >> + > > > >Why is bail? > > >=20 > Minor nit, better to snip unrelated context for one single comment, other= wise > it's quite difficult to find it. :) >=20 +1, I checked many lines very carefully to avoid miss something. :) > Thanks, > Xiaolong